* [PATCH] MIPS: mobileye: eyeq6h-epm6: Use eyeq6h in the board device tree
@ 2024-10-08 9:18 Gregory CLEMENT
2024-10-08 9:25 ` Krzysztof Kozlowski
2024-10-30 11:17 ` Thomas Bogendoerfer
0 siblings, 2 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2024-10-08 9:18 UTC (permalink / raw)
To: Vladimir Kondratiev, Théo Lebrun, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thomas Bogendoerfer
Cc: linux-mips, devicetree, linux-kernel, Théo Lebrun,
Tawfik Bayouk, Thomas Petazzoni, Gregory CLEMENT
There is currently no eyeq6 compatible string defined in the binding
documentation. Only eyeq6h version is defined, so let's use it.
Note that there are actually no codes relying on eyeq6h; the purpose
of this patch is mainly to be coherent with the documentation.
Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
---
arch/mips/boot/dts/mobileye/eyeq6h-epm6.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/boot/dts/mobileye/eyeq6h-epm6.dts b/arch/mips/boot/dts/mobileye/eyeq6h-epm6.dts
index ebc0d363fbf82..59a3e95050eb9 100644
--- a/arch/mips/boot/dts/mobileye/eyeq6h-epm6.dts
+++ b/arch/mips/boot/dts/mobileye/eyeq6h-epm6.dts
@@ -8,7 +8,7 @@
#include "eyeq6h.dtsi"
/ {
- compatible = "mobileye,eyeq6-epm6", "mobileye,eyeq6";
+ compatible = "mobileye,eyeq6h-epm6", "mobileye,eyeq6h";
model = "Mobile EyeQ6H MP6 Evaluation board";
chosen {
---
base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc
change-id: 20241008-eyq6h-dt-2c4ae1ec1157
Best regards,
--
Gregory CLEMENT <gregory.clement@bootlin.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] MIPS: mobileye: eyeq6h-epm6: Use eyeq6h in the board device tree
2024-10-08 9:18 [PATCH] MIPS: mobileye: eyeq6h-epm6: Use eyeq6h in the board device tree Gregory CLEMENT
@ 2024-10-08 9:25 ` Krzysztof Kozlowski
2024-10-08 10:03 ` Gregory CLEMENT
2024-10-30 11:17 ` Thomas Bogendoerfer
1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-10-08 9:25 UTC (permalink / raw)
To: Gregory CLEMENT, Vladimir Kondratiev, Théo Lebrun,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Thomas Bogendoerfer
Cc: linux-mips, devicetree, linux-kernel, Tawfik Bayouk,
Thomas Petazzoni
On 08/10/2024 11:18, Gregory CLEMENT wrote:
> There is currently no eyeq6 compatible string defined in the binding
> documentation. Only eyeq6h version is defined, so let's use it.
>
> Note that there are actually no codes relying on eyeq6h; the purpose
> of this patch is mainly to be coherent with the documentation.
>
> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
> ---
> arch/mips/boot/dts/mobileye/eyeq6h-epm6.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
That's a new platform, so you were supposed to make it warning free. I
think that dtbs_check were never really run here...
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: mobileye: eyeq6h-epm6: Use eyeq6h in the board device tree
2024-10-08 9:25 ` Krzysztof Kozlowski
@ 2024-10-08 10:03 ` Gregory CLEMENT
0 siblings, 0 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2024-10-08 10:03 UTC (permalink / raw)
To: Krzysztof Kozlowski, Vladimir Kondratiev, Théo Lebrun,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Thomas Bogendoerfer
Cc: linux-mips, devicetree, linux-kernel, Tawfik Bayouk,
Thomas Petazzoni
Krzysztof Kozlowski <krzk@kernel.org> writes:
> On 08/10/2024 11:18, Gregory CLEMENT wrote:
>> There is currently no eyeq6 compatible string defined in the binding
>> documentation. Only eyeq6h version is defined, so let's use it.
>>
>> Note that there are actually no codes relying on eyeq6h; the purpose
>> of this patch is mainly to be coherent with the documentation.
>>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
>> ---
>> arch/mips/boot/dts/mobileye/eyeq6h-epm6.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> That's a new platform, so you were supposed to make it warning free. I
> think that dtbs_check were never really run here...
Yes my bad. Sorry for that I won't do it again.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thanks!
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: mobileye: eyeq6h-epm6: Use eyeq6h in the board device tree
2024-10-08 9:18 [PATCH] MIPS: mobileye: eyeq6h-epm6: Use eyeq6h in the board device tree Gregory CLEMENT
2024-10-08 9:25 ` Krzysztof Kozlowski
@ 2024-10-30 11:17 ` Thomas Bogendoerfer
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Bogendoerfer @ 2024-10-30 11:17 UTC (permalink / raw)
To: Gregory CLEMENT
Cc: Vladimir Kondratiev, Théo Lebrun, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-mips, devicetree,
linux-kernel, Tawfik Bayouk, Thomas Petazzoni
On Tue, Oct 08, 2024 at 11:18:47AM +0200, Gregory CLEMENT wrote:
> There is currently no eyeq6 compatible string defined in the binding
> documentation. Only eyeq6h version is defined, so let's use it.
>
> Note that there are actually no codes relying on eyeq6h; the purpose
> of this patch is mainly to be coherent with the documentation.
>
> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
> ---
> arch/mips/boot/dts/mobileye/eyeq6h-epm6.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/boot/dts/mobileye/eyeq6h-epm6.dts b/arch/mips/boot/dts/mobileye/eyeq6h-epm6.dts
> index ebc0d363fbf82..59a3e95050eb9 100644
> --- a/arch/mips/boot/dts/mobileye/eyeq6h-epm6.dts
> +++ b/arch/mips/boot/dts/mobileye/eyeq6h-epm6.dts
> @@ -8,7 +8,7 @@
> #include "eyeq6h.dtsi"
>
> / {
> - compatible = "mobileye,eyeq6-epm6", "mobileye,eyeq6";
> + compatible = "mobileye,eyeq6h-epm6", "mobileye,eyeq6h";
> model = "Mobile EyeQ6H MP6 Evaluation board";
>
> chosen {
>
> ---
> base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc
> change-id: 20241008-eyq6h-dt-2c4ae1ec1157
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-30 11:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-08 9:18 [PATCH] MIPS: mobileye: eyeq6h-epm6: Use eyeq6h in the board device tree Gregory CLEMENT
2024-10-08 9:25 ` Krzysztof Kozlowski
2024-10-08 10:03 ` Gregory CLEMENT
2024-10-30 11:17 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).