From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A61F8C001DC for ; Mon, 17 Jul 2023 12:30:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229583AbjGQMam (ORCPT ); Mon, 17 Jul 2023 08:30:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229664AbjGQMam (ORCPT ); Mon, 17 Jul 2023 08:30:42 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3986E1 for ; Mon, 17 Jul 2023 05:30:39 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2b73564e98dso65318761fa.3 for ; Mon, 17 Jul 2023 05:30:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689597038; x=1692189038; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gqQWmYE6mikijhb+URcDev0GUwlO46fou+/8hKL8alM=; b=mWgM8gyI1LxJ1jt6p/Q+x1NKUulK53177cNhF7OyRsJsz7I93+gwnms4okO/iXydlR rTvVNgxyxjBasNNzXg9KcSj21F5063ezsBs5U0OS8gU+stxomq2U81zCOUiSjPGBOPEo ZrLAiSfXQlJEuVxwIC4ByBiE0pEabcdybjTcl9ITBpHF6NR02eFUUhhS6q3fcDBP5nEc x2ocG2P47WWDNEHD5I9l7JxKMx1zKTzhtLv1gD8Hi/5HBTl/aNL3eDr14Dc1PnvSlvwT vvmRM0aLSM2bQsqbMw3m0if2rsV/vJAGYKrPPjpj57qToM/gvKyKFhc2qp0MsPP7eWh5 aYBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689597038; x=1692189038; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gqQWmYE6mikijhb+URcDev0GUwlO46fou+/8hKL8alM=; b=aRM83jlB0prJEdny0YFe3VmPftGHxjkfrQaEPBFP1CDRJrA7sQu+2WUhoBr0GICbf5 rOwQbNYrvLKkJ21NPMp222tlnv5DrXOfl210bZdbHPwnnnlv5TEE8CztjMhUiCHgzIta QidM/hkLS9j0rQ8HqQ8xnvp93N0uqe0nKCEwwoz/i2RWbCnb80N8KuOi+qlv8aB+5Pz+ tnxeDXxylvBBnRiv0uJtoD67UzsLQ5dK7rUBGFoByDUaTIOTL/u4zGvANQQorhpoJUFi uv2dueeJfFAxW81rMAKHcKEg3Uk5nwpUoxkDZ6jLIETNfiIa8+6IRtK7I+rnlTPAx1GI XyyA== X-Gm-Message-State: ABy/qLa4cFosLKZH7O7s4xtXTQiw0UhB3J1X/xSV+jC/iez/UoA5p4WI zMQsm5WjDxrW4hhxEMg7mJowXQ== X-Google-Smtp-Source: APBJJlGDlL4uhDaQA6bjvwYThu/no32RAotlFuO5WDtVQINe1DbwFu1bJcmSSoEmuJ0ncS3RJ93q0w== X-Received: by 2002:a2e:978d:0:b0:2b6:df5d:8e08 with SMTP id y13-20020a2e978d000000b002b6df5d8e08mr8104203lji.28.1689597037933; Mon, 17 Jul 2023 05:30:37 -0700 (PDT) Received: from [192.168.1.101] (abyj181.neoplus.adsl.tpnet.pl. [83.9.29.181]) by smtp.gmail.com with ESMTPSA id a26-20020a2e861a000000b002b6c9927a3csm3649783lji.37.2023.07.17.05.30.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jul 2023 05:30:37 -0700 (PDT) Message-ID: Date: Mon, 17 Jul 2023 14:30:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] arm64: dts: qcom: msm8916-samsung-e2015: Add accelerometer To: "Lin, Meng-Bo" , linux-kernel@vger.kernel.org Cc: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stephan Gerhold , Nikita Travkin , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht References: <20230715204128.12612-1-linmengbo0689@protonmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20230715204128.12612-1-linmengbo0689@protonmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 15.07.2023 22:41, Lin, Meng-Bo wrote: > E5, E7 and Grand Max have ST LIS2HH12 accelerometer. > Add support for it. > > Signed-off-by: Stephan Gerhold > Signed-off-by: Lin, Meng-Bo > --- Potentially missing Co-Developed-by? > .../qcom/msm8916-samsung-e2015-common.dtsi | 21 +++++++++++++++++-- > 1 file changed, 19 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-e2015-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-e2015-common.dtsi > index 0cdd6af7817f..ef7c7ac40e05 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-e2015-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-e2015-common.dtsi > @@ -42,10 +42,27 @@ reg_touch_key: regulator-touch-key { > > &blsp_i2c2 { > /* lis2hh12 accelerometer instead of BMC150 */ > - status = "disabled"; > - > /delete-node/ accelerometer@10; > /delete-node/ magnetometer@12; > + > + accelerometer@1d { > + compatible = "st,lis2hh12"; > + reg = <0x1d>; > + > + interrupt-parent = <&msmgpio>; > + interrupts = <115 IRQ_TYPE_LEVEL_HIGH>; interrupts-extended = <&msmgpio 115 IRQ_TYPE_LEVEL_HIGH>; Konrad > + > + vdd-supply = <&pm8916_l5>; > + vddio-supply = <&pm8916_l5>; > + > + st,drdy-int-pin = <1>; > + mount-matrix = "1", "0", "0", > + "0", "-1", "0", > + "0", "0", "1"; > + > + pinctrl-0 = <&accel_int_default>; > + pinctrl-names = "default"; > + }; > }; > > ®_motor_vdd {