Re: [PATCH v2 1/3] dt-bindings: media: qcom,qcm2290-venus: document shikra Iris compatible

[Bryan O'Donoghue <bod@kernel.org>]

On 11/06/2026 20:49, Vikash Garodia wrote:
> Document the iris video accelerator used on shikra platforms by adding
> the qcom,shikra-iris compatible.
> 
> Although QCM2290 and shikra share the same video hardware and overall
> integration, their SMMU programming differs. QCM2290 exposes separate
> stream IDs for the video hardware and the Xtensa path, requiring two
> explicit IOMMU entries, whereas shikra uses a masked SMR to collapse
> equivalent stream IDs into a single mapping. Due to QCM2290’s SID layout
> and Xtensa isolation requirements, such SMR masking is not applicable on
> QCM2290 platforms.
> Since shikra uses the same video hardware as QCM2290 and shares the same
> programming model and capabilities, it is added as a fallback compatible
> to qcom,qcm2290-venus, with conditional handling to allow either one or
> two IOMMU entries.
> 
> Signed-off-by: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
> ---
>   .../bindings/media/qcom,qcm2290-venus.yaml         | 26 ++++++++++++++++------
>   1 file changed, 19 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml b/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml
> index 5977e7d0a71b4fb5681f1c2094439c251366f01f..dec7051224d1610b8b3dcb1750152eeda95d3703 100644
> --- a/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml
> @@ -13,14 +13,13 @@ description:
>     The Venus AR50_LITE IP is a video encode and decode accelerator present
>     on Qualcomm platforms.
> 
> -allOf:
> -  - $ref: qcom,venus-common.yaml#
> -
>   properties:
>     compatible:
>       oneOf:
>         - items:
> -          - const: qcom,sm6115-venus
> +          - enum:
> +              - qcom,shikra-iris
> +              - qcom,sm6115-venus
I still think this is not an accurate name.

https://lore.kernel.org/linux-arm-msm/q3sr74ncqnmzsjrd6jdbkpplxpnsnifhnvxsdplvogr2kf25p3@taadnzd2qrcu/

Best practice if you _aren't_ acting on previous feedback is to document 
it in your cover letter.

https://lore.kernel.org/linux-arm-msm/20260612-shikra_vpu-v2-0-bf8727370a1e@oss.qualcomm.com

Either way that naming comment still needs to be resolved.

---
bod