From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Rohit Agarwal <quic_rohiagar@quicinc.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
agross@kernel.org, andersson@kernel.org,
linus.walleij@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm7550ba support
Date: Thu, 6 Jul 2023 17:23:04 +0200 [thread overview]
Message-ID: <f8152ec7-e38f-d215-3e1f-3165912b4031@linaro.org> (raw)
In-Reply-To: <a50921ca-c858-dacc-6849-4898fdf7683c@quicinc.com>
On 6.07.2023 17:11, Rohit Agarwal wrote:
>
> On 7/6/2023 8:34 PM, Konrad Dybcio wrote:
>> On 6.07.2023 16:45, Rohit Agarwal wrote:
>>> On 7/6/2023 8:05 PM, Krzysztof Kozlowski wrote:
>>>> On 06/07/2023 15:30, Rohit Agarwal wrote:
>>>>> Add support for the pm7550ba GPIO support to the Qualcomm PMIC GPIO
>>>>> binding.
>>>>>
>>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>>>> ---
>>>>> Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 3 +++
>>>> I doubt that all your patches here and other patchsets are v1. Otherwise
>>>> how did you get my Acks and Rbs? Please use proper versioning and
>>>> provide changelog.
>>>>
>>>> What changed here?
>>> Actually this is part of the original bigger series [1] that as per Bjorn's suggestion need to be broken
>>> down according to the subsystem/maintainer.
>>> Since it got broken down into multiple smaller series, I didnt include the versioning.
>> All of that information should be included in the cover letter, to
>> limit confusion both for maintainers and patch workflow tools.
>>
>> Since these patches all come from a separate series, it would be
>> good for you to version this one as v(BIG_SERIES_REVISION)+1 because
>> they've already been on LKML at least once. That would especially hold
>> true if this revision included any changes.
> Understood. Will send all the smaller series again with v2 as version with changelog.
v3, this was essentially a v2.
Konrad
>
> Thanks,
> Rohit.
>> Konrad
>>> [1] https://lore.kernel.org/all/9de424ca-271a-8ed2-5550-658a828c4ea5@quicinc.com/
>>>
>>>> Best regards,
>>>> Krzysztof
>>>>
next prev parent reply other threads:[~2023-07-06 15:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 13:30 [PATCH 0/4] Add support for pinctrl in pmic chips Rohit Agarwal
2023-07-06 13:30 ` [PATCH 1/4] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm7550ba support Rohit Agarwal
2023-07-06 14:35 ` Krzysztof Kozlowski
2023-07-06 14:45 ` Rohit Agarwal
2023-07-06 15:04 ` Konrad Dybcio
2023-07-06 15:11 ` Rohit Agarwal
2023-07-06 15:23 ` Konrad Dybcio [this message]
2023-07-06 15:29 ` Rohit Agarwal
2023-07-06 13:30 ` [PATCH 2/4] dt-bindings: pinctrl: qcom-pmic-gpio: Add pmx75 support Rohit Agarwal
2023-07-06 13:30 ` [PATCH 3/4] pinctrl: qcom-pmic-gpio: Add support for pm7550ba Rohit Agarwal
2023-07-06 13:30 ` [PATCH 4/4] pinctrl: qcom-pmic-gpio: Add support for pmx75 Rohit Agarwal
2023-07-06 15:02 ` [PATCH 0/4] Add support for pinctrl in pmic chips Konrad Dybcio
2023-07-06 15:09 ` Rohit Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8152ec7-e38f-d215-3e1f-3165912b4031@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_rohiagar@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).