From: Dan Murphy <dmurphy@ti.com>
To: Sekhar Nori <nsekhar@ti.com>, Faiz Abbas <faiz_abbas@ti.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-can@vger.kernel.org>
Cc: <catalin.marinas@arm.com>, <mark.rutland@arm.com>,
<robh+dt@kernel.org>, <davem@davemloft.net>, <mkl@pengutronix.de>,
<wg@grandegger.com>, <sriram.dash@samsung.com>, <nm@ti.com>,
<t-kristo@ti.com>
Subject: Re: [PATCH 1/3] dt-bindings: net: can: m_can: Add Documentation for stb-gpios
Date: Wed, 22 Jan 2020 08:34:20 -0600 [thread overview]
Message-ID: <f834087b-da1c-88a0-93fe-bc72c8ac71ff@ti.com> (raw)
In-Reply-To: <8fc7c343-267d-c91c-0381-60990cfc35e8@ti.com>
Sekhar
On 1/22/20 8:24 AM, Sekhar Nori wrote:
> On 22/01/20 7:05 PM, Dan Murphy wrote:
>> Faiz
>>
>> On 1/22/20 2:03 AM, Faiz Abbas wrote:
>>> The CAN transceiver on some boards has an STB pin which is
>>> used to control its standby mode. Add an optional property
>>> stb-gpios to toggle the same.
>>>
>>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
>>> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
>>> ---
>>> Documentation/devicetree/bindings/net/can/m_can.txt | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/can/m_can.txt
>>> b/Documentation/devicetree/bindings/net/can/m_can.txt
>>> index ed614383af9c..cc8ba3f7a2aa 100644
>>> --- a/Documentation/devicetree/bindings/net/can/m_can.txt
>>> +++ b/Documentation/devicetree/bindings/net/can/m_can.txt
>>> @@ -48,6 +48,8 @@ Optional Subnode:
>>> that can be used for CAN/CAN-FD modes. See
>>>
>>> Documentation/devicetree/bindings/net/can/can-transceiver.txt
>>> for details.
>>> +stb-gpios : gpio node to toggle the STB (standby) signal on
>>> the transceiver
>>> +
>> The m_can.txt is for the m_can framework. If this is specific to the
>> platform then it really does not belong here.
>>
>> If the platform has specific nodes then maybe we need a
>> m_can_platform.txt binding for specific platform nodes. But I leave
>> that decision to Rob.
> Since this is transceiver enable, should this not be in
> Documentation/devicetree/bindings/net/can/can-transceiver.txt?
+1
Dan
next prev parent reply other threads:[~2020-01-22 14:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 8:03 [PATCH 0/3] Add Support for MCAN in AM654x-idk Faiz Abbas
2020-01-22 8:03 ` [PATCH 1/3] dt-bindings: net: can: m_can: Add Documentation for stb-gpios Faiz Abbas
2020-01-22 13:35 ` Dan Murphy
2020-01-22 14:24 ` Sekhar Nori
2020-01-22 14:34 ` Dan Murphy [this message]
2020-01-23 7:39 ` Faiz Abbas
2020-02-03 12:06 ` Rob Herring
2020-02-17 13:53 ` Faiz Abbas
2020-01-22 8:03 ` [PATCH 2/3] can: m_can: m_can_platform: Add support for enabling transceiver through the STB line Faiz Abbas
2020-01-22 14:53 ` Sriram Dash
2020-01-22 8:03 ` [PATCH 3/3] arm64: defconfig: Add Support for Bosch M_CAN controllers Faiz Abbas
2020-01-23 11:17 ` [PATCH 0/3] Add Support for MCAN in AM654x-idk Marc Kleine-Budde
2020-01-23 11:46 ` Faiz Abbas
2020-01-23 11:54 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f834087b-da1c-88a0-93fe-bc72c8ac71ff@ti.com \
--to=dmurphy@ti.com \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=faiz_abbas@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=sriram.dash@samsung.com \
--cc=t-kristo@ti.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox