From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3E9B36D for ; Fri, 24 May 2024 07:08:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716534526; cv=none; b=sdOVrJkZ/wMBqBXo7xp27RoqLsxjyOIsXrCZ8XkypBzj9TiPnFQERrXzuugo4gKLVw+5qXMAELU/wpKqacAjUD+eB9QlpaHqY98xKzEmvi6EXn4B9jcVoueLtTxCzcnj0dFDVjIDesLZu+Yg7OVBG635gl5wdNXTTEO7XGrBQoI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716534526; c=relaxed/simple; bh=0zL78J9MpyFNUiYWqKOJbE1a9M+z4vN5gFKzhKamHTM=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=hqY8Yv2r3Z7nmPvFk4LkSGjGm8M6MoRRMzD5jN5cC+Teaa1SNY7dXPmFAR4+OD2qZPEYKrwrvk+sHgFxbr4qvlqN9wJ9CojJp+W9OX8Pyiw8+PQruV2oeuNelKPdcNsPvZzZx+U48q/pGB3C7D00JQsSLsME5bTg75xK+w7tW0o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ePDb2sDG; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ePDb2sDG" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-52962423ed8so550429e87.2 for ; Fri, 24 May 2024 00:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716534523; x=1717139323; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=E8MAm3h3NI5iKT+iweY3kApju3idNJyvBAdIptvUy6g=; b=ePDb2sDGAdYyCu4xf77GuFpwdQjgaSkotctDzWD/LFYyN2WEdkp3EkPzFXZiI3MSYu eL+EiCAwGuxFV2pcTFaOpsdEyTxySSQFmI3CP77F7KqaWHI/FUiAqBVPR4UIEuUvJnFk TBZkSH+yLMAJ+J+oVjKfLMfaRfg0uZlYZeS384BTizckgGp1mRs4F+lpbqBnX1I9kUs/ tIgrvDjRrCgWOu60zzmgUsKGzdc/qyO7cMkEXEmYWfKSOW3JnfX6N2eNCpA4M8cp2DSY 44TQBmTUvLwdK7Vg1UpvWOnlJ8MZxzoCBoffR0inSQh0KFE7Nl/KpYaTDnoFPtxYqYJI yb+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716534523; x=1717139323; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=E8MAm3h3NI5iKT+iweY3kApju3idNJyvBAdIptvUy6g=; b=VZhgEqM6retSFuhZOyzBFU3podv7KjDcUByYhwPnbAa5o8sjsSu+gGiLyAALikJcki jyYjyDeaLycErVJIEQobb/JRQNsfmktawXsiHcp+NyuiFuZJXX5F5jmWtCaogsvGqbFZ XNYbOdxglK8zmsdbYwAGs/meagNIngU81tKhRgX6i1la1Rb/g/vkOT0qPiAuCKmEamkh 99v+r49O5enjp1R7fmo3pyl4tE/KF4rZEr4PsGYLX9JPAVFfpzuXNelVE34A3Xs+N86V 5QQcUqAdYYMpaSjlk/xE6YmHMsW1DFOVqDuroqq0pIawT6VHEBecvpyQ+LH2JhZUeju/ ywyg== X-Forwarded-Encrypted: i=1; AJvYcCUkdhQ9Tfme2yoiQcXbn7k/aYMispgfld8fg1s1A948XCUJwHHg0bor64KIiw/SOW2kTCvmTQfx4o+K6ZwHBxcRc+LdeY8kli6nHA== X-Gm-Message-State: AOJu0YzpIUUSMhUYxrU6fPEXpQfYFh6JlFStnYU+a+6k4gRJznUuBzXD RIQ/MlA5CKWo8hSSj3xi3JhA1Jdn4XWBeQGCQOo6QJQYe95+g57cze1fiH/P8Vc= X-Google-Smtp-Source: AGHT+IEEwe7apvr6NvFS8zzXW6dwrwy77zqWwTpWL0vW66DGjKQDCMmPQg9s5wT1CDWXq/2wlTSXiw== X-Received: by 2002:a05:6512:4cb:b0:521:54b5:86a3 with SMTP id 2adb3069b0e04-5296717fec4mr687397e87.64.1716534522716; Fri, 24 May 2024 00:08:42 -0700 (PDT) Received: from [192.168.7.32] (212-114-21-58.box.freepro.com. [212.114.21.58]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-421089cda51sm12113335e9.47.2024.05.24.00.08.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 May 2024 00:08:42 -0700 (PDT) Message-ID: Date: Fri, 24 May 2024 09:08:38 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH RFT 0/7] arm64: qcom: allow up to 4 lanes for the Type-C DisplayPort Altmode To: Luca Weiss , Konrad Dybcio , Bjorn Andersson Cc: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Abhinav Kumar , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240229-topic-sm8x50-upstream-phy-combo-typec-mux-v1-0-07e24a231840@linaro.org> <7a7aa05f-9ae6-4ca0-a423-224fc78fbd0c@linaro.org> <236a104c-fc16-4b3d-9a00-e16517c00e3a@linaro.org> <963b60e5-6ab7-4d9f-885a-ba744c2b7991@linaro.org> <864063fb-eeae-4eb7-9089-0d98011a0343@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 24/05/2024 08:51, Luca Weiss wrote: > On Thu May 23, 2024 at 11:06 AM CEST, wrote: >> Hi Lucas, >> >> On 10/05/2024 08:51, Luca Weiss wrote: >>> On Tue Apr 23, 2024 at 4:08 PM CEST, wrote: >>>> On 23/04/2024 15:03, Konrad Dybcio wrote: >>>>> >>>>> >>>>> On 4/5/24 12:19, Luca Weiss wrote: >> >> >> >>> >>> Next, with DP 4 lane (not working on mainline but still plugged into a >>> screen) the diff is quite a bit bigger. >>> >>> See attachments for the full files: >>> * usb_1_qmpphy_20240503_151052_android_4lane.txt >>> * usb_1_qmpphy_20240503_122443_mainline_4lane.txt >>> >>> Not attaching the diff because it's quite a lot >>> $ diff --ignore-case -U0 usb_1_qmpphy_20240503_151052_android_4lane.txt usb_1_qmpphy_20240503_122443_mainline_4lane.txt >>> >>> Not sure this is helpful to anyone, but at least wanted to share what >>> I've done so far here. >> >> Thanks a lot for the traces, it founds out the QPHY_V3_DP_COM_PHY_MODE_CTRL stays at 0x3, >> which means the mode doesn't get broadcasted to the phy because.... the retimer only broadcasts >> the orientation and not the mode... and it works on the HDKs and the X13s because they don't have retimers. > > Hi Neil, > > This was it! > >> >> So I made the changes in nb7vpq904m and ptn36502 drivers to get the next mux and broadcast the typec mode, >> if you find time could you test it ? >> >> Bjorn could you also test on the rb3gen2 ? >> >> The changes: >> https://git.codelinaro.org/neil.armstrong/linux/-/commit/a61fb3b816ecbe28a12480367d9e09b700ec09e1 > > With this ptn36502 patch on top, I can confirm that DP 4-lane seems to > work on qcm6490-fairphone-fp5 smartphone with DP over USB-C! > > Tested with a USB-C dongle that only has a HDMI port on the other side > (so no USB), and cat'ing dp_debug while connected showed num_lanes = 4 > > So feel free to add my: > > Tested-by: Luca Weiss Thanks a lot for testing, spinning a v2 with those patches! Neil > > Regards > Luca > >> https://git.codelinaro.org/neil.armstrong/linux/-/commit/f6f976ff692bad430cd945f02b835e355f19632b >> >> Thanks, >> Neil >> >>> >>> Regards >>> Luca >>> >>>> >>>> Neil >>>> >>>>> >>>>> Konrad >>> >>> >