From: Thor Thayer <tthayer@opensource.altera.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, arnd@arndb.de,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
inux@armlinux.org.uk, robh+dt@kernel.org, geert@linux-m68k.org,
dinguyen@opensource.altera.com, davem@davemloft.net,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] mfd: altr-a10sr: Add Arria10 SR Monitor
Date: Wed, 26 Oct 2016 10:18:32 -0500 [thread overview]
Message-ID: <f85a537e-716f-cc40-a47a-0f2345526fef@opensource.altera.com> (raw)
In-Reply-To: <20161026125233.GL11267@dell>
On 10/26/2016 07:52 AM, Lee Jones wrote:
> On Thu, 13 Oct 2016, tthayer@opensource.altera.com wrote:
>
>> From: Thor Thayer <tthayer@opensource.altera.com>
>>
>> Add the Altera Arria10 DevKit System Resource Monitor functionality
>> to the MFD device.
>>
>> Signed-off-by: Thor Thayer <tthayer@opensource.altera.com>
>> ---
>> drivers/mfd/altera-a10sr.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/mfd/altera-a10sr.c b/drivers/mfd/altera-a10sr.c
>> index 06e1f7f..0942d7d 100644
>> --- a/drivers/mfd/altera-a10sr.c
>> +++ b/drivers/mfd/altera-a10sr.c
>> @@ -33,6 +33,10 @@
>> .name = "altr_a10sr_gpio",
>> .of_compatible = "altr,a10sr-gpio",
>> },
>> + {
>> + .name = "altr_a10sr_mon",
>> + .of_compatible = "altr,a10sr-mon",
>
> "-monitor" would be better in my opinion.
>
OK. I'm flexible and it is clearer. I'll make the changes and resubmit.
Thanks for reviewing!
>> + },
>> };
>>
>> static bool altr_a10sr_reg_readable(struct device *dev, unsigned int reg)
>
prev parent reply other threads:[~2016-10-26 15:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 21:32 [PATCH 0/4] Add Altera A10SR Status & Control Monitor tthayer
[not found] ` <1476394329-31696-1-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2016-10-13 21:32 ` [PATCH 1/4] dt-bindings: mfd: Add Altera Arria10 SR Monitor tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
[not found] ` <1476394329-31696-2-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2016-10-18 14:05 ` Rob Herring
2016-10-26 12:51 ` Lee Jones
2016-10-13 21:32 ` [PATCH 4/4] ARM: socfpga: dts: Add Monitor to A10-SR MFD tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
2016-10-13 21:32 ` [PATCH 2/4] misc: Add Altera Arria10 System Resource Control tthayer
2016-10-13 21:32 ` [PATCH 3/4] mfd: altr-a10sr: Add Arria10 SR Monitor tthayer
2016-10-26 12:52 ` Lee Jones
2016-10-26 15:18 ` Thor Thayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f85a537e-716f-cc40-a47a-0f2345526fef@opensource.altera.com \
--to=tthayer@opensource.altera.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@opensource.altera.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=inux@armlinux.org.uk \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).