* [PATCH 0/4] Add Altera A10SR Status & Control Monitor
@ 2016-10-13 21:32 tthayer
[not found] ` <1476394329-31696-1-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: tthayer @ 2016-10-13 21:32 UTC (permalink / raw)
To: lee.jones, robh+dt, mark.rutland, dinguyen, inux, arnd, gregkh
Cc: davem, geert, devicetree, linux-kernel, linux-arm-kernel,
Thor Thayer
From: Thor Thayer <tthayer@opensource.altera.com>
This patch series adds the Altera Arria10 DevKit System Resource
chip's Status and Control Monitor to the A10SR Multi-Function
Device. An earlier patch added this to the hwmon class which
wasn't the proper place so this functionality is added to the
misc directory.
Thor Thayer (4):
dt-bindings: mfd: Add Altera Arria10 SR Monitor
misc: Add Altera Arria10 System Resource Control
mfd: altr-a10sr: Add Arria10 SR Monitor
ARM: socfpga: dts: Add Monitor to A10-SR MFD
.../devicetree/bindings/mfd/altera-a10sr.txt | 9 +
MAINTAINERS | 1 +
arch/arm/boot/dts/socfpga_arria10_socdk.dtsi | 4 +
drivers/mfd/altera-a10sr.c | 4 +
drivers/misc/Kconfig | 7 +
drivers/misc/Makefile | 1 +
drivers/misc/altera-a10sr-mon.c | 184 ++++++++++++++++++++
7 files changed, 210 insertions(+)
create mode 100644 drivers/misc/altera-a10sr-mon.c
--
1.7.9.5
^ permalink raw reply [flat|nested] 9+ messages in thread[parent not found: <1476394329-31696-1-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>]
* [PATCH 1/4] dt-bindings: mfd: Add Altera Arria10 SR Monitor [not found] ` <1476394329-31696-1-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> @ 2016-10-13 21:32 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx [not found] ` <1476394329-31696-2-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> 2016-10-26 12:51 ` Lee Jones 2016-10-13 21:32 ` [PATCH 4/4] ARM: socfpga: dts: Add Monitor to A10-SR MFD tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 1 sibling, 2 replies; 9+ messages in thread From: tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx @ 2016-10-13 21:32 UTC (permalink / raw) To: lee.jones-QSEj5FYQhm4dnm+yROfE0A, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx, inux-I+IVW8TIWO2tmTQ+vhA3Yw, arnd-r2nGTMty4D4, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r Cc: davem-fT/PcQaiUtIeIZ0/mPfg9Q, geert-Td1EMuHUCqxL1ZNQvxDV9g, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Thor Thayer From: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> Add the Arria10 DevKit System Resource Chip register and state monitoring module to the MFD. Signed-off-by: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> --- Note: This needs to be applied to the bindings document that was Acked & Applied but didn't reach the for-next branch. See https://patchwork.ozlabs.org/patch/629397/ --- --- .../devicetree/bindings/mfd/altera-a10sr.txt | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/altera-a10sr.txt b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt index ea151f2..0787ec6 100644 --- a/Documentation/devicetree/bindings/mfd/altera-a10sr.txt +++ b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt @@ -18,6 +18,7 @@ The A10SR consists of these sub-devices: Device Description ------ ---------- a10sr_gpio GPIO Controller +a10sr_monitor Register and State Monitoring Arria10 GPIO Required Properties: @@ -27,6 +28,10 @@ Required Properties: the second cell is used to specify flags. See ../gpio/gpio.txt for more information. +Arria10 Register and State Monitor +Required Properties: +- compatible : Should be "altr,a10sr-mon" + Example: resource-manager@0 { @@ -43,4 +48,8 @@ Example: gpio-controller; #gpio-cells = <2>; }; + + a10sr_monitor { + compatible = "altr,a10sr-mon"; + }; }; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 9+ messages in thread
[parent not found: <1476394329-31696-2-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>]
* Re: [PATCH 1/4] dt-bindings: mfd: Add Altera Arria10 SR Monitor [not found] ` <1476394329-31696-2-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> @ 2016-10-18 14:05 ` Rob Herring 0 siblings, 0 replies; 9+ messages in thread From: Rob Herring @ 2016-10-18 14:05 UTC (permalink / raw) To: tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx Cc: lee.jones-QSEj5FYQhm4dnm+yROfE0A, mark.rutland-5wv7dgnIgG8, dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx, inux-I+IVW8TIWO2tmTQ+vhA3Yw, arnd-r2nGTMty4D4, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r, davem-fT/PcQaiUtIeIZ0/mPfg9Q, geert-Td1EMuHUCqxL1ZNQvxDV9g, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Thu, Oct 13, 2016 at 04:32:06PM -0500, tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org wrote: > From: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> > > Add the Arria10 DevKit System Resource Chip register and state > monitoring module to the MFD. > > Signed-off-by: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> > --- > Note: This needs to be applied to the bindings document that > was Acked & Applied but didn't reach the for-next branch. > See https://patchwork.ozlabs.org/patch/629397/ > --- > --- > .../devicetree/bindings/mfd/altera-a10sr.txt | 9 +++++++++ > 1 file changed, 9 insertions(+) Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/4] dt-bindings: mfd: Add Altera Arria10 SR Monitor 2016-10-13 21:32 ` [PATCH 1/4] dt-bindings: mfd: Add Altera Arria10 SR Monitor tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx [not found] ` <1476394329-31696-2-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> @ 2016-10-26 12:51 ` Lee Jones 1 sibling, 0 replies; 9+ messages in thread From: Lee Jones @ 2016-10-26 12:51 UTC (permalink / raw) To: tthayer Cc: mark.rutland, devicetree, arnd, gregkh, linux-kernel, inux, robh+dt, geert, dinguyen, davem, linux-arm-kernel On Thu, 13 Oct 2016, tthayer@opensource.altera.com wrote: > From: Thor Thayer <tthayer@opensource.altera.com> > > Add the Arria10 DevKit System Resource Chip register and state > monitoring module to the MFD. > > Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> > --- > Note: This needs to be applied to the bindings document that > was Acked & Applied but didn't reach the for-next branch. > See https://patchwork.ozlabs.org/patch/629397/ > --- > --- > .../devicetree/bindings/mfd/altera-a10sr.txt | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/altera-a10sr.txt b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt > index ea151f2..0787ec6 100644 > --- a/Documentation/devicetree/bindings/mfd/altera-a10sr.txt > +++ b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt > @@ -18,6 +18,7 @@ The A10SR consists of these sub-devices: > Device Description > ------ ---------- > a10sr_gpio GPIO Controller > +a10sr_monitor Register and State Monitoring > > Arria10 GPIO > Required Properties: > @@ -27,6 +28,10 @@ Required Properties: > the second cell is used to specify flags. > See ../gpio/gpio.txt for more information. > > +Arria10 Register and State Monitor > +Required Properties: > +- compatible : Should be "altr,a10sr-mon" Why not "-monitor"? > Example: > > resource-manager@0 { > @@ -43,4 +48,8 @@ Example: > gpio-controller; > #gpio-cells = <2>; > }; > + > + a10sr_monitor { > + compatible = "altr,a10sr-mon"; > + }; > }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 4/4] ARM: socfpga: dts: Add Monitor to A10-SR MFD [not found] ` <1476394329-31696-1-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> 2016-10-13 21:32 ` [PATCH 1/4] dt-bindings: mfd: Add Altera Arria10 SR Monitor tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx @ 2016-10-13 21:32 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 1 sibling, 0 replies; 9+ messages in thread From: tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx @ 2016-10-13 21:32 UTC (permalink / raw) To: lee.jones-QSEj5FYQhm4dnm+yROfE0A, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx, inux-I+IVW8TIWO2tmTQ+vhA3Yw, arnd-r2nGTMty4D4, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r Cc: davem-fT/PcQaiUtIeIZ0/mPfg9Q, geert-Td1EMuHUCqxL1ZNQvxDV9g, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Thor Thayer From: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> Add the Monitor functionality to the Arria10 DevKit System Resource chip. Signed-off-by: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> --- arch/arm/boot/dts/socfpga_arria10_socdk.dtsi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi b/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi index eb00ae3..183d88b 100644 --- a/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi +++ b/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi @@ -121,6 +121,10 @@ gpio-controller; #gpio-cells = <2>; }; + + a10sr_monitor { + compatible = "altr,a10sr-mon"; + }; }; }; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/4] misc: Add Altera Arria10 System Resource Control 2016-10-13 21:32 [PATCH 0/4] Add Altera A10SR Status & Control Monitor tthayer [not found] ` <1476394329-31696-1-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> @ 2016-10-13 21:32 ` tthayer 2016-10-13 21:32 ` [PATCH 3/4] mfd: altr-a10sr: Add Arria10 SR Monitor tthayer 2 siblings, 0 replies; 9+ messages in thread From: tthayer @ 2016-10-13 21:32 UTC (permalink / raw) To: lee.jones, robh+dt, mark.rutland, dinguyen, inux, arnd, gregkh Cc: devicetree, linux-kernel, geert, Thor Thayer, davem, linux-arm-kernel From: Thor Thayer <tthayer@opensource.altera.com> This patch adds the Altera Arria10 control & monitoring functions to the Arria10 System Resource chip. Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> --- MAINTAINERS | 1 + drivers/misc/Kconfig | 7 ++ drivers/misc/Makefile | 1 + drivers/misc/altera-a10sr-mon.c | 184 +++++++++++++++++++++++++++++++++++++++ 4 files changed, 193 insertions(+) create mode 100644 drivers/misc/altera-a10sr-mon.c diff --git a/MAINTAINERS b/MAINTAINERS index 1cd38a7..a0919ec 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -625,6 +625,7 @@ M: Thor Thayer <tthayer@opensource.altera.com> S: Maintained F: drivers/gpio/gpio-altera-a10sr.c F: drivers/mfd/altera-a10sr.c +F: drivers/misc/altera-a10sr-mon.c F: include/linux/mfd/altera-a10sr.h ALTERA TRIPLE SPEED ETHERNET DRIVER diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig index 64971ba..9dd33c4 100644 --- a/drivers/misc/Kconfig +++ b/drivers/misc/Kconfig @@ -766,6 +766,13 @@ config PANEL_BOOT_MESSAGE An empty message will only clear the display at driver init time. Any other printf()-formatted message is valid with newline and escape codes. +config ALTERA_A10SR_MON + tristate "Altera Arria10 System Resource Monitor" + depends on MFD_ALTERA_A10SR + help + This enables the System Resource monitor driver for the Altera + Arria10 DevKit. + source "drivers/misc/c2port/Kconfig" source "drivers/misc/eeprom/Kconfig" source "drivers/misc/cb710/Kconfig" diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile index 3198336..fd69f0c 100644 --- a/drivers/misc/Makefile +++ b/drivers/misc/Makefile @@ -43,6 +43,7 @@ obj-y += ti-st/ obj-y += lis3lv02d/ obj-$(CONFIG_USB_SWITCH_FSA9480) += fsa9480.o obj-$(CONFIG_ALTERA_STAPL) +=altera-stapl/ +obj-$(CONFIG_ALTERA_A10SR_MON) += altera-a10sr-mon.o obj-$(CONFIG_INTEL_MEI) += mei/ obj-$(CONFIG_VMWARE_VMCI) += vmw_vmci/ obj-$(CONFIG_LATTICE_ECP3_CONFIG) += lattice-ecp3-config.o diff --git a/drivers/misc/altera-a10sr-mon.c b/drivers/misc/altera-a10sr-mon.c new file mode 100644 index 0000000..c07fb97 --- /dev/null +++ b/drivers/misc/altera-a10sr-mon.c @@ -0,0 +1,184 @@ +/* + * Copyright Altera Corporation (C) 2014-2016. All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify it + * under the terms and conditions of the GNU General Public License, + * version 2, as published by the Free Software Foundation. + * + * This program is distributed in the hope it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * You should have received a copy of the GNU General Public License along with + * this program. If not, see <http://www.gnu.org/licenses/>. + * + * Monitor driver for the Altera Arria10 MAX5 System Resource Chip + * Adapted from ics932s401.c + */ + +#include <linux/err.h> +#include <linux/mfd/altera-a10sr.h> +#include <linux/module.h> +#include <linux/platform_device.h> +#include <linux/slab.h> + +struct altr_a10sr_regs { + struct regmap *regmap; + struct attribute_group attr_grp; +}; + +static ssize_t a10sr_show(struct device *dev, + struct device_attribute *devattr, char *buf); +static ssize_t a10sr_store(struct device *dev, + struct device_attribute *devattr, const char *buf, + size_t count); + +/* Define FS entries */ +static DEVICE_ATTR(max5_version, 0444, a10sr_show, NULL); +static DEVICE_ATTR(max5_led, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_button, 0444, a10sr_show, NULL); +static DEVICE_ATTR(max5_button_irq, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_pg1, 0444, a10sr_show, NULL); +static DEVICE_ATTR(max5_pg2, 0444, a10sr_show, NULL); +static DEVICE_ATTR(max5_pg3, 0444, a10sr_show, NULL); +static DEVICE_ATTR(max5_fmcab, 0444, a10sr_show, NULL); +static DEVICE_ATTR(max5_hps_resets, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_per_resets, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_sfpa, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_sfpb, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_i2c_master, 0644, a10sr_show, a10sr_store); +static DEVICE_ATTR(max5_wm_rst, 0444, a10sr_show, NULL); +static DEVICE_ATTR(max5_wm_rst_key, 0444, a10sr_show, NULL); +static DEVICE_ATTR(max5_pmbus, 0644, a10sr_show, a10sr_store); + +static struct attribute *altr_a10sr_attr[] = { + &dev_attr_max5_version.attr, + &dev_attr_max5_led.attr, + &dev_attr_max5_button.attr, + &dev_attr_max5_button_irq.attr, + &dev_attr_max5_pg1.attr, + &dev_attr_max5_pg2.attr, + &dev_attr_max5_pg3.attr, + &dev_attr_max5_fmcab.attr, + &dev_attr_max5_hps_resets.attr, + &dev_attr_max5_per_resets.attr, + &dev_attr_max5_sfpa.attr, + &dev_attr_max5_sfpb.attr, + &dev_attr_max5_i2c_master.attr, + &dev_attr_max5_wm_rst.attr, + &dev_attr_max5_wm_rst_key.attr, + &dev_attr_max5_pmbus.attr, + NULL +}; + +static const struct attribute_group a10sr_attr_group = { + .attrs = altr_a10sr_attr, +}; + +static ssize_t a10sr_show(struct device *dev, struct device_attribute *devattr, + char *buf) +{ + int i, ret; + unsigned int val; + struct altr_a10sr_regs *a10sr_regs = dev_get_drvdata(dev); + + for (i = 0; i < ARRAY_SIZE(altr_a10sr_attr); i++) { + if (devattr == (struct device_attribute *)altr_a10sr_attr[i]) + break; + } + + if (i >= ARRAY_SIZE(altr_a10sr_attr)) + return -EINVAL; + + /* Shift because LS bit signifies Read/Write */ + i <<= 1; + ret = regmap_read(a10sr_regs->regmap, i, &val); + if (ret < 0) + return ret; + + return sprintf(buf, "0x%X\n", val); +} + +static ssize_t a10sr_store(struct device *dev, + struct device_attribute *devattr, const char *buf, + size_t count) +{ + struct altr_a10sr_regs *a10sr_regs = dev_get_drvdata(dev); + unsigned long val; + int i, ret; + + ret = kstrtol(buf, 0, &val); + if (ret < 0) + return ret; + + for (i = 0; i < ARRAY_SIZE(altr_a10sr_attr); i++) { + if (devattr == (struct device_attribute *)altr_a10sr_attr[i]) + break; + } + if (i >= ARRAY_SIZE(altr_a10sr_attr)) + return -EINVAL; + + /* Shift because LS bit signifies Read/Write */ + i <<= 1; + ret = regmap_write(a10sr_regs->regmap, i, val); + if (ret < 0) + return ret; + + return count; +} + +static int altr_a10sr_regs_probe(struct platform_device *pdev) +{ + int ret; + struct altr_a10sr_regs *a10regs; + struct altr_a10sr *a10sr = dev_get_drvdata(pdev->dev.parent); + + a10regs = devm_kzalloc(&pdev->dev, sizeof(*a10regs), GFP_KERNEL); + if (!a10regs) + return -ENOMEM; + + a10regs->regmap = a10sr->regmap; + a10regs->attr_grp = a10sr_attr_group; + + platform_set_drvdata(pdev, a10regs); + + ret = sysfs_create_group(&pdev->dev.kobj, &a10sr_attr_group); + if (ret) + goto err_mem; + + return 0; + +err_mem: + return ret; +} + +static int altr_a10sr_regs_remove(struct platform_device *pdev) +{ + struct altr_a10sr_regs *a10regs = platform_get_drvdata(pdev); + + sysfs_remove_group(&pdev->dev.kobj, &a10regs->attr_grp); + + return 0; +} + +static const struct of_device_id altr_a10sr_regs_of_match[] = { + { .compatible = "altr,a10sr-mon" }, + { }, +}; +MODULE_DEVICE_TABLE(of, altr_a10sr_regs_of_match); + +static struct platform_driver altr_a10sr_regs_driver = { + .probe = altr_a10sr_regs_probe, + .remove = altr_a10sr_regs_remove, + .driver = { + .name = "altr_a10sr_mon", + .of_match_table = altr_a10sr_regs_of_match, + }, +}; + +module_platform_driver(altr_a10sr_regs_driver); + +MODULE_LICENSE("GPL v2"); +MODULE_AUTHOR("Thor Thayer"); +MODULE_DESCRIPTION("Monitor Driver for Altera Arria10 System Resource Chip"); -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 3/4] mfd: altr-a10sr: Add Arria10 SR Monitor 2016-10-13 21:32 [PATCH 0/4] Add Altera A10SR Status & Control Monitor tthayer [not found] ` <1476394329-31696-1-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> 2016-10-13 21:32 ` [PATCH 2/4] misc: Add Altera Arria10 System Resource Control tthayer @ 2016-10-13 21:32 ` tthayer 2016-10-26 12:52 ` Lee Jones 2 siblings, 1 reply; 9+ messages in thread From: tthayer @ 2016-10-13 21:32 UTC (permalink / raw) To: lee.jones, robh+dt, mark.rutland, dinguyen, inux, arnd, gregkh Cc: davem, geert, devicetree, linux-kernel, linux-arm-kernel, Thor Thayer From: Thor Thayer <tthayer@opensource.altera.com> Add the Altera Arria10 DevKit System Resource Monitor functionality to the MFD device. Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> --- drivers/mfd/altera-a10sr.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/mfd/altera-a10sr.c b/drivers/mfd/altera-a10sr.c index 06e1f7f..0942d7d 100644 --- a/drivers/mfd/altera-a10sr.c +++ b/drivers/mfd/altera-a10sr.c @@ -33,6 +33,10 @@ .name = "altr_a10sr_gpio", .of_compatible = "altr,a10sr-gpio", }, + { + .name = "altr_a10sr_mon", + .of_compatible = "altr,a10sr-mon", + }, }; static bool altr_a10sr_reg_readable(struct device *dev, unsigned int reg) -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 3/4] mfd: altr-a10sr: Add Arria10 SR Monitor 2016-10-13 21:32 ` [PATCH 3/4] mfd: altr-a10sr: Add Arria10 SR Monitor tthayer @ 2016-10-26 12:52 ` Lee Jones 2016-10-26 15:18 ` Thor Thayer 0 siblings, 1 reply; 9+ messages in thread From: Lee Jones @ 2016-10-26 12:52 UTC (permalink / raw) To: tthayer Cc: robh+dt, mark.rutland, dinguyen, inux, arnd, gregkh, davem, geert, devicetree, linux-kernel, linux-arm-kernel On Thu, 13 Oct 2016, tthayer@opensource.altera.com wrote: > From: Thor Thayer <tthayer@opensource.altera.com> > > Add the Altera Arria10 DevKit System Resource Monitor functionality > to the MFD device. > > Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> > --- > drivers/mfd/altera-a10sr.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mfd/altera-a10sr.c b/drivers/mfd/altera-a10sr.c > index 06e1f7f..0942d7d 100644 > --- a/drivers/mfd/altera-a10sr.c > +++ b/drivers/mfd/altera-a10sr.c > @@ -33,6 +33,10 @@ > .name = "altr_a10sr_gpio", > .of_compatible = "altr,a10sr-gpio", > }, > + { > + .name = "altr_a10sr_mon", > + .of_compatible = "altr,a10sr-mon", "-monitor" would be better in my opinion. > + }, > }; > > static bool altr_a10sr_reg_readable(struct device *dev, unsigned int reg) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3/4] mfd: altr-a10sr: Add Arria10 SR Monitor 2016-10-26 12:52 ` Lee Jones @ 2016-10-26 15:18 ` Thor Thayer 0 siblings, 0 replies; 9+ messages in thread From: Thor Thayer @ 2016-10-26 15:18 UTC (permalink / raw) To: Lee Jones Cc: mark.rutland, devicetree, arnd, gregkh, linux-kernel, inux, robh+dt, geert, dinguyen, davem, linux-arm-kernel On 10/26/2016 07:52 AM, Lee Jones wrote: > On Thu, 13 Oct 2016, tthayer@opensource.altera.com wrote: > >> From: Thor Thayer <tthayer@opensource.altera.com> >> >> Add the Altera Arria10 DevKit System Resource Monitor functionality >> to the MFD device. >> >> Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> >> --- >> drivers/mfd/altera-a10sr.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/mfd/altera-a10sr.c b/drivers/mfd/altera-a10sr.c >> index 06e1f7f..0942d7d 100644 >> --- a/drivers/mfd/altera-a10sr.c >> +++ b/drivers/mfd/altera-a10sr.c >> @@ -33,6 +33,10 @@ >> .name = "altr_a10sr_gpio", >> .of_compatible = "altr,a10sr-gpio", >> }, >> + { >> + .name = "altr_a10sr_mon", >> + .of_compatible = "altr,a10sr-mon", > > "-monitor" would be better in my opinion. > OK. I'm flexible and it is clearer. I'll make the changes and resubmit. Thanks for reviewing! >> + }, >> }; >> >> static bool altr_a10sr_reg_readable(struct device *dev, unsigned int reg) > ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-10-26 15:18 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-13 21:32 [PATCH 0/4] Add Altera A10SR Status & Control Monitor tthayer
[not found] ` <1476394329-31696-1-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2016-10-13 21:32 ` [PATCH 1/4] dt-bindings: mfd: Add Altera Arria10 SR Monitor tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
[not found] ` <1476394329-31696-2-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2016-10-18 14:05 ` Rob Herring
2016-10-26 12:51 ` Lee Jones
2016-10-13 21:32 ` [PATCH 4/4] ARM: socfpga: dts: Add Monitor to A10-SR MFD tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
2016-10-13 21:32 ` [PATCH 2/4] misc: Add Altera Arria10 System Resource Control tthayer
2016-10-13 21:32 ` [PATCH 3/4] mfd: altr-a10sr: Add Arria10 SR Monitor tthayer
2016-10-26 12:52 ` Lee Jones
2016-10-26 15:18 ` Thor Thayer
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).