From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 132F1C38142 for ; Thu, 19 Jan 2023 07:50:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229704AbjASHue (ORCPT ); Thu, 19 Jan 2023 02:50:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230200AbjASHtV (ORCPT ); Thu, 19 Jan 2023 02:49:21 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9A836C557 for ; Wed, 18 Jan 2023 23:47:08 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id n7so967679wrx.5 for ; Wed, 18 Jan 2023 23:47:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6Xf6l0pkTfUQcg4s8+KxcfrawM+/+acLE7U/I+YkgqU=; b=HrbySDZwWkFSdLCzEXOLs+V+c7gkYZ6AExZCLr+NnmyUpp8N4Anc9Iifb0OmxEDgRK LliDSj2RcZiSm2fEnw+hf/QjrpXb5sZE15ijxtyEOU6g2E1zpMKl26nT23mbVE8mYo0k V17qUu5V196yRzkaQXIGyNi6UH+Qwoh9a5Vf3Lt5/V/JvaBh0iktV4lqC0dCeWB/2E0A L8fFj9HhfFQSKZc7UnU0zps0mYU27k60DWTN2oy5VyYKa9lMpdxO4fWjsqQPqfhRpDTI YbXzZGOxAdPjLIQJrN1ETEYU9M9jO21Ddp+adUdG7WO9uB1q47KLSlv9dmrSvXJ7W6Za 5Ysw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6Xf6l0pkTfUQcg4s8+KxcfrawM+/+acLE7U/I+YkgqU=; b=kBuc17XvvuFhAENbazcJKNMCHdVyrKMV4uewo9xNxzbLPkPZ2GX8uRMXNUYYi8IIVs Q9CyC8nC3Hib8Rp1e+02gSv8a0LUpLqnYvvRhZBZbLN4X1NRgYnsDdBzBzDBJ0re+70l g6IEHrFs2bP/aKdkJ+vhHADc7rGaY3RVOOFl9Nmlq6Th66a6vfL9MkNnT3B6kTbZsBJK SkpR9EYcmyj7qxl8NU/iClOgvbgqdCrNoQKo5JDEYiMHnstil5oBk75vqMOsYIKjrup8 ZCFkv0Sz80B+V7U/m02kQIqqyFDDzFugphLSj3iRNUdNVT66DH389nAzECW+5/x2uXSf g1Cw== X-Gm-Message-State: AFqh2koZpcs2PvwDpllM92ZCiJ2vjuJlxjW1s1GmkS63MvDgwAnkl2I5 gI27XnM+oYMMJl2YO6YnWwsCpA== X-Google-Smtp-Source: AMrXdXuS8zdsDRinJUZd6MTyyHb3fpLxBdnccwy/4L69izCoZWdPOKRFFyFqnBBwK+HpW9Gq3M3pog== X-Received: by 2002:a5d:5251:0:b0:27e:7f5:6634 with SMTP id k17-20020a5d5251000000b0027e07f56634mr8289121wrc.60.1674114426892; Wed, 18 Jan 2023 23:47:06 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id q18-20020adfdfd2000000b002bdc129c8f6sm21608096wrn.43.2023.01.18.23.47.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jan 2023 23:47:06 -0800 (PST) Message-ID: Date: Thu, 19 Jan 2023 08:47:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH v9 02/15] dt-bindings: mmc: cdns: Add AMD Pensando Elba SoC Content-Language: en-US To: Brad Larson , linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-spi@vger.kernel.org, adrian.hunter@intel.com, alcooperx@gmail.com, andy.shevchenko@gmail.com, arnd@arndb.de, brad@pensando.io, brendan.higgins@linux.dev, briannorris@chromium.org, brijeshkumar.singh@amd.com, catalin.marinas@arm.com, davidgow@google.com, gsomlo@gmail.com, gerg@linux-m68k.org, krzk@kernel.org, krzysztof.kozlowski+dt@linaro.org, lee@kernel.org, lee.jones@linaro.org, broonie@kernel.org, yamada.masahiro@socionext.com, p.zabel@pengutronix.de, piotrs@cadence.com, p.yadav@ti.com, rdunlap@infradead.org, robh+dt@kernel.org, samuel@sholland.org, fancer.lancer@gmail.com, skhan@linuxfoundation.org, suravee.suthikulpanit@amd.com, thomas.lendacky@amd.com, tonyhuang.sunplus@gmail.com, ulf.hansson@linaro.org, vaishnav.a@ti.com, will@kernel.org, devicetree@vger.kernel.org References: <20230119035136.21603-1-blarson@amd.com> <20230119035136.21603-3-blarson@amd.com> From: Krzysztof Kozlowski In-Reply-To: <20230119035136.21603-3-blarson@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/01/2023 04:51, Brad Larson wrote: > AMD Pensando Elba ARM 64-bit SoC is integrated with this IP and > explicitly controls byte-lane enables. > > Signed-off-by: Brad Larson > > --- > > Changes since v6: > - Add reset-names and resets properties > - Add if/then on property amd,pensando-elba-sd4hc to set reg property > values for minItems and maxItems > > --- > .../devicetree/bindings/mmc/cdns,sdhci.yaml | 28 ++++++++++++++++++- > 1 file changed, 27 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > index 8b1a0fdcb5e3..f7dd6f990f96 100644 > --- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > +++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > @@ -16,12 +16,14 @@ properties: > compatible: > items: > - enum: > + - amd,pensando-elba-sd4hc > - microchip,mpfs-sd4hc > - socionext,uniphier-sd4hc > - const: cdns,sd4hc > > reg: > - maxItems: 1 > + minItems: 1 > + maxItems: 2 > > interrupts: > maxItems: 1 > @@ -111,12 +113,36 @@ properties: > minimum: 0 > maximum: 0x7f > > + reset-names: > + items: > + - const: hw > + > + resets: > + description: > + optional. phandle to the system reset controller with line index Drop "optional" Drop "phandle to the" and rephrase it to describe physical reset line. Don't describe here DT syntax (phandle) but the hardware. What is expected to be here? > + for mmc hw reset line if exists. > + maxItems: 1 > + > required: > - compatible > - reg > - interrupts > - clocks > > +if: Move the allO from the top here and put it under it. Saves indentation soon. > + properties: > + compatible: > + const: amd,pensando-elba-sd4hc > +then: > + properties: > + reg: > + minItems: 2 > +else: > + properties: > + reg: > + minItems: 1 > + maxItems: 2 No, why do you suddenly allow two items on all variants? This was not described in your commit msg at all, so I expect here maxItems: 1. Also, unless your reset is applicable to all variants, resets: false and reset-names: false. > + > unevaluatedProperties: false > > examples: Best regards, Krzysztof