From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E070DC001B0 for ; Tue, 8 Aug 2023 17:01:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233929AbjHHRBT (ORCPT ); Tue, 8 Aug 2023 13:01:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233887AbjHHRA3 (ORCPT ); Tue, 8 Aug 2023 13:00:29 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FC5D6190 for ; Tue, 8 Aug 2023 09:00:39 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-4fe0eb0ca75so9186022e87.2 for ; Tue, 08 Aug 2023 09:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691510404; x=1692115204; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RE7wtMExHdhFwKLLqjqt4LfjR7+37ThDsOcCDy3qTQQ=; b=PwDjsnZPpEOON21XmhMp+u0sisjWLyBSPad9QxaLPGHW7nSgAhPQ1LjU8UOwI1vfor 45ifcbnWH1NYoLzcAuTvGv4NZkjNtXLa5B6BV17UibKiSQyTh8i/wDL3p27vY8Fzo7LU 2DEQiC1nO0B/mkA/afSZBymtADJ2geddDbPz+lpTZHxbRYPlKJt/uJyqkdm0ZOS0AgRE dqIS/yf3dlUwkL0lvfcDs237LoV3SHlzAVxCBlRku/R4G1vjxTgUuTCzfA7xkw1lOL54 7mdiOer0rm7E2e6f1jzUu1hGB8TrtXdhr+55sG74Fhwm+KDUGQGjkteDF4AXRAFFw/fg sv2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691510404; x=1692115204; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RE7wtMExHdhFwKLLqjqt4LfjR7+37ThDsOcCDy3qTQQ=; b=M0OQcTxseKZN3uPns4trPwvJqYpf1XJC+PSeWgP+bqFi44c2zs8C0vd9t7H7VVybgI Jn7/XdFB/iegFSOchENCsHI3G7mbgwsiDsHuIHvorCA0/6XgsCmS6wcL6tbeSlStNrmv Hd81HAc9CJA3XDYKGTaoaDyW/xF2d7D+l2/9scvZWP7d1EoLH24PCe3GZM3rzXhkl1zz 5cDCbcAut2wilo1DFfWeFUsv2BSTgOqq24wvVu6DMuQaKBJLOdzjXS4t86UZ52i68aVc 0SVyZnc0nx2eIxaw0fikCnCqTwT7WVtFg1MdWBhyWK1XY9suZ85UFxAA4vf4nDA2qser /GUQ== X-Gm-Message-State: AOJu0YyTNM+h2/DQCRMZ4miqk6ZvyAEHcuaZLDEKRMTmWHa8SLs1ZzgF nsljQobcxNKvVLyE+QpJgd9VAw== X-Google-Smtp-Source: AGHT+IHbksfzqPLdhw5/yCLJTbCZEOgLAM2KQI/YGEb2WX3hUJsxDJkD4J/0HYLK1y1YsVgSMdIzhA== X-Received: by 2002:ac2:4850:0:b0:4fe:56d8:631d with SMTP id 16-20020ac24850000000b004fe56d8631dmr8327458lfy.25.1691510404500; Tue, 08 Aug 2023 09:00:04 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.113]) by smtp.gmail.com with ESMTPSA id j18-20020aa7c0d2000000b0052239012c65sm6837797edp.82.2023.08.08.09.00.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Aug 2023 09:00:03 -0700 (PDT) Message-ID: Date: Tue, 8 Aug 2023 18:00:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 3/3] i3c: ast2600: Add reset deassertion for global registers Content-Language: en-US To: Dylan Hung , jk@codeconstruct.com.au, alexandre.belloni@bootlin.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, joel@jms.id.au, andrew@aj.id.au, p.zabel@pengutronix.de, linux-i3c@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: BMC-SW@aspeedtech.com, kobedylan@gmail.com References: <20230808154241.749641-1-dylan_hung@aspeedtech.com> <20230808154241.749641-4-dylan_hung@aspeedtech.com> From: Krzysztof Kozlowski In-Reply-To: <20230808154241.749641-4-dylan_hung@aspeedtech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/08/2023 17:42, Dylan Hung wrote: > Add missing reset deassertion of the I3C global control registers. > > Signed-off-by: Dylan Hung > --- > drivers/i3c/master/ast2600-i3c-master.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/i3c/master/ast2600-i3c-master.c b/drivers/i3c/master/ast2600-i3c-master.c > index 09ed19d489e9..5d9d060134e0 100644 > --- a/drivers/i3c/master/ast2600-i3c-master.c > +++ b/drivers/i3c/master/ast2600-i3c-master.c > @@ -11,6 +11,7 @@ > #include > #include > #include > +#include > > #include "dw-i3c-master.h" > > @@ -128,6 +129,7 @@ static int ast2600_i3c_probe(struct platform_device *pdev) > struct device_node *np = pdev->dev.of_node; > struct of_phandle_args gspec; > struct ast2600_i3c *i3c; > + struct reset_control *rst; > int rc; > > i3c = devm_kzalloc(&pdev->dev, sizeof(*i3c), GFP_KERNEL); > @@ -156,6 +158,13 @@ static int ast2600_i3c_probe(struct platform_device *pdev) > dev_err(&pdev->dev, "invalid sda-pullup value %d\n", > i3c->sda_pullup); > > + rst = devm_reset_control_get_shared(&pdev->dev, "global_rst"); > + if (IS_ERR(rst)) { > + dev_err(&pdev->dev, "missing of invalid reset entry"); > + return PTR_ERR(rst); return dev_err_probe Best regards, Krzysztof