From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A40C15AAD5 for ; Mon, 1 Jul 2024 13:17:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719839854; cv=none; b=oazXgqm+ldJz+wOmIfWc/HOa7/mVEp61NeH/oS5gLdXd6ybihAK642q9vNZ932wgBxteRJ6CbiVWE0V4OLygHB8DQkN9AUte7Wt9WVrpgUrD5grGlVEhPOMJ9bLmnzpMorhAGIW75FnDmLVtPApwXGSpqp6Nyfbl32vSqZ3lo+o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719839854; c=relaxed/simple; bh=B3NQ8HCyj1ZTe5E7TLaeqHT43qtQdDbfhF0WcJB5/l4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HL4bJXoHwND6caThTcWRY2U8O63XFKZXfLRzj+GCfSF+0dWYw19WKO/W98xgNK3rDOTc8NrpyTcE0a1ui1FPQN5SlxuF4k6ydx1G+HZJxREceEjn1L6pZ6hiQrprytPKN3/hhXhphMiDA176baDLxL71dI/Tl/e2uqh66S8V6uo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=UWKDH2AZ; arc=none smtp.client-ip=209.85.166.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="UWKDH2AZ" Received: by mail-io1-f44.google.com with SMTP id ca18e2360f4ac-7f3c5af0a04so156509039f.0 for ; Mon, 01 Jul 2024 06:17:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1719839852; x=1720444652; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Tv7hLmqJSP26fMN3IiNsBgVJSAix2nuXmhfSvybhYBQ=; b=UWKDH2AZl3qh51IaJ844eBRRwwGSLeuh5xk19tkKla8v4ZrIpy+m4k4BIjSl2eidlO 9dpgHw1aDoQTUYXzk2xHzA1WjfNAqwDxOhcVJvogiMigtxJPkvRvw3MOZKwPFJbwWEhT zIaq7NxLSNGncfzWmKb8S8pMnM6RrVAeGQxB8AfeuKf6+1Zfd4P8i8ltFBAmKy87qBOY 6LyYZJ9Nn4F9y+6OY61UcTXywKuFonw9UDJnhm50AJX7YciMtwUHU/o3g0ORLYyO0zw5 zCBRHbDi09OHjwyPvJCF4bQ8/vwj+anBMK6m8MEgw6AEArmlsU9G9jPYgGViBUqDUW14 Y8xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719839852; x=1720444652; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Tv7hLmqJSP26fMN3IiNsBgVJSAix2nuXmhfSvybhYBQ=; b=tnZIdFXEIu45yAIqih2DJbtgZWDJWocBgas2478I0pj5svY3vnvA0YJSkMZJuwoRBO CyJN1DUjhxPXFzaTwLGt06bv5SIdkbaNyAYHqbMBmpA3b/JRffSzhSsVQtbdTCE4hLUp wACLQxwZmvss6VNCJH7FoF+PnCXPIKOuoHbjZmtht3gQLMVjxXEvMjcclNTAjtC0cDtc zGonsd8hyt71DwpoILDsoUZhI5nT3RGE8JFSz88d9i6xFmLaxc4MtaREjYdtLEQU0UnP AnYYrwB3kIWa6WqFZ8ukcooqPMSCVjOgj+qH1jw9F9kYZd0GQgiSZ/62rjFCyg2i23RU JSMg== X-Forwarded-Encrypted: i=1; AJvYcCVOB11MbQ1Di4YmxmPiq+pFpfLhJvn7wdV4OrvD4HzBigaQsr4TwhZtZFz2CsLTso9l/8tYUZT+8lIXPVofhLU2MiYjfKvD09imNQ== X-Gm-Message-State: AOJu0Yzng8o9yLh/x9+WiLANX+aelfVWCfYwMA2QWJ1qEemsKpysvlP5 0G2icC0i+1AsSIVKbKVTxMjWQ8LNphad+8rkjb0HIqsnAWP9sGZALVjYLjRAyzY= X-Google-Smtp-Source: AGHT+IEZw7OPZRtqEEfxj8LpOcD4ss2+Aeo4eVMjfKvEB8LYKyAWd6+8RBlnjTcAOf4l/FP8eMO8Kg== X-Received: by 2002:a05:6602:584:b0:7eb:776f:d970 with SMTP id ca18e2360f4ac-7f62ee74896mr592724639f.14.1719839852334; Mon, 01 Jul 2024 06:17:32 -0700 (PDT) Received: from [100.64.0.1] ([147.124.94.167]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4bb73e08bc2sm2165340173.83.2024.07.01.06.17.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jul 2024 06:17:32 -0700 (PDT) Message-ID: Date: Mon, 1 Jul 2024 08:17:29 -0500 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] spi: dw-mmio: update dw_spi_mmio_of_match struct with thead To: Kanak Shilledar Cc: Serge Semin , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jisheng Zhang , Guo Ren , Fu Wei , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org References: <20240701121355.262259-2-kanakshilledar@gmail.com> <20240701121355.262259-4-kanakshilledar@gmail.com> From: Samuel Holland Content-Language: en-US In-Reply-To: <20240701121355.262259-4-kanakshilledar@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Kanak, On 2024-07-01 7:13 AM, Kanak Shilledar wrote: > updated the struct of_device_id dw_spi_mmio_of_match to include > the updated compatible value for TH1520 SoC ("thead,th1520-spi") > to initialize with dw_spi_pssi_init(). > > Signed-off-by: Kanak Shilledar > --- > Changes in v2: > - Separated from a single patch file. > --- > drivers/spi/spi-dw-mmio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/spi/spi-dw-mmio.c b/drivers/spi/spi-dw-mmio.c > index 819907e332c4..39e3d46ebf5d 100644 > --- a/drivers/spi/spi-dw-mmio.c > +++ b/drivers/spi/spi-dw-mmio.c > @@ -419,6 +419,7 @@ static const struct of_device_id dw_spi_mmio_of_match[] = { > { .compatible = "microchip,sparx5-spi", dw_spi_mscc_sparx5_init}, > { .compatible = "canaan,k210-spi", dw_spi_canaan_k210_init}, > { .compatible = "amd,pensando-elba-spi", .data = dw_spi_elba_init}, > + { .compatible = "thead,th1520-spi", .data = dw_spi_pssi_init}, Your binding requires snps,dw-apb-ssi as a fallback compatible string, which is already supported by this driver and uses the same match data. So you don't need this patch; its only effect is to make the kernel larger. Regards, Samuel > { /* end of table */} > }; > MODULE_DEVICE_TABLE(of, dw_spi_mmio_of_match);