From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15F7E222568 for ; Wed, 8 Oct 2025 12:19:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759925976; cv=none; b=uNRVPMBYq6zyKRYcN/yyCHVAHfELgIOeonlZ9jC4nn9Nu+J6R1fq0lHmpE4/xAhluef0aJLw8geuezkBehfv9Ci3ZGgWnjq9lhS9hZkkwNt3O0OBxf9472CML1EpLyOPPZkpGZ3/2NjQHt2TEO0vRo7mwXBM6gHLSj3Jxq+ZfOY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759925976; c=relaxed/simple; bh=3C9eaopUZAw455bC02kQuNPxhWzWB7+UMP3o6UT0ZJY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JcJv+7GOBL8jifOOVFc6BTvQA8MZnnn5hqzNllIPob3IquU4ialeVI1uACSk1L/VzEA8qBzsEkKzbr5/2hzNMPQtMuPvOfoSLi+ZQeeFunhFoq7hLsERgRAdHhKt3JUwVWPVTg74NRPflg93N9R0kVi1Qn+P1+eX3jVLAl4U5po= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jwoqL+id; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jwoqL+id" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59890MSu011494 for ; Wed, 8 Oct 2025 12:19:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yQdcxBOzfpxWOin6rPGZyHGNvUTr15XcQLcwaAQwN8w=; b=jwoqL+id+8d8xELi EvNKl9YWFoZ4hKQTVdyeXRtvEOtgzS8zZmnG11irduQEIQkxeLR2VIBgI3s04xEy 0dR/adni/1Y4VmnnWXiuA5NIvTMDfgI2TDBdaFK1KA+K12qtO210zAwcD/E2MB0y HXLlZRF5TFRPBJsxbSshabw8+UA8U/6ptkBw45jQpZVLDjF243GvXMuX8sD9La08 Vi427iRqQNs08tMqreb1jxZ+KLUdLgl5YrsRJ4JFDmgswVqvXSDMfreBp2oKQhxz dmwkdqs8ooi8KJoCgO+E4oxBMk8ZF6MRs727mJ9RczFX7GdzKAXxc/ygv+3g/Cd0 HJDLOA== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49mnkpw8qy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 08 Oct 2025 12:19:34 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-7958a07a5fdso22681986d6.2 for ; Wed, 08 Oct 2025 05:19:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759925973; x=1760530773; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yQdcxBOzfpxWOin6rPGZyHGNvUTr15XcQLcwaAQwN8w=; b=d9dzkyCasOtiUcCsx9N/rqw0P7ZQ45tmF5iw5stpko57gb23RqbvIcb6vXtWrwBuqg 0y2WffF0Tjzg6xp0EPMuVkThDn8xrNaDjDZQDe3+84XGdkh6vlsAeXxqLlpP69DmhyHV QCNMPWBTCN6DFYIrAGFM+7r+BaE0BY+Zdve+E90q8UwYoGnlsMbixzIMWJncDM0Mf9dP um8xgQjQIgy+8zLYWR3nvzO0RD0GRTUTXQ9PGG//nUBpy7ZxPP9ZpeBK25u12yxBRb9v wM/QXcwgmWDdInmdWoLYD97QXEgVy+yY0BwMxK31vU6zxo+RtWidyvuP7vsfUmH76uX1 Yd+g== X-Forwarded-Encrypted: i=1; AJvYcCWIatGDftM9awRnlUQm9q0sfOFrSVPzcsuyWrijN+wEOerSCj2hkhPcQ++2m4Ah2Wc039YsNLJIK7/Z@vger.kernel.org X-Gm-Message-State: AOJu0Yy1H0DROigwIumLvfA3DvV/f6ABeExi0eGMDi95iF+Fc1SNPy+c 0fT0NG28TUnVcdlIVV/zvRbHn4GF6MIgPggKfekp4J+0M1YZB75cQXb8h3Djp/cABjrPvzHOffQ 80/66tQtHGaq1nuUgV11/oGdbUR+5lw7ddcDZESEs1xv9AkCnQyIpdo5UJ9IdASHe X-Gm-Gg: ASbGnctd5tiESwocHMSBffbHEWdxvA7MEqZ4GLH1d3nldl734yX73XsSZFWTBJdHmZx q1m+aS6r+W37pW8aYuixxs4ahImhUbBIPjPvjlBfPaC0Taa72Y/jfnwoRR1xYbO7AGgOGWJRB6y EbuyxKgMzcfimAjkqX0R8IesFGz1SPa1k6tJl2mjASCEGCg8i9wLGfGEm+BZQJxMbe0+2u3aWyv 0xsnH9L8CCjsbZ6U7UXjau0JMq9T2nwx8tBkaDe7rYwvJd04y5seyafef8mTQu8MtAcFmt49MdG IF3OAJ018xjgnHZjn6YHJ0kkLO1QGcJNPPyJvmkYmcBJDiXTN27SaWzKWaN26ZrDlFmgiLxHYYY MwN84Tr7sypqSQo9Kbo7g7+8DoSk= X-Received: by 2002:a05:6214:130d:b0:763:83c3:5977 with SMTP id 6a1803df08f44-87b20fe428fmr27062746d6.2.1759925972891; Wed, 08 Oct 2025 05:19:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHf0NO3O0wMYDy3C1r+xPkcF6ocxQiQ/fYTpALHFypihvfSo0fa68pHt0T57r7qjYpxr+HZMQ== X-Received: by 2002:a05:6214:130d:b0:763:83c3:5977 with SMTP id 6a1803df08f44-87b20fe428fmr27062256d6.2.1759925972350; Wed, 08 Oct 2025 05:19:32 -0700 (PDT) Received: from [192.168.149.223] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-639cd144d13sm2953003a12.19.2025.10.08.05.19.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Oct 2025 05:19:31 -0700 (PDT) Message-ID: Date: Wed, 8 Oct 2025 14:19:29 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V1 3/3] arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 mtp and qrd board To: Sarthak Garg , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, quic_nguyenb@quicinc.com, quic_rampraka@quicinc.com, quic_pragalla@quicinc.com, quic_sayalil@quicinc.com, quic_nitirawa@quicinc.com, quic_bhaskarv@quicinc.com, kernel@oss.qualcomm.com References: <20251007054445.4096630-1-sarthak.garg@oss.qualcomm.com> <20251007054445.4096630-4-sarthak.garg@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251007054445.4096630-4-sarthak.garg@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 5iRsh18KOTeTUcjdKyIL5OcSF3QHXGI- X-Proofpoint-ORIG-GUID: 5iRsh18KOTeTUcjdKyIL5OcSF3QHXGI- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDA2MDE2OCBTYWx0ZWRfXzRJ7EkSJuU3a m6arCSOdPYwB/UaQiLZTTUi0pSAfGYJthMeOzuvjE3bUQEur3gfAynIrOpstiBVdKUDCh32QQXO xdkpCgw2hffPx+wIXUn9yvoRwi/YK37hWxRH4CO0i6Ask/Xo1S1ehFDX/7KweDR97+mxLxOrFTH iZtAeZqM/C0ZgQjcOd7C+SHZgKurUYtKBIDcZU2/mdCi+sUW9ZhaetuCCjvyjVLwyVIHbMZon/9 trJ4Am6iUSulGUFVbyBoIPiZM2LMk3zWkSp/j0rcZhuK9tmuGpEjTgoCLhDmbW0ZRFAgOPMbOcn ihn7uXkxoLvhC0+vbXFD/L/HAiETuSe7eKQF3Qje3KNWUsdXMx+ILpG/rKcYKwZQh7imz049pcF lemvjsA5JbTPvBVBD/zyzcuq1lPl1Q== X-Authority-Analysis: v=2.4 cv=BuCQAIX5 c=1 sm=1 tr=0 ts=68e656d6 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=EUspDBNiAAAA:8 a=4QMeK_r5uR8x9m7PPSIA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-08_04,2025-10-06_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 adultscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2510060168 On 10/7/25 7:44 AM, Sarthak Garg wrote: > Enable SD Card host controller for sm8750 mtp and qrd board. > > Signed-off-by: Sarthak Garg > --- > arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 15 +++++++++++++++ > arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 16 ++++++++++++++++ Normally this should be one commit per board, with e.g. "sm8750-mtp:" in the title > 2 files changed, 31 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts > index 3bbb53b7c71f..26548191d95d 100644 > --- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts > +++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts > @@ -1030,6 +1030,21 @@ &remoteproc_mpss { > status = "fail"; > }; > > +&sdhc_2 { > + cd-gpios = <&tlmm 55 GPIO_ACTIVE_LOW>; > + vmmc-supply = <&vreg_l9b_2p9>; > + vqmmc-supply = <&vreg_l8b_1p8>; Any reason you didn't place a \n here.. > + > + no-sdio; > + no-mmc; > + > + pinctrl-0 = <&sdc2_default>; > + pinctrl-1 = <&sdc2_sleep>; > + pinctrl-names = "default", "sleep"; > + > + status = "okay"; > +}; > + > &swr0 { > status = "okay"; > > diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts > index 13c7b9664c89..8d018eef44da 100644 > --- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts > +++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts > @@ -916,6 +916,22 @@ &remoteproc_mpss { > status = "okay"; > }; > > +&sdhc_2 { > + cd-gpios = <&tlmm 55 GPIO_ACTIVE_LOW>; > + > + vmmc-supply = <&vreg_l9b_2p9>; > + vqmmc-supply = <&vreg_l8b_1p8>; ..but added one here? FWIW I like the 2nd one more Konrad