From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67C4FC4332F for ; Thu, 20 Oct 2022 22:45:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230146AbiJTWpP (ORCPT ); Thu, 20 Oct 2022 18:45:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229779AbiJTWou (ORCPT ); Thu, 20 Oct 2022 18:44:50 -0400 Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48FC74F690 for ; Thu, 20 Oct 2022 15:44:49 -0700 (PDT) Received: by mail-qk1-x72a.google.com with SMTP id m6so958070qkm.4 for ; Thu, 20 Oct 2022 15:44:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FPT7tBybriHsBPmnhq33KI/WJRugk0kzMNukS0fuXHg=; b=uWOLgWr2PeyCt4D7XtXlrGfikGUHkSh3nw2aJht3Fm8d+PilSBG3qKuSXLSU5rOA9/ FxDjZk9hSapHSiE1Wd40jsgqd+Ynp5uvDaTbcgn8E5xQ4xBGLyacL+So1pyYrvZal4gn ijYOVaz+FefBJoHzVwlkHmnxQhSRyywRsyeeRVnfkSfEE/Kvn5C2GUHNhMKuex4xxPiY qyMT+m/A/aURsO1P70gSk+pDraRffQ051g2vhB/pNfJOBtazwOJQIoh4Qz3X78jVmK59 SRdLfq9I8mDSIAazXCo/Gd0t/PU1Yy5w5nmjnX3DCOHFqBQHDFvWnHVBH3lhxYrZTT4Z 1pQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FPT7tBybriHsBPmnhq33KI/WJRugk0kzMNukS0fuXHg=; b=oVlpG5fSy9RYZgxqkJ+qsIvk75Wuv8et/+5NbwGjXH6z9Aj0rzTJdiMBumQvU/wwn6 F2/2F9jAm3GFfvZo2gBMVn1L9Be6K3//42YkBi7jzR+Qovsm36Jv+ZeS13Fpyfx4Lmfa iPlQOIaO+C182/dQoo4MKu6meQ6kh+0QxFMSmZI+Fo0lftYkgXbUO/kDxq3gJ5h30gUE 7wbnN0WSko7y0+ABa5QaR2PeIz3EWKWFnbPxcGmvX6pH5/7pTRRaRSyMSwSxbqHFJPHH DFjkFguSmfFNruMHRZkN8ALQDh7oeFLTXYGkTfmAE89Hbk9ThWYE8msTvJm36KPFjJM/ p4Qg== X-Gm-Message-State: ACrzQf3GdQWavmEHiQr0ddRS9Dnh+aY4OhAc85h0gAz9hlC3lMVqud2w PSnvWRUc5PTu86afmRAToXz/Wg== X-Google-Smtp-Source: AMsMyM7amq+IROYBz05TXTIlsKX/VhkjUV8sy7t8Ci0hzqT/ojdNJYJCpiCQ2T4CYVQDZzFb7ldt3g== X-Received: by 2002:a05:620a:440d:b0:6ee:b5eb:a0c6 with SMTP id v13-20020a05620a440d00b006eeb5eba0c6mr11478881qkp.356.1666305888366; Thu, 20 Oct 2022 15:44:48 -0700 (PDT) Received: from [192.168.10.124] (pool-72-83-177-149.washdc.east.verizon.net. [72.83.177.149]) by smtp.gmail.com with ESMTPSA id f24-20020ac84658000000b0039cbb50951asm6775416qto.24.2022.10.20.15.44.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Oct 2022 15:44:47 -0700 (PDT) Message-ID: Date: Thu, 20 Oct 2022 18:44:45 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v3 2/4] arm64: dts: qcom: sc7180: revert "arm64: dts: qcom: sc7180: Avoid glitching SPI CS at bootup on trogdor" Content-Language: en-US To: Doug Anderson Cc: Bjorn Andersson , Andy Gross , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Matthias Kaehlcke , Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221019001351.1630089-1-krzysztof.kozlowski@linaro.org> <20221019001351.1630089-3-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/10/2022 11:48, Doug Anderson wrote: > Hi, > > On Tue, Oct 18, 2022 at 5:14 PM Krzysztof Kozlowski > wrote: >> >> This reverts commit e440e30e26dd6b0424002ad0ddcbbcea783efd85 because it >> is not a reliable way of fixing SPI CS glitch and it depends on specific >> Linux kernel pin controller driver behavior. >> >> This behavior of kernel driver was changed in commit b991f8c3622c >> ("pinctrl: core: Handling pinmux and pinconf separately") thus >> effectively the DTS fix stopped being effective. >> >> Proper solution for the glitching SPI chip select must be implemented in >> the drivers, not via ordering of entries in DTS. >> >> Signed-off-by: Krzysztof Kozlowski >> >> --- >> >> Changes since v2: >> 1. New patch >> >> Not tested on hardware. >> >> Cc: Doug Anderson >> --- >> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 27 +++----------------- >> 1 file changed, 3 insertions(+), 24 deletions(-) > > It would have been nice for the commit message to mention the fix in > the driver, which has already landed as commit d21f4b7ffc22 ("pinctrl: > qcom: Avoid glitching lines when we first mux to output"). I'll add it. > > In any case: > > Reviewed-by: Douglas Anderson > > I've confirmed that this patch is fine after taking the pinctrl fix. > > Tested-by: Douglas Anderson Awesome! Best regards, Krzysztof