From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jack Zhu <jack.zhu@starfivetech.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Maxime Ripard <mripard@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Eugen Hristev <eugen.hristev@collabora.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, changhuang.liang@starfivetech.com
Subject: Re: [PATCH v4 6/8] media: dt-bindings: Add bindings for JH7110 Camera Subsystem
Date: Sat, 15 Apr 2023 10:59:05 +0200 [thread overview]
Message-ID: <f8681075-30c8-5cda-6e1c-ddb80c052e50@linaro.org> (raw)
In-Reply-To: <20230413035541.62129-7-jack.zhu@starfivetech.com>
On 13/04/2023 05:55, Jack Zhu wrote:
> Add the bindings documentation for Starfive JH7110 Camera Subsystem
> which is used for handing image sensor data.
>
> Signed-off-by: Jack Zhu <jack.zhu@starfivetech.com>
Subject: drop second/last, redundant "bindings for". The "dt-bindings"
prefix is already stating that these are bindings.
> ---
> .../bindings/media/starfive,jh7110-camss.yaml | 164 ++++++++++++++++++
> MAINTAINERS | 7 +
> 2 files changed, 171 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
> new file mode 100644
> index 000000000000..4cd144f1b845
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
> @@ -0,0 +1,164 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +
No need for blank line.
With two fixes above:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-04-15 8:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 3:55 [PATCH v4 0/8] Add StarFive Camera Subsystem driver Jack Zhu
2023-04-13 3:55 ` [PATCH v4 1/8] media: dt-bindings: cadence-csi2rx: Convert to DT schema Jack Zhu
2023-04-15 8:56 ` Krzysztof Kozlowski
2023-04-19 6:08 ` Laurent Pinchart
2023-04-13 3:55 ` [PATCH v4 2/8] media: dt-bindings: cadence-csi2rx: Add resets property Jack Zhu
2023-04-13 3:55 ` [PATCH v4 3/8] media: cadence: Add operation on reset Jack Zhu
2023-04-13 3:55 ` [PATCH v4 4/8] media: cadence: Add support for external dphy Jack Zhu
2023-04-13 3:55 ` [PATCH v4 5/8] media: cadence: Add support for JH7110 SoC Jack Zhu
2023-04-13 3:55 ` [PATCH v4 6/8] media: dt-bindings: Add bindings for JH7110 Camera Subsystem Jack Zhu
2023-04-15 8:59 ` Krzysztof Kozlowski [this message]
2023-04-17 9:21 ` Jack Zhu
2023-04-19 6:15 ` Laurent Pinchart
2023-04-20 8:51 ` Jack Zhu
2023-04-24 12:02 ` Laurent Pinchart
2023-04-25 6:34 ` Jack Zhu
2023-04-13 3:55 ` [PATCH v4 7/8] media: admin-guide: Add starfive_camss.rst for Starfive " Jack Zhu
2023-04-13 3:55 ` [PATCH v4 8/8] media: starfive: Add Starfive Camera Subsystem driver Jack Zhu
2023-04-24 11:19 ` [PATCH v4 0/8] Add StarFive " Jack Zhu
2023-05-05 5:57 ` Jack Zhu
2023-05-05 6:40 ` Krzysztof Kozlowski
2023-05-05 8:14 ` Jack Zhu
2023-05-05 12:24 ` Krzysztof Kozlowski
2023-05-06 2:25 ` Jack Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8681075-30c8-5cda-6e1c-ddb80c052e50@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=changhuang.liang@starfivetech.com \
--cc=devicetree@vger.kernel.org \
--cc=eugen.hristev@collabora.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jack.zhu@starfivetech.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rfoss@kernel.org \
--cc=robh+dt@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).