From: Javier Martinez Canillas <javierm@redhat.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-kernel@vger.kernel.org
Cc: "Ondrej Jirman" <megi@xff.cz>,
"Robert Mader" <robert.mader@posteo.de>,
"Peter Robinson" <pbrobinson@gmail.com>,
"Kamil Trzciński" <ayufan@ayufan.eu>,
"Martijn Braam" <martijn@brixit.nl>,
"Caleb Connolly" <kc@postmarketos.org>,
"Heiko Stuebner" <heiko@sntech.de>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Tom Fitzhenry" <tom@tom-fitzhenry.me.uk>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 4/4] arm64: dts: rk3399-pinephone-pro: Add internal display support
Date: Fri, 23 Dec 2022 09:44:55 +0100 [thread overview]
Message-ID: <f86d661c-7ecd-4950-53c4-6a342d2fe963@redhat.com> (raw)
In-Reply-To: <a73d99fb-0d47-ad93-27e2-9b51dba4b824@linaro.org>
On 12/23/22 09:13, Krzysztof Kozlowski wrote:
> On 22/12/2022 23:38, Javier Martinez Canillas wrote:
[...]
>> +
>> + /* MIPI DSI panel 1.8v supply */
>> + vcc1v8_lcd: vcc1v8-lcd {
>
> Node names should be generic, so regulator suffix or prefix (looks like
> other nodes already use suffix)
>
Indeed, Maya already pointed this out. I missed this when forward porting
this patch from the pine64 downstream tree.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
prev parent reply other threads:[~2022-12-23 8:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 22:38 [PATCH 0/4] Add PinePhone Pro display support Javier Martinez Canillas
2022-12-22 22:38 ` [PATCH 2/4] dt-bindings: display: Add Himax HX8394 panel controller bindings Javier Martinez Canillas
2022-12-23 8:12 ` Krzysztof Kozlowski
2022-12-23 8:43 ` Javier Martinez Canillas
2022-12-22 22:38 ` [PATCH 4/4] arm64: dts: rk3399-pinephone-pro: Add internal display support Javier Martinez Canillas
2022-12-22 22:57 ` Maya Matuszczyk
2022-12-23 8:38 ` Javier Martinez Canillas
2022-12-26 13:05 ` Javier Martinez Canillas
2022-12-23 8:13 ` Krzysztof Kozlowski
2022-12-23 8:44 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f86d661c-7ecd-4950-53c4-6a342d2fe963@redhat.com \
--to=javierm@redhat.com \
--cc=ayufan@ayufan.eu \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kc@postmarketos.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=martijn@brixit.nl \
--cc=megi@xff.cz \
--cc=pbrobinson@gmail.com \
--cc=robert.mader@posteo.de \
--cc=robh+dt@kernel.org \
--cc=tom@tom-fitzhenry.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).