From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF882C4332F for ; Fri, 23 Dec 2022 08:45:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236135AbiLWIpr (ORCPT ); Fri, 23 Dec 2022 03:45:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230050AbiLWIpq (ORCPT ); Fri, 23 Dec 2022 03:45:46 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 956FF357BB for ; Fri, 23 Dec 2022 00:45:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671785099; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=saMXhQ6FaRFb79mAY11mIOCOiw3Mj/T5tk9AKBUTHeM=; b=X+1+Q9UQIRazUif3ENhNP/iRtLcjOi+ur838di2FLdoYDrpWiqP/vhAQHr+DXWfrmF6adq hRVBsbVD9Zd1SKmwMUhj/HouzONkvdDs8dTpWTz3pfTQl76+8Y+sFNo5refamMKvlHC6F9 9dhsSgPUWSrHDg978Sg6q2G1I0TKogw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-414-Xiyi7_BuOJaq-HEfMZ4aWg-1; Fri, 23 Dec 2022 03:44:58 -0500 X-MC-Unique: Xiyi7_BuOJaq-HEfMZ4aWg-1 Received: by mail-wm1-f71.google.com with SMTP id q21-20020a7bce95000000b003d236c91639so957340wmj.8 for ; Fri, 23 Dec 2022 00:44:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=saMXhQ6FaRFb79mAY11mIOCOiw3Mj/T5tk9AKBUTHeM=; b=HnCkZAenIuUF22idY+aZ18q3ARd+FYKgDOuGNSywfJx5N4XfJbZLfTO43kExtNQ6aG k2K1YptUYnRerhOQOqQ2yrASvAcB7SdvDii4bhzww0vhzDHngkGxUixczUnq6kPxlmEM i3ANjUrtn+WDuss/hgUei+PD1SpxsEJo+c95nXcwAu/uMLOI3v+w+oRH32zTOP3noA0k wcOALzr6kq8XNoHibDb8q2FtgxESz54l0d9sdzcLCn1xPwMzs7Q/pdWS2i8guSAXzaEL LWpSQOasx9jYgNtq0tJyZ/ryjdaw5WHFv9pLl46yaG/kTLF3qX8KKug2U7LRDhmaUMBG kz5w== X-Gm-Message-State: AFqh2kplazda6viKWw1YPNca8C5AY408qAc46X3naN2QlE5muOYtkLpH Wa1g1HHLIZMKchl7BTeyg+4pXC0Amhf2wJQJYVs1rheW97j3soIBpVllKGhroojrm6xnnVNpZZI ufLJUuAgrE/3z5Sg5wFuPkw== X-Received: by 2002:a05:600c:4e04:b0:3d2:381f:2db5 with SMTP id b4-20020a05600c4e0400b003d2381f2db5mr6216499wmq.22.1671785097114; Fri, 23 Dec 2022 00:44:57 -0800 (PST) X-Google-Smtp-Source: AMrXdXt1Fkupw8Va8m6hEvjj4yEMTWjnMAE5PPtO0pCOALsERpBky1niqrg1HyQfg57dwjlb1upXpg== X-Received: by 2002:a05:600c:4e04:b0:3d2:381f:2db5 with SMTP id b4-20020a05600c4e0400b003d2381f2db5mr6216489wmq.22.1671785096950; Fri, 23 Dec 2022 00:44:56 -0800 (PST) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id o7-20020a05600c4fc700b003cf4ec90938sm4316705wmq.21.2022.12.23.00.44.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Dec 2022 00:44:56 -0800 (PST) Message-ID: Date: Fri, 23 Dec 2022 09:44:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 4/4] arm64: dts: rk3399-pinephone-pro: Add internal display support Content-Language: en-US To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Cc: Ondrej Jirman , Robert Mader , Peter Robinson , =?UTF-8?Q?Kamil_Trzci=c5=84ski?= , Martijn Braam , Caleb Connolly , Heiko Stuebner , Krzysztof Kozlowski , Rob Herring , Tom Fitzhenry , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org References: <20221222223830.2494900-1-javierm@redhat.com> <20221222223830.2494900-5-javierm@redhat.com> From: Javier Martinez Canillas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/23/22 09:13, Krzysztof Kozlowski wrote: > On 22/12/2022 23:38, Javier Martinez Canillas wrote: [...] >> + >> + /* MIPI DSI panel 1.8v supply */ >> + vcc1v8_lcd: vcc1v8-lcd { > > Node names should be generic, so regulator suffix or prefix (looks like > other nodes already use suffix) > Indeed, Maya already pointed this out. I missed this when forward porting this patch from the pine64 downstream tree. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat