From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0E22C05027 for ; Fri, 10 Feb 2023 11:23:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232194AbjBJLXW (ORCPT ); Fri, 10 Feb 2023 06:23:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231518AbjBJLXV (ORCPT ); Fri, 10 Feb 2023 06:23:21 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 287C56C7E8 for ; Fri, 10 Feb 2023 03:23:20 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id r18so3568599wmq.5 for ; Fri, 10 Feb 2023 03:23:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xI9gYztVh8CUauySkPThsaIJ2I1/Wnh8PrWXbxjNzZ0=; b=NRHJCgKQ2tlzZWl8sU4Ssukk4rUijhHHujOK7KFzcVRGnkKk/4V/UhLudq5HHKstUS 219eo6DzkvmGzmoQuv4mjeip6BcEcBe8Y97VSeJ+/OHpofacv4dXl6scozKw3Xag6IXG sKF4y1hbrbQlG2V+P9uVn0Q2DWddNC94dwi70kmO6LGp87Fvysh/RWzZQMFe1TD+203C 0jHwbB4fgeMueG/VLFiur5ERomy/zCIUoHQbjcMVfcBD4ljzcO5yXE8MMl7Eo7NyuPRQ jFUwF2GlprRII38nIlnalovb4+dKRzBQaOOoh8mbbipqcpkghTb87HG+jPq6E16dZQWQ EXLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xI9gYztVh8CUauySkPThsaIJ2I1/Wnh8PrWXbxjNzZ0=; b=wT9Bis+AOKwvq5zbriZk+wyHvTY0VCgnxwP88vc6+rtv65cifCk03jgvHfCBHnhjyM SYXFdVEYIx4pPdEsmf9FTYljow1nkau1xa13RWbhi88+o3Ksg5z7c1kmsy/YkQSoVKtF DG416BR0NIculRwUj2PcwHs9eVxSFvLh1e6DzYsoRf6kSMc/QLkKtPRPWyCrRVofNkjP h2sDRubhsBvMapLQ1Rfw0dUK5prl1ym6OhUbDc6lEBc5je3Q+zAILtCUpYIXc3sxFzoD qFitLQ/14TR/hG4ZHX3IYa75xl1ziI03wxDK1GDjiID590Wtv1ah5V8C3kSMBVOmF4Hx v1oQ== X-Gm-Message-State: AO0yUKWahIc9Lqt8OVoL8oMljEtWrrEOKXzsJsWGEeR+6CY4o5zFF8zD 559e27XVhcinVHpwYKNh1QrfkdrjecH44F0j X-Google-Smtp-Source: AK7set+legodxv6KBlkbkD44DJSD+6EChFSzBsO0IZtYTmpH0QN9n6LRbkTpKJ8iSAhd7hSblH2b8A== X-Received: by 2002:a05:600c:4393:b0:3de:1d31:1043 with SMTP id e19-20020a05600c439300b003de1d311043mr12023706wmn.21.1676028198740; Fri, 10 Feb 2023 03:23:18 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id o5-20020a1c7505000000b003dc48a2f997sm7816142wmc.17.2023.02.10.03.23.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Feb 2023 03:23:18 -0800 (PST) Message-ID: Date: Fri, 10 Feb 2023 12:23:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v5 8/8] dt-bindings: remoteproc: qcom: sc7280-adsp-pil: Add missing properties Content-Language: en-US To: Srinivasa Rao Mandadapu , krzysztof.kozlowski+dt@linaro.org, vkoul@kernel.org, agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org, broonie@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_rohkumar@quicinc.com, srinivas.kandagatla@linaro.org, dianders@chromium.org, swboyd@chromium.org, judyhsiao@chromium.org, alsa-devel@alsa-project.org, quic_rjendra@quicinc.com, konrad.dybcio@somainline.org, mka@chromium.org, quic_mohs@quicinc.com References: <1675700201-12890-1-git-send-email-quic_srivasam@quicinc.com> <1675700201-12890-9-git-send-email-quic_srivasam@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <1675700201-12890-9-git-send-email-quic_srivasam@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 06/02/2023 17:16, Srinivasa Rao Mandadapu wrote: > Add reg-names and power-domain-names for remoteproc ADSP pheripheral typo: peripheral > loader. Add firmware-name property to distinguish and load different > firmware binaries of various vendors. > Change qcom,halt-regs property phandle to tcsr_1 from tcsr_mutex. > Also add required-opps property and change power domain from LCX to CX, > which is actual PD to be controlled, for setting appropriate > performance state. > This is to make compatible with remoteproc ADSP PIL driver and > latest device tree changes. > > Fixes: 8490a99586ab ("dt-bindings: remoteproc: qcom: Add SC7280 ADSP support") > Signed-off-by: Srinivasa Rao Mandadapu > Reviewed-by: Krzysztof Kozlowski > --- > .../bindings/remoteproc/qcom,sc7280-adsp-pil.yaml | 30 +++++++++++++++++++--- > 1 file changed, 26 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml > index 94ca7a0..7addc7d 100644 > --- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml > @@ -23,6 +23,11 @@ properties: > - description: qdsp6ss register > - description: efuse q6ss register > > + reg-names: > + items: > + - const: qdsp6ss_base > + - const: lpass_efuse So your commit adding the bindings: https://lore.kernel.org/all/1664368073-13659-2-git-send-email-quic_srivasam@quicinc.com/ was already incomplete because the same patchset added undocumented properties. I have no clue what is happening with AudioReach sound/ADSP code - it's like random set of changes here and there, without coordination. Drivers come without bindings, DTS comes before bindings... Is your DTS in this patches matching this binding? If so, usage cannot be before the binding is introduced. Best regards, Krzysztof