From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Luca Weiss <luca@z3ntu.xyz>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Loic Poulain <loic.poulain@linaro.org>,
Kalle Valo <kvalo@kernel.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Stephan Gerhold <stephan.gerhold@kernkonzept.com>
Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/4] remoteproc: qcom_wcnss: Add WCN3680B compatible
Date: Tue, 17 Oct 2023 18:28:16 +0200 [thread overview]
Message-ID: <f87ee117-ad72-40b8-9246-ddbd7dbe9383@linaro.org> (raw)
In-Reply-To: <f342446c-7afb-414c-a4d5-1eff03fe397e@linaro.org>
On 10/16/23 07:35, Krzysztof Kozlowski wrote:
> On 15/10/2023 22:03, Luca Weiss wrote:
>> Add a compatible for the WCN3680B chip used with some Qualcomm SoCs.
>>
>> It shares the same regulator setup as WCN3680, so we can reuse the
>> driver data for that.
>>
>> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
>> ---
>> drivers/remoteproc/qcom_wcnss_iris.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/remoteproc/qcom_wcnss_iris.c b/drivers/remoteproc/qcom_wcnss_iris.c
>> index dd36fd077911..22acc609105f 100644
>> --- a/drivers/remoteproc/qcom_wcnss_iris.c
>> +++ b/drivers/remoteproc/qcom_wcnss_iris.c
>> @@ -99,6 +99,7 @@ static const struct of_device_id iris_of_match[] = {
>> { .compatible = "qcom,wcn3660", .data = &wcn3660_data },
>> { .compatible = "qcom,wcn3660b", .data = &wcn3680_data },
>> { .compatible = "qcom,wcn3680", .data = &wcn3680_data },
>> + { .compatible = "qcom,wcn3680b", .data = &wcn3680_data },
>
> Just make devices compatible and no need for this driver change.
Or reconsider given <ZS1MTAHq6GLW6RAK@gerhold.net>
Konrad
next prev parent reply other threads:[~2023-10-17 16:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-15 20:03 [PATCH 0/4] Add WCN3680B WiFi/Bluetooth and enable it on Fairphone 3 Luca Weiss
2023-10-15 20:03 ` [PATCH 1/4] dt-bindings: remoteproc: qcom: wcnss: Add WCN3680B compatible Luca Weiss
2023-10-16 5:35 ` Krzysztof Kozlowski
2023-10-16 13:16 ` Loic Poulain
2023-10-16 14:44 ` Stephan Gerhold
2023-11-25 12:25 ` Luca Weiss
2023-11-27 20:07 ` Stephan Gerhold
2023-11-27 20:27 ` Luca Weiss
2023-10-15 20:03 ` [PATCH 2/4] remoteproc: qcom_wcnss: " Luca Weiss
2023-10-16 5:35 ` Krzysztof Kozlowski
2023-10-17 16:28 ` Konrad Dybcio [this message]
2023-10-15 20:03 ` [PATCH 3/4] wifi: wcn36xx: Add check for WCN3680B Luca Weiss
2023-10-16 5:36 ` Krzysztof Kozlowski
2023-10-15 20:03 ` [PATCH 4/4] arm64: dts: qcom: sdm632-fairphone-fp3: Enable WiFi/Bluetooth Luca Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f87ee117-ad72-40b8-9246-ddbd7dbe9383@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kvalo@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=luca@z3ntu.xyz \
--cc=mathieu.poirier@linaro.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stephan.gerhold@kernkonzept.com \
--cc=wcn36xx@lists.infradead.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).