From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B4CDEBE for ; Tue, 17 Oct 2023 16:28:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NyBUxD/x" Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00423F2 for ; Tue, 17 Oct 2023 09:28:22 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-31fa15f4cc6so5194855f8f.2 for ; Tue, 17 Oct 2023 09:28:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697560101; x=1698164901; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HQvXsaetNqAcFhMUG/2hK+pMDdXGtzxBnDJfKLjQOWI=; b=NyBUxD/xEt8gzDTui6ihLOfdNJAnCdXVmxbYOwqf6MKSs3f1jpB0/pXLU2owluQ49e kCcu8eiOUavtQR8/b4be5rU+EIWB4BX9vCsLChxec+wRefaURPk48sAGNILZptXQ1de/ REj0BKBM6xHoL/39klHGWzy+vTR5oZIDGNa3dGO0hdaMr8l8iOZ8n3v19InSm+cZEKJo 3KgIuQ/w+mD4afwIxSEXvAEdPSDwKf94oYAlPquc9Habr2gXtTkzphBvCAlcBSuaUNUa uj7Jlfodzrny8HgVPIOhWAINLBvRlQcGWKzoPw03yn6hx6r5a90tn4YfX+5fQqloqAd8 kS6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697560101; x=1698164901; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HQvXsaetNqAcFhMUG/2hK+pMDdXGtzxBnDJfKLjQOWI=; b=Zz+yhl9lt4oZAHrLG3CnO12LKqrpb5XgSJNMS20nuylNBCDYqT6hxYMJhhtJDUoTDE x10JFUxkQsw9o3aUTFTZhPeTlVrnpM/JyHoQNRkBONbMUri/0tm4uBiR2TidbUHHEIJ1 N4ksmzW995C0rXzMygqaVVuvhz1fnO9Iq0NjhbUzLz/6m/MlbdKdJ5CDNX7gY05aom4j VNo5n9clA8HooLFbvw1KWmMZwyWtNkLGyb5VpJgmzjDGL3WUjSknHcADGicxKvrWbni0 KDCDvyS+vrriWngiQIBQXjavPbKTv8wPHTTDxsWtrw/kdF1rRH17rf88oCHuUzd6RmXB kSNg== X-Gm-Message-State: AOJu0YwJtfCn5lD422tHxT6WqYE9X9lgrh2SSlNV2jxE1KdMcFzHVTDc JQw4kgmqlMsxF0Jg9pf90U0o/A== X-Google-Smtp-Source: AGHT+IHQcHoYySq8QpN4wpHWzqsBjw0L1AxQwuXVricWOgMzTjZ743oMCFukODi/CgNHu7nEXgxtpw== X-Received: by 2002:a5d:62d1:0:b0:32d:90f7:ce4f with SMTP id o17-20020a5d62d1000000b0032d90f7ce4fmr2133052wrv.38.1697560101213; Tue, 17 Oct 2023 09:28:21 -0700 (PDT) Received: from [172.30.204.57] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id d15-20020a05600c34cf00b004063d8b43e7sm10257184wmq.48.2023.10.17.09.28.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Oct 2023 09:28:20 -0700 (PDT) Message-ID: Date: Tue, 17 Oct 2023 18:28:16 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] remoteproc: qcom_wcnss: Add WCN3680B compatible Content-Language: en-US To: Krzysztof Kozlowski , Luca Weiss , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Andy Gross , Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Loic Poulain , Kalle Valo , Bryan O'Donoghue , Stephan Gerhold Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org References: <20231015-fp3-wcnss-v1-0-1b311335e931@z3ntu.xyz> <20231015-fp3-wcnss-v1-2-1b311335e931@z3ntu.xyz> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 10/16/23 07:35, Krzysztof Kozlowski wrote: > On 15/10/2023 22:03, Luca Weiss wrote: >> Add a compatible for the WCN3680B chip used with some Qualcomm SoCs. >> >> It shares the same regulator setup as WCN3680, so we can reuse the >> driver data for that. >> >> Signed-off-by: Luca Weiss >> --- >> drivers/remoteproc/qcom_wcnss_iris.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/remoteproc/qcom_wcnss_iris.c b/drivers/remoteproc/qcom_wcnss_iris.c >> index dd36fd077911..22acc609105f 100644 >> --- a/drivers/remoteproc/qcom_wcnss_iris.c >> +++ b/drivers/remoteproc/qcom_wcnss_iris.c >> @@ -99,6 +99,7 @@ static const struct of_device_id iris_of_match[] = { >> { .compatible = "qcom,wcn3660", .data = &wcn3660_data }, >> { .compatible = "qcom,wcn3660b", .data = &wcn3680_data }, >> { .compatible = "qcom,wcn3680", .data = &wcn3680_data }, >> + { .compatible = "qcom,wcn3680b", .data = &wcn3680_data }, > > Just make devices compatible and no need for this driver change. Or reconsider given Konrad