From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FD3B192B9D for ; Thu, 2 Jan 2025 09:40:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735810841; cv=none; b=CCl9mJWapMT2Xq13+4xAIF71PMA/Q9LUp4LtfNalXz+QwwauwwbBS8nP5j0uu0eFg/PcI4pfQy+mTC6H07iegIqgkE97PNDEVAXpwbPYdAjTuDk2eNPXcfbpKckGtFwju1VOo4kRRdtVhKdrXKUSnnzWSYUsOQdfRMWCzTGBb+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735810841; c=relaxed/simple; bh=c62rokAxa7lt3ak5B6yxvE6j4P7LwpjOFp0oIonMUxE=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=glpAXd1TjtFbgsRyx64YJjjAYlp/lYLSyt0Kr2N+IfBkqRHDVftpjs1nPEplzanZtYdioz2Et1UiSbDXtyAAWGOQFNEBn2nEg7x17qls7Tlmeczbl1M0/boijs+tZ3WBXHTHFhRbqrlkx8ryAcBbr9aW8wShDJE/cWWsSApJ3oo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gLUjKYXF; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gLUjKYXF" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-385df53e559so8772419f8f.3 for ; Thu, 02 Jan 2025 01:40:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1735810838; x=1736415638; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=vBrc7EuOMXY8yTx/TbXVRV+IK2Cs6RWnPvid7BqXfWc=; b=gLUjKYXF9YCoWRHR4iC91wBlO4HP5ZpCOB4PH6B/KFWuzT2o5nK18YZ79DKlrrfYtA EKGaQMVmi/siGZoNBqFkcCtptxSwkhMLPh3Iiy9mk/+L+vmI56uMNqVoar60du0JzxB7 1LMmZ0jc60ED4cmUDZkYogljmwqv66sCJumicBoCYCDTNJIlGEQKJBhBqA3cW+LV29az iDsBEuKi0x0X9KgNT+PIfiHkFdctLwpY/0NHx9qC2EVALiHVNkVhl6XbhywwQgd+bppn PuxhGLKaVJ0mKmSQLICWLRenddA5TWhYQWpfNpiH/FTLVFSQ/oZZH3rQBNoqmWDP0wHf JtFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735810838; x=1736415638; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=vBrc7EuOMXY8yTx/TbXVRV+IK2Cs6RWnPvid7BqXfWc=; b=tmIZS3zWtsbygzMCBD8xZCttDv/e0sfwBW824H57+PVYj2O0F6U4MZc95SyjLjueVf tnoQoKJNAE4npmxFa+rZYv7RgcRGF1pZZglPLGxee6i2BkWzVvIKV2OWrUaKpgs3XtMH nVSbU2ZvWVpFrFr4Jit7Jl1+J4/ErGIM7I+P1reHa8VEt7GTE5uCNrEy2NZCswa8G/xp 6UW6MR+ncceRRh2Uj72nEL2kn7Cgy9d7S8MldXcp1JL967Y2Q0sAQokxfHrwsOb5k4rx scUYI3Vjjv6O9Yo68ERGgOqTxk3ZLkW9HI8U4v4TwRGMTksIzBTDNv1w9VTh1xDjQDre wR2w== X-Gm-Message-State: AOJu0YwWpwQAQRhj+XEnKpnsSQtiSbUdJTjFZ18ix99nIMBIwx0TxQGc pnMLerLexkLW3UmTyS596Nh9RA+f3JlkYfTOmWgGvg2d967nNze9HEOyFkpNAI0= X-Gm-Gg: ASbGncu/gBgvgRO08qU8Thl/XWWqBLpXqXcELPjJFzDQd+eBJxlshQZpcP0WPFDOSAJ AoKxJCtHua+avOeS5QRHHhpIU9FerifcqPFAgaenk+VuoGQDFsq9uhnaN0nOZBd+GTcGpMoqjLR FzMCRF9N4+7K/RB9nSd0IyAIhhdlp9UpBKDP/lWrqSN1WIFvQClWblcUWx3lW40qaDHkoeXJbCZ iPlrn5S12uM8mZK/Ueb4rBltKBXB23Vr+Zm6tdBwtqt+o011Si5gOivFiW+uczIA4yLvFHXcg/i XfgAxi1mA1v7QyGNqa1Pbyg820FcftCCVw== X-Google-Smtp-Source: AGHT+IFyQxq7+SLmgC3lEOJrijlLY/blJUqn/3ChXyKJbxUPuO43SDrq1oyRFY0OkutfbUe85tJpHQ== X-Received: by 2002:a05:6000:2ae:b0:385:ed16:c97 with SMTP id ffacd0b85a97d-38a224088aemr34478674f8f.49.1735810837548; Thu, 02 Jan 2025 01:40:37 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:1cfa:329a:aa2e:f0be? ([2a01:e0a:982:cbb0:1cfa:329a:aa2e:f0be]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c828bd3sm37151921f8f.10.2025.01.02.01.40.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jan 2025 01:40:37 -0800 (PST) Message-ID: Date: Thu, 2 Jan 2025 10:40:36 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: neil.armstrong@linaro.org Subject: Re: [RFC PATCH v1 0/2] iio: adc: meson: add MPLL clock workaround for GXLX To: Martin Blumenstingl , linux-amlogic@lists.infradead.org, linux-iio@vger.kernel.org Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, lars@metafoo.de, robh@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, gnstark@salutedevices.com, krzk+dt@kernel.org, jic23@kernel.org References: <20241231194207.2772750-1-martin.blumenstingl@googlemail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20241231194207.2772750-1-martin.blumenstingl@googlemail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 31/12/2024 20:42, Martin Blumenstingl wrote: > Hello, > > Amlogic GXLX SoCs seem to be mostly the same silicon as GXL. The only > known differences are: > - one less Mali-450 GPU core > - no VP9 codec > - and an odd one: the three MPLL clocks need a bit toggled in the SAR > ADC register space > > This series attempt to fix audio output (which relies on the MPLL > clocks) on the GXLX boards. Unfortunately all we have is a downstream > commit [0] without any further explanation (or anyone who wants to > provide details on this). Since it's not clear if this is a gate, a > reset or some other hardware fix: the driver side includes a warning > for users to update their .dtb along with kernel images in case we > ever figure out what these bits do and how to model them properly. > > > [0] https://github.com/khadas/linux/commit/d1d98f2ed8c83eb42af8880ed8e206aa402dd70a#diff-c5aaf54323ef93777c5083de37f933058ea8d0af79a1941e0b5a0667dc0f89b3 > > > Martin Blumenstingl (2): > dt-bindings: iio: adc: amlogic,meson-saradc: Add GXLX SoC compatible > iio: adc: meson: add support for the GXLX SoC > > .../iio/adc/amlogic,meson-saradc.yaml | 1 + > drivers/iio/adc/meson_saradc.c | 34 +++++++++++++++++++ > 2 files changed, 35 insertions(+) > LGTM Reviewed-by: Neil Armstrong