From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: David Wronek <davidwronek@gmail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Taniya Das <tdas@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, map220v <map220v300@gmail.com>
Subject: Re: [PATCH 4/7] clk: qcom: gcc-sc7180: Fix up gcc_sdcc2_apps_clk_src
Date: Wed, 5 Jul 2023 11:48:59 +0200 [thread overview]
Message-ID: <f888e7e2-9a7d-4525-78a3-cfdecdc8a918@linaro.org> (raw)
In-Reply-To: <20230704163848.169853-6-davidwronek@gmail.com>
On 04/07/2023 18:31, David Wronek wrote:
> From: map220v <map220v300@gmail.com>
>
> Add the PARENT_ENABLE flag to prevent the clock from getting stuck at
> boot.
What does it mean that "clock getting stuck at boot"? How a clock can stuck?
>
> Fixes: 17269568f726 ("clk: qcom: Add Global Clock controller (GCC) driver for SC7180")
> Signed-off-by: map220v <map220v300@gmail.com>
Same concerns as for other patches with this. Look:
https://github.com/map220v/sm7125-mainline/commit/e754e5725cb596049df2437d7c857e4d232e87fb
No SoB.
> Signed-off-by: David Wronek <davidwronek@gmail.com>
Fixes must be either first in series or better sent separately. There is
no reason for them to be in this patchset in the first place, because
they are not related.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-05 9:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 16:31 [PATCH 0/7] Add initial support for SM7125 and Xiaomi SM7125 platform David Wronek
2023-07-04 16:31 ` [PATCH 1/7] dt-bindings: arm: qcom,ids: Add SoC ID for SM7125 David Wronek
2023-07-05 9:46 ` Krzysztof Kozlowski
2023-07-05 15:48 ` David Wronek
2023-07-06 6:09 ` Krzysztof Kozlowski
2023-07-04 16:31 ` [PATCH 2/7] dt-bindings: arm: qcom: Document SM7125 and xiaomi,joyeuse board David Wronek
2023-07-05 9:47 ` Krzysztof Kozlowski
2023-07-04 16:31 ` [PATCH 3/7] soc: qcom: socinfo: Add SoC ID for SM7125 David Wronek
2023-07-04 16:31 ` [PATCH 4/7] clk: qcom: gcc-sc7180: Fix up gcc_sdcc2_apps_clk_src David Wronek
2023-07-05 4:27 ` Taniya Das
2023-07-05 10:45 ` Konrad Dybcio
2023-07-05 13:41 ` ungeskriptet
2023-07-05 9:48 ` Krzysztof Kozlowski [this message]
2023-07-04 16:31 ` [PATCH 5/7] arm64: dts: qcom: pm6150: Add resin and rtc nodes David Wronek
2023-07-04 18:06 ` Konrad Dybcio
2023-07-04 16:31 ` [PATCH 6/7] arm64: dts: qcom: Add SM7125 device tree David Wronek
2023-07-05 9:50 ` Krzysztof Kozlowski
2023-07-04 16:32 ` [PATCH 7/7] arm64: dts: qcom: Add support for the Xiaomi SM7125 platform David Wronek
2023-07-04 18:10 ` Konrad Dybcio
2023-07-05 9:54 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f888e7e2-9a7d-4525-78a3-cfdecdc8a918@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davidwronek@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=map220v300@gmail.com \
--cc=mturquette@baylibre.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).