From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB308155CBA for ; Thu, 28 Nov 2024 22:34:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732833288; cv=none; b=o3ssR5yP3O7HK+wXBhLGWnLMtkZLoZ7/B4rNCbFYcUrXyn3OGK638Qk6GM30E3RzEaKpyFqLEl2HJUCs22sWIXHxAYE56uBLr+/51q4Qt7vc2XCsamwTAxAVsqD+3uRP5UiXp1ZqEY+8YoBTOqryhLZht95IMQRTO5cAgvYVksA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732833288; c=relaxed/simple; bh=AUkT88Th6kutpsO9rSnKuodwKE5fXwcpQTd6174vA6k=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=XLylyT7yw4Kd0RYONzYlhylNc9u6VfEdAXVptW/YxQ3KCHctbMwVN67+OCvMCegA5jmZzmRfCoCaDBNFpue678XoxU/2ABkntdOCJG47I9BRAYPjfca+pFAN87UsYBs6tHHh3z2FUYd1F2lWvss9kxr5p7P8717Drlxco3L4ino= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=CJrVLhy5; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CJrVLhy5" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4349e1467fbso11178665e9.1 for ; Thu, 28 Nov 2024 14:34:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1732833285; x=1733438085; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=mPjrQlS/j4lgnq4nZOck4tCS7rWNRW0RmXaCV/t217s=; b=CJrVLhy5H5xIVbsF/pS1hp7tYgWyva3X+IOClnq/cm6hucVBgxUCUzIPTpjLZ+mHfd sYhl1rcOnW5Fvl9Um9EEW6KHlyf9rPZYiB7on5SIY3KWwEBywkDkskSL6UQoPxFQq9bM /9LIywAKTCXPx9O6G6I/HBNhfQwaV7z232Uo0WVE5jlEB8QyWR6AlMrdv+b5icCkFkj5 Y78IHwpq/LrHl+i9yQo0FIe40e7gv0mcUPwRk8q132yEZ1hGUIj/RpRpUdcgPzR0k+b/ q7k42VkpVoUqhkXbqDbckxZubwJf3DWDOjnvociWqv55SJIthF5P/sOAWI3kzUznKQjz YZPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732833285; x=1733438085; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mPjrQlS/j4lgnq4nZOck4tCS7rWNRW0RmXaCV/t217s=; b=ZrVJQfG+DyeK+pZFwhM98ds7sCzwaMcJEJblQSRAgLWJW3MgmQO8XCTWbGV3CKUqWp oFwJZwso5iGcKdIZ/d63sxZC5xBiMqo+JudKXSFqf/S9o5xscfVXDyRm3cnIjfXRzSkB 3o1Yp6odjeF40kXPB1BLEmjfN1FaawSAQ8keGggINcrDe7Gw4fgamAY7QisRPwEAZ78F 76Iw7+K3chA2I0Mq+WZDc9VrlaneNlmfdIuDJkkX6bLIPgjTvQs8PflD7WMP/6ZIwPJ3 TlAJRt7icdBs6H0VsH4avp4tE4L1/jfYks2wBHmKJ6MC/nQaFet7Oz2uElYRiP3SQCXq 9A8w== X-Forwarded-Encrypted: i=1; AJvYcCWFnnDFHGGcSEK0A86zqbkkKkRcB8cHsUh4ZuMyyyC6paCkjMSJPx0oN2vZicNVeg8Iq2mLQ9HG7yac@vger.kernel.org X-Gm-Message-State: AOJu0YyilGv/tJJziut2PcOkpGUV5BdL9Q4Mh7MuF0hBBnYODLMLW3Ho 2Xy+pqFWG8g55gpFsCJhJLFZP6H7mfb8slzOchlHpWXPmGcJhJdbUWIqaO9ndfs= X-Gm-Gg: ASbGncs8JpEvtYfSDs8bgQYxhXCPeZXtWh/uTHi0Zf53gUF4PzOCZZbia0MLk+CrdVz mN2Xsz97bRuS2CqOfv74ur9ZU/nVR4kW5yoj7lp3JIGfOnarQDtNpNR2MyD4A5yIizigWZLeWl+ tKzv41qthti/xmLY+UQkma4cogyRoIj1JwB2dR+IsdK++QU4QUdzjWAFSQmNAM6zQjIIi7F1Z9r 742F0OhSiaSdL0HtNK3SV9dhgt4wbpwuVKb69ed9b+LPPsjcKMfeSsLDLonvsQ= X-Google-Smtp-Source: AGHT+IH8HKeLrud/hmB58OwNwUNUc0fecGxOTCsVoS2qCTKMbmueDaSl/mes9YkrPVY95d4pKo7gpg== X-Received: by 2002:a05:6000:18ab:b0:382:4978:2ab9 with SMTP id ffacd0b85a97d-385c6cca356mr8106802f8f.5.1732833285140; Thu, 28 Nov 2024 14:34:45 -0800 (PST) Received: from [192.168.0.40] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-385d6e60909sm1601043f8f.76.2024.11.28.14.34.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Nov 2024 14:34:44 -0800 (PST) Message-ID: Date: Thu, 28 Nov 2024 22:34:43 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] media: venus: Add support for static video encoder/decoder declarations From: Bryan O'Donoghue To: Konrad Dybcio , Stanimir Varbanov , Vikash Garodia , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: quic_renjiang@quicinc.com, quic_vnagar@quicinc.com, quic_dikshita@quicinc.com, konradybcio@kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Stanimir Varbanov , devicetree@vger.kernel.org References: <20241127-media-staging-24-11-25-rb3-hw-compat-string-v1-0-99c16f266b46@linaro.org> <20241127-media-staging-24-11-25-rb3-hw-compat-string-v1-1-99c16f266b46@linaro.org> <7d344377-f1cf-400e-a9c4-442123dcf4ab@oss.qualcomm.com> <95ec73c9-da38-4888-9e00-4458b5a7661c@linaro.org> Content-Language: en-US In-Reply-To: <95ec73c9-da38-4888-9e00-4458b5a7661c@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 28/11/2024 22:14, Bryan O'Donoghue wrote: > On 28/11/2024 20:02, Konrad Dybcio wrote: >> Bryan, >> >> I'm still not sure if keeping the logic behind this makes sense at all. >> >> Could we not just call platform_device_register_data() with a static >> configuration of 1 core being enc and the other dec? > > That's another way to do this. One reason I wrote this series to > continue to rely on the existing compat= method though is it stuck in my > mind that we have some dependency ordering logic in at the moment. > > For example: > > commit 08b1cf474b7f72750adebe0f0a35f8e9a3eb75f6 > Author: Bryan O'Donoghue > Date:   Fri Feb 5 19:11:49 2021 +0100 > > And the other reason is the prototype platform_device_register_* looks > like more surgery and ultimately more validation / potential for bugs. > > Since this driver is supposed to be moving to maintenance mode, I didn't > want to do a more major rewrite of the probe() and remove() paths. > > --- > bod > and.. I wanted to continue support sdm630/sdm660/msm8996/msm8998 without any additional effort to go finding power-domains and clocks which in those cases the existing compat= method actually does something useful. Also potentially other/new additions to venus which have xcoder specific PDs and clocks would logically want to specify those as we do for the above listed SoCs. --- bod