From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07A27C4332F for ; Thu, 22 Dec 2022 12:01:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235829AbiLVMBm (ORCPT ); Thu, 22 Dec 2022 07:01:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235872AbiLVMBS (ORCPT ); Thu, 22 Dec 2022 07:01:18 -0500 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F41733CF2; Thu, 22 Dec 2022 03:53:51 -0800 (PST) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 2BMBrPJm034972; Thu, 22 Dec 2022 05:53:25 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1671710005; bh=Pa68b4sXRmlnioUqLVfGjGaP9VNUezQMYQLlr032dqo=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=Y04xHemtQJg22QotSih5nUzCXb8V3/JphHTFMrZ5GD+fQ5MBFHrrT3gscCKypA4ox kmNo08vOhQ7FXOf3WXAsbeRXDF/UbLdA/Fzeh/0s8jZkeLZmcjnqgKAcDOeQb8CNZf ZLM5HC18kLVTrX08KdD80kvUPvvfqA5ChXdfgavo= Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 2BMBrPAY109598 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 22 Dec 2022 05:53:25 -0600 Received: from DFLE101.ent.ti.com (10.64.6.22) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Thu, 22 Dec 2022 05:53:25 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Thu, 22 Dec 2022 05:53:25 -0600 Received: from [10.250.234.78] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 2BMBrFU4092320; Thu, 22 Dec 2022 05:53:18 -0600 Message-ID: Date: Thu, 22 Dec 2022 17:23:15 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [EXTERNAL] Re: [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes Content-Language: en-US To: Krzysztof Kozlowski , , CC: , , , , , Vignesh Raghavendra References: <20221220101249.46450-1-b-kapoor@ti.com> <79ffe459-3827-ea67-e854-8eef3d9b630b@linaro.org> <5e8d7388-1b2b-cebb-fd09-38b4364c00e1@linaro.org> From: Bhavya Kapoor In-Reply-To: <5e8d7388-1b2b-cebb-fd09-38b4364c00e1@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22/12/22 16:16, Krzysztof Kozlowski wrote: > On 22/12/2022 11:39, Bhavya Kapoor wrote: >> On 21/12/22 13:24, Krzysztof Kozlowski wrote: >>> On 21/12/2022 06:42, Bhavya Kapoor wrote: >>>> On 20/12/22 16:20, Krzysztof Kozlowski wrote: >>>>> On 20/12/2022 11:12, Bhavya Kapoor wrote: >>>>>> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes >>>>>> for 8 channel ADCs for J721s2 SoC. >>>>>> >>>>>> Signed-off-by: Bhavya Kapoor >>>>>> --- >>>>>> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++ >>>>>> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++- >>>>>> 2 files changed, 55 insertions(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >>>>>> index a7aa6cf08acd..67593aa69327 100644 >>>>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >>>>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >>>>>> @@ -309,3 +309,17 @@ &mcu_mcan1 { >>>>>> pinctrl-0 = <&mcu_mcan1_pins_default>; >>>>>> phys = <&transceiver2>; >>>>>> }; >>>>>> + >>>>>> +&tscadc0 { >>>>>> + status = "okay"; >>>>>> + adc { >>>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>; >>>>>> + }; >>>>>> +}; >>>>>> + >>>>>> +&tscadc1 { >>>>>> + status = "okay"; >>>>>> + adc { >>>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>; >>>>>> + }; >>>>>> +}; >>>>>> \ No newline at end of file >>>>> This is a friendly reminder during the review process. >>>>> >>>>> It seems my previous comments were not fully addressed. Maybe my >>>>> feedback got lost between the quotes, maybe you just forgot to apply it. >>>>> Please go back to the previous discussion and either implement all >>>>> requested changes or keep discussing them. >>>>> >>>>> Thank you. >>>>> >>>>> Best regards, >>>>> Krzysztof >>>> Hi , I thought i did addressed the feedback since tscadc is just a >>>> wrapper node. >>>> >>>> The actual adc node is inside of tscadc node. >>> Read the feedback, from all emails. >>> Best regards, >>> Krzysztof >> >> Hi , i have gone through all earlier mails but can't find anything else. >> Can you point out again whats the issue. > "And this is a v2? Or resend? Or something else?" > > You miss proper versioning and changelog. > > Additionally - I commented just before error in your patch. You must fix > it, not ignore it, even though I did not point it out before. > > Best regards, > Krzysztof Hi, i had replied to that as well earlier. You can check that out https://lore.kernel.org/all/89ce3639-e979-e369-657a-20aea4295970@ti.com/ . Maybe you missed out on that. Regards