From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9356D2288DA; Wed, 5 Feb 2025 09:07:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738746464; cv=none; b=H1whDXDVcm56utccdjSDbnpEc2+4SZbRwji7YnBH1EOI2B+pVdq4CqJ9niBwh+x1uxSokVmKsyfUHIRPt/LucGrcl9C87X7Bt4NMuCKKemig0oJA0pZ6qSjRaOWqAjGXAnAStl+OmC6bT6eUZ6rQ6ynFzg+Ai9Z82SZTp3ejQZw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738746464; c=relaxed/simple; bh=dT+brue9bZJjCvucpVy58D22kI3f5XOtfMhs1uM9yK4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f4UVkDdnXfZWkhyKA67M8ZOfC1WKjVMN64cuBIEqtfrJ3NvBg6ramp2j02RpA8A4XYKYX8oT6h9r2MApl2nsfQJEAQvIQ3RRqoJyL65YxhYEV4e2gcZsb0Ew/H/pZXdm4qafkya1RKHwUMd+VFyceLOn3io42KZphKWMYprsej8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MasVflAY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MasVflAY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3A9BC4CED1; Wed, 5 Feb 2025 09:07:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738746464; bh=dT+brue9bZJjCvucpVy58D22kI3f5XOtfMhs1uM9yK4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=MasVflAYp/mJcGP/oEgutBOTMVZYjWqhrZVQzSUYpte7GSgnZ77EO3c3VJetMUHMM e4Xifam28m02X3uq0qXEu22NGDZXt4OPqYmYMEwiTz4QPWlRuMExdKxQth5MROCJcE fSS5VxN5umHl95u1iepZp0T1J87sv7VOcdT3WsOqbRR523XDDyU8WZpVF1MRExeupF 7JHAIqt/NczBDkAkgyUl3araUGwtyfEOX2n9MKf358Clfke0KECpzm3qzsUuVUfhkM G1MpEERMZOcq0RMob9+1g+sjWCnT5J8UnyCUwMcF1MGGHzOBfEI56nWKg7i6T4jKg9 S8kM27RERuKnQ== Message-ID: Date: Wed, 5 Feb 2025 10:07:38 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 07/13] wifi: ath12k: add support for fixed QMI firmware memory To: Raj Kumar Bhagat , ath12k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Kalle Valo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jeff Johnson , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250130043508.1885026-1-quic_rajkbhag@quicinc.com> <20250130043508.1885026-8-quic_rajkbhag@quicinc.com> <4c9b512f-59d2-4d96-a899-5af4de2c823e@kernel.org> <7d5f7b4c-2a55-41c7-b85c-cb4cd76d553f@quicinc.com> <962dc257-f7a6-49c7-b760-a31fd84e7a56@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 04/02/2025 10:06, Raj Kumar Bhagat wrote: > On 2/3/2025 3:42 PM, Krzysztof Kozlowski wrote: >> On 03/02/2025 10:44, Raj Kumar Bhagat wrote: >>> On 1/30/2025 1:16 PM, Krzysztof Kozlowski wrote: >>>> On 30/01/2025 05:35, Raj Kumar Bhagat wrote: >>>>> @@ -2646,6 +2663,136 @@ static int ath12k_qmi_alloc_target_mem_chunk(struct ath12k_base *ab) >>>>> return ret; >>>>> } >>>>> >>>>> +static int ath12k_qmi_assign_target_mem_chunk(struct ath12k_base *ab) >>>>> +{ >>>>> + struct device_node *mem_node; >>>>> + struct resource res, m3_res; >>>>> + u32 bdf_start_addr; >>>>> + int i, idx, ret; >>>>> + >>>>> + for (i = 0, idx = 0; i < ab->qmi.mem_seg_count; i++) { >>>>> + switch (ab->qmi.target_mem[i].type) { >>>>> + case HOST_DDR_REGION_TYPE: >>>>> + mem_node = ath12k_core_get_reserved_mem_by_name(ab, "q6-region"); >>>> >>>> >>>> Why cannot you use existing API for reserved memory - >>>> of_reserved_mem_lookup()? >>>> >>> >>> The of_reserved_mem_lookup() requires reserved memory node to read the memory and >>> return in the structure "struct reserved_mem". >>> >>> The of_reserved_mem_lookup() would be used after we get the reserved memory node >>> using the API - ath12k_core_get_reserved_mem_by_name(ab, "q6-region"); >>> >>> In next version we would use of_reserved_mem_lookup(), Something like below: >>> mem_node = ath12k_core_get_reserved_mem_by_name(ab, "q6-region"); >> >> Then why do you need ath12k_core_get_reserved_mem_by_name() in the first >> place? Just use of_reserved_mem_lookup() directly. Why do you need to >> parse phandle before of_reserved_mem_lookup()? >> > > Sorry, I'm having difficulty understanding this. > We have the WiFi node at ab->dev->of_node, but we don't have a node for the reserved-memory > 'q6-region'. The of_reserved_mem_lookup() function requires the device node for 'q6-region'. > > Could you please suggest how we can use of_reserved_mem_lookup() without obtaining the > 'q6-region' node first. Hm, it seems you are not using it for this device, so indeed you need to parse phandle. You can still code it simpler - of_property_match_string() is not necessary and of_address_to_resource()+of_node_put() could be in the ath12k_core_get_reserved_mem() Best regards, Krzysztof