devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michal Vokáč" <vokac.m@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>, andrew@lunn.ch
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, vivien.didelot@savoirfairelinux.com,
	mark.rutland@arm.com, robh+dt@kernel.org, davem@davemloft.net,
	michal.vokac@ysoft.com
Subject: Re: [PATCH net-next v3 0/7] Add support for QCA8334 switch
Date: Thu, 24 May 2018 11:34:57 +0200	[thread overview]
Message-ID: <f8bf325c-77a5-d44b-34c3-93ea4b11fd84@gmail.com> (raw)
In-Reply-To: <29ea7cdd-5690-e39a-a2ef-4f48fbcb7659@gmail.com>

On 23.5.2018 17:39, Florian Fainelli wrote:
> 
> 
> On 05/22/2018 11:20 PM, Michal Vokáč wrote:
>> This series basically adds support for a QCA8334 ethernet switch to the
>> qca8k driver. It is a four-port variant of the already supported seven
>> port QCA8337. Register map is the same for the whole familly and all chips
>> have the same device ID.
>>
>> Major part of this series enhances the CPU port setting. Currently the CPU
>> port is not set to any sensible defaults compatible with the xGMII
>> interface. This series forces the CPU port to its maximum bandwidth and
>> also allows to adjust the new defaults using fixed-link device tree
>> sub-node.
>>
>> Alongside these changes I fixed two checkpatch warnings regarding SPDX and
>> redundant parentheses.
> 
> Looks great, thanks Michal! Do you have any features or things you are
> working on that would be added later to the driver?

Thank you too Florian. And also big thank to you Andrew. You helped me
a lot to debug the RGMII issue. I have been stuck at that for more than
a month and would not resolve it without your help.

As I have done this in a process of upgrading our BSP to a more recent
kernel, and hopefully mainline, I now need to move on to other parts of
the board. So unfortunately no, I do not have any other enhancements
planned to this driver for now. But as we are probably one of the few
with access to the NDA covered Qualcomm documentation I see a great
opportunity to work on that later. I am afraid "later" means something
like next year in this case as I am basically the only kernel developer
in our company and not yet very experienced.

Thank you all for your time,
Michal

  reply	other threads:[~2018-05-24  9:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-23  6:20 [PATCH net-next v3 0/7] Add support for QCA8334 switch Michal Vokáč
2018-05-23  6:20 ` [PATCH net-next v3 1/7] net: dsa: qca8k: Add QCA8334 binding documentation Michal Vokáč
2018-05-23 15:37   ` Florian Fainelli
2018-05-23  6:20 ` [PATCH net-next v3 2/7] net: dsa: qca8k: Add support for QCA8334 switch Michal Vokáč
2018-05-23 15:38   ` Florian Fainelli
2018-05-23  6:20 ` [PATCH net-next v3 3/7] net: dsa: qca8k: Enable RXMAC when bringing up a port Michal Vokáč
2018-05-23  6:20 ` [PATCH net-next v3 4/7] net: dsa: qca8k: Force CPU port to its highest bandwidth Michal Vokáč
2018-05-23  6:20 ` [PATCH net-next v3 5/7] net: dsa: qca8k: Allow overwriting CPU port setting Michal Vokáč
2018-05-23  6:20 ` [PATCH net-next v3 6/7] net: dsa: qca8k: Replace GPL boilerplate by SPDX Michal Vokáč
2018-05-23  6:20 ` [PATCH net-next v3 7/7] net: dsa: qca8k: Remove redundant parentheses Michal Vokáč
2018-05-23 15:39 ` [PATCH net-next v3 0/7] Add support for QCA8334 switch Florian Fainelli
2018-05-24  9:34   ` Michal Vokáč [this message]
2018-05-24 13:17     ` Andrew Lunn
2018-05-23 19:47 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8bf325c-77a5-d44b-34c3-93ea4b11fd84@gmail.com \
    --to=vokac.m@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=michal.vokac@ysoft.com \
    --cc=netdev@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).