From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE3B0C433EF for ; Mon, 7 Mar 2022 12:17:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233271AbiCGMSH (ORCPT ); Mon, 7 Mar 2022 07:18:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241695AbiCGMSB (ORCPT ); Mon, 7 Mar 2022 07:18:01 -0500 Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9356C7F6CA; Mon, 7 Mar 2022 04:17:06 -0800 (PST) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 4B4442223A; Mon, 7 Mar 2022 13:17:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1646655424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0Gpr1Xg6QkwtyGAbSKHyjlK5VgUrvEjiF2wzRKT1dYs=; b=gll/rzRQe4/Bc0sN3O41kZBJi7z3WEQ54AgWH3/ox48A+LkbvKnm65Pd/OCFehW1BSwkXm dUclOG2Gg1I6/Am39yTyLw48rujxrWKqZhV7JwqYp2kyjLgOtv1/zcherediBmzyrC4ohY 1BKkmU5XB2m8Lu871EFK6wdCTmE7HxE= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 07 Mar 2022 13:17:04 +0100 From: Michael Walle To: Claudiu.Beznea@microchip.com Cc: Kavyasree.Kotagiri@microchip.com, Nicolas.Ferre@microchip.com, arnd@arndb.de, olof@lixom.net, soc@kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski@canonical.com, alexandre.belloni@bootlin.com Subject: Re: [PATCH v1 6/6] ARM: dts: lan966x: add basic Kontron KSwitch D10 support In-Reply-To: <1098e023-afb7-5453-cd3a-8b81b3d48f4f@microchip.com> References: <20220303160323.3316317-1-michael@walle.cc> <20220303160323.3316317-7-michael@walle.cc> <900be5239b96cd77493fbcfbe220989f@walle.cc> <1098e023-afb7-5453-cd3a-8b81b3d48f4f@microchip.com> User-Agent: Roundcube Webmail/1.4.12 Message-ID: X-Sender: michael@walle.cc Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am 2022-03-07 13:07, schrieb Claudiu.Beznea@microchip.com: > On 04.03.2022 13:15, Michael Walle wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know >> the >> content is safe >> >> Am 2022-03-04 09:31, schrieb Claudiu.Beznea@microchip.com: >>> On 03.03.2022 18:03, Michael Walle wrote: >>>> EXTERNAL EMAIL: Do not click links or open attachments unless you >>>> know >>>> the content is safe >>>> >>>> Add basic support for the Kontron KSwitch D10 MMT 6G-2GS which >>>> features 6 Gigabit copper ports and two SFP cages. For now the >>>> following is working: >>>>  - Kernel console >>>>  - SFP cages I2C bus and mux >>>>  - SPI >>>>  - SGPIO >>>>  - Watchdog >>>> >>>> Signed-off-by: Michael Walle >>>> --- >>>>  arch/arm/boot/dts/Makefile                    |   3 +- >>>>  ...lan966x-kontron-kswitch-d10-mmt-6g-2gs.dts | 159 >>>> ++++++++++++++++++ >>>>  2 files changed, 161 insertions(+), 1 deletion(-) >>>>  create mode 100644 >>>> arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dts >>>> >>>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >>>> index 085c43649d44..86dd0f9804ee 100644 >>>> --- a/arch/arm/boot/dts/Makefile >>>> +++ b/arch/arm/boot/dts/Makefile >>>> @@ -739,7 +739,8 @@ dtb-$(CONFIG_SOC_IMX7ULP) += \ >>>>         imx7ulp-com.dtb \ >>>>         imx7ulp-evk.dtb >>>>  dtb-$(CONFIG_SOC_LAN966) += \ >>>> -       lan966x-pcb8291.dtb >>>> +       lan966x-pcb8291.dtb \ >>>> +       lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb >>>>  dtb-$(CONFIG_SOC_LS1021A) += \ >>>>         ls1021a-moxa-uc-8410a.dtb \ >>>>         ls1021a-qds.dtb \ >>>> diff --git >>>> a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dts >>>> b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dts >>>> new file mode 100644 >>>> index 000000000000..958678dec7ad >>>> --- /dev/null >>>> +++ b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dts >>>> @@ -0,0 +1,159 @@ >>>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >>>> +/* >>>> + * Device Tree file for the Kontron KSwitch D10 MMT 6G-2GS >>>> + */ >>>> + >>>> +/dts-v1/; >>>> +#include "lan966x.dtsi" >>>> + >>>> +/ { >>>> +       model = "Kontron KSwitch D10 MMT 6G-2GS"; >>>> +       compatible = "kontron,kswitch-d10-mmt-6g-2gs", >>>> "kontron,s1921", >>>> +                    "microchip,lan9668", "microchip,lan966"; >>>> + >>>> +       aliases { >>>> +               serial0 = &usart0; >>>> +       }; >>>> + >>>> +       chosen { >>>> +               stdout-path = "serial0:115200n8"; >>>> +       }; >>>> + >>>> +       gpio-restart { >>>> +               compatible = "gpio-restart"; >>>> +               gpios = <&gpio 56 GPIO_ACTIVE_LOW>; >>>> +               priority = <200>; >>>> +       }; >>>> + >>>> +       i2cmux { >>>> +               compatible = "i2c-mux-gpio"; >>>> +               #address-cells = <1>; >>>> +               #size-cells = <0>; >>>> +               mux-gpios = <&sgpio_out 3 2 GPIO_ACTIVE_HIGH>, >>>> +                           <&sgpio_out 3 3 GPIO_ACTIVE_HIGH>; >>>> +               i2c-parent = <&i2c4>; >>>> + >>>> +               i2c4_0: i2c@1 { >>>> +                       reg = <1>; >>>> +                       #address-cells = <1>; >>>> +                       #size-cells = <0>; >>>> +               }; >>>> + >>>> +               i2c4_1: i2c@2 { >>>> +                       reg = <2>; >>>> +                       #address-cells = <1>; >>>> +                       #size-cells = <0>; >>>> +               }; >>>> +       }; >>>> + >>>> +       sfp0: sfp0 { >>>> +               compatible = "sff,sfp"; >>>> +               i2c-bus = <&i2c4_0>; >>>> +               los-gpios = <&sgpio_in 1 0 GPIO_ACTIVE_HIGH>; >>>> +               mod-def0-gpios = <&sgpio_in 1 1 GPIO_ACTIVE_LOW>; >>>> +               maximum-power-milliwatt = <2500>; >>>> +               tx-disable-gpios = <&sgpio_out 3 0 GPIO_ACTIVE_LOW>; >>>> +               tx-fault-gpios = <&sgpio_in 0 2 GPIO_ACTIVE_HIGH>; >>>> +               rate-select0-gpios = <&sgpio_out 2 0 >>>> GPIO_ACTIVE_HIGH>; >>>> +               rate-select1-gpios = <&sgpio_out 2 1 >>>> GPIO_ACTIVE_HIGH>; >>>> +       }; >>>> + >>>> +       sfp1: sfp1 { >>>> +               compatible = "sff,sfp"; >>>> +               i2c-bus = <&i2c4_1>; >>>> +               los-gpios = <&sgpio_in 1 2 GPIO_ACTIVE_HIGH>; >>>> +               mod-def0-gpios = <&sgpio_in 1 3 GPIO_ACTIVE_LOW>; >>>> +               maximum-power-milliwatt = <2500>; >>>> +               tx-disable-gpios = <&sgpio_out 3 1 GPIO_ACTIVE_LOW>; >>>> +               tx-fault-gpios = <&sgpio_in 0 3 GPIO_ACTIVE_HIGH>; >>>> +               rate-select0-gpios = <&sgpio_out 2 2 >>>> GPIO_ACTIVE_HIGH>; >>>> +               rate-select1-gpios = <&sgpio_out 2 3 >>>> GPIO_ACTIVE_HIGH>; >>>> +       }; >>>> +}; >>>> + >>>> +&flx0 { >>>> +       atmel,flexcom-mode = ; >>>> +       status = "okay"; >>>> +}; >>>> + >>>> +&flx3 { >>>> +       atmel,flexcom-mode = ; >>>> +       status = "okay"; >>>> +}; >>>> + >>>> +&flx4 { >>>> +       atmel,flexcom-mode = ; >>>> +       status = "okay"; >>>> +}; >>> >>> Although there is 1:1 mapping b/w ids of flexcoms and the embedded >>> blocks >>> (flxX has usartX, i2cX, spiX) and there is nothing wrong with the >>> approach >>> here I found a bit hard to follow if the correspondent embedded block >>> (i2c, spi, usart) is enabled or not. >> >> I know and I had the same feeling, but I don't want to have the >> subnodes (matched by name) in these nodes.  I.e. I want to avoid >> something like: >> >> &flx4 { >>        atmel,flexcom-mode = ; >>        status = "okay"; >> >>        i2c@600 { >>               pinctrl-0 = <&fc4_b_pins>; >>               pinctrl-names = "default"; >>               status = "okay"; >>        }; >> }; > > All the other AT91 DTs are using the above format + the specific label > in > front of the subnode, e.g: > > i2cX: i2c@600 { > >> >> If someone renames the subnode in the dtsi, it might easily be >> overlooked in the board files. Having the handle will raise an >> error. > > If using label + node name as pointed above there will be an error > thrown > for your scenario. Fair enough. You'll get a duplicate reference error as long as the reference itself isn't renamed either. But to make it short, unless you force me too, I'd like to keep the child node as is and not as a subnode of the flexcom. I just don't want to repeat the name if there is no reason and I live with the fact that they are not near each other :) That flexcom-mode could also be deduced from the enabled children, btw. >> And because the node references should be sorted alphabetically >> it will be cluttered around in the file. You could rename the >> references to flx4_i2c though. But I don't know it its worth >> the efforts. Let me know what you think. -michael