From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bjorn Andersson <quic_bjorande@quicinc.com>
Cc: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>, Niklas Cassel <nks@flawful.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Robert Marko <robimarko@gmail.com>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
Jeffrey Hugo <quic_jhugo@quicinc.com>,
Marijn Suijten <marijn.suijten@somainline.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>
Subject: Re: [PATCH v14 4/9] soc: qcom: cpr: Move common functions to new file
Date: Wed, 19 Jun 2024 01:33:45 +0200 [thread overview]
Message-ID: <f8cd4691-48fd-42a9-8e4e-e942c4475ddd@linaro.org> (raw)
In-Reply-To: <20230829151509.GN818859@hu-bjorande-lv.qualcomm.com>
On 8/29/23 17:15, Bjorn Andersson wrote:
> On Mon, Aug 28, 2023 at 01:42:16PM +0200, Konrad Dybcio wrote:
>> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
>>
>
> It seems reasonable to update the subject prefix, now that things have
> moved to the genpd subsystem.
Ack
>
>> In preparation for implementing a new driver that will be handling
>> CPRv3, CPRv4 and CPR-Hardened, format out common functions to a new
>> file.
>>
>> Update cpr_get_fuses in preparation for CPR3 implementation, change
>> parameters where necessary to not take cpr.c private data structures.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
>> [Konrad: rebase, apply review comments, improve msg, split]
>> Tested-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>> drivers/genpd/qcom/Makefile | 2 +-
>> drivers/genpd/qcom/cpr-common.c | 350 ++++++++++++++++++++++++++++++++++++
>> drivers/genpd/qcom/cpr-common.h | 103 +++++++++++
>> drivers/genpd/qcom/cpr.c | 384 +++-------------------------------------
>> 4 files changed, 475 insertions(+), 364 deletions(-)
>>
>> diff --git a/drivers/genpd/qcom/Makefile b/drivers/genpd/qcom/Makefile
>> index 403dfc5af095..b28c8d9128c4 100644
>> --- a/drivers/genpd/qcom/Makefile
>> +++ b/drivers/genpd/qcom/Makefile
>> @@ -1,4 +1,4 @@
>> # SPDX-License-Identifier: GPL-2.0
>> -obj-$(CONFIG_QCOM_CPR) += cpr.o
>> +obj-$(CONFIG_QCOM_CPR) += cpr-common.o cpr.o
>
> Is there a reason for this to be split in two drivers? Would it make
> sense to rewrite this such that the result ends up as a single .ko?
cpr1 is far, far simpler.. I'm not sure if sprinkling millions of ifs
everywhere is worth it
>
> Then you shouldn't need to EXPORT_SYMBOL between the two parts of the
> same "driver".
I suppose it's a balance of code complexity (see /\) vs kernel size
Konrad
next prev parent reply other threads:[~2024-06-18 23:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 11:42 [PATCH v14 0/9] Add support for Core Power Reduction v3, v4 and Hardened Konrad Dybcio
2023-08-28 11:42 ` [PATCH v14 1/9] MAINTAINERS: Add entry for Qualcomm CPRv3/v4/Hardened driver Konrad Dybcio
2023-08-28 11:42 ` [PATCH v14 2/9] dt-bindings: opp: v2-qcom-level: Document CPR3 open/closed loop volt adjustment Konrad Dybcio
2023-08-28 11:42 ` [PATCH v14 3/9] dt-bindings: soc: qcom: cpr3: Add bindings for CPR3 driver Konrad Dybcio
2023-08-29 11:01 ` Ulf Hansson
2023-08-31 16:28 ` Rob Herring
2023-08-31 16:40 ` Konrad Dybcio
2023-08-31 22:02 ` Ulf Hansson
2023-09-09 12:00 ` Konrad Dybcio
2023-08-31 21:47 ` Ulf Hansson
2023-08-28 11:42 ` [PATCH v14 4/9] soc: qcom: cpr: Move common functions to new file Konrad Dybcio
2023-08-29 15:15 ` Bjorn Andersson
2023-09-09 11:59 ` Konrad Dybcio
2024-06-18 23:33 ` Konrad Dybcio [this message]
2023-08-28 11:42 ` [PATCH v14 5/9] soc: qcom: cpr-common: Add support for flat fuse adjustment Konrad Dybcio
2023-08-28 11:42 ` [PATCH v14 6/9] soc: qcom: cpr: Use u64 for frequency Konrad Dybcio
2023-08-28 11:42 ` [PATCH v14 7/9] soc: qcom: cpr-common: Add threads support Konrad Dybcio
2023-08-28 11:42 ` [PATCH v14 8/9] soc: qcom: Add support for Core Power Reduction v3, v4 and Hardened Konrad Dybcio
2023-09-06 10:23 ` Ulf Hansson
2024-06-19 20:07 ` Konrad Dybcio
2023-08-28 11:42 ` [PATCH v14 9/9] arm64: dts: qcom: msm8998: Configure CPRh Konrad Dybcio
2024-06-12 7:53 ` [PATCH v14 0/9] Add support for Core Power Reduction v3, v4 and Hardened Varadarajan Narayanan
2024-06-18 23:58 ` Konrad Dybcio
2024-06-19 7:09 ` Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8cd4691-48fd-42a9-8e4e-e942c4475ddd@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=angelogioacchino.delregno@somainline.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=nks@flawful.org \
--cc=nm@ti.com \
--cc=quic_bjorande@quicinc.com \
--cc=quic_jhugo@quicinc.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=robimarko@gmail.com \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).