Re: [PATCH 1/2] arm64: dts: qcom: sdm630/660: Add CDSP-related nodes

[Nickolay Goppen <setotau@mainlining.org>]

20.10.2025 16:14, Dmitry Baryshkov пишет:
> On Sun, Oct 19, 2025 at 07:27:06PM +0300, Nickolay Goppen wrote:
>> In order to enable CDSP support for SDM660 SoC:
>>   * add shared memory p2p nodes for CDSP
>>   * add CDSP-specific smmu node
>>   * add CDSP peripheral image loader node
>>
>> Memory region for CDSP in SDM660 occupies the same spot as
>> TZ buffer mem defined in sdm630.dtsi (which does not have CDSP).
>> In sdm660.dtsi replace buffer_mem inherited from SDM630 with
>> cdsp_region, which is also larger in size.
>>
>> SDM636 also doesn't have CDSP, so remove inherited from sdm660.dtsi
>> related nodes and add buffer_mem back.
>>
>> Signed-off-by: Nickolay Goppen <setotau@mainlining.org>
>> ---
>>   arch/arm64/boot/dts/qcom/sdm630.dtsi |   2 +-
>>   arch/arm64/boot/dts/qcom/sdm636.dtsi |  14 ++++
>>   arch/arm64/boot/dts/qcom/sdm660.dtsi | 152 +++++++++++++++++++++++++++++++++++
>>   3 files changed, 167 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi
>> index 8b1a45a4e56e..a6a1933229b9 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
>> @@ -563,7 +563,7 @@ modem_smp2p_in: slave-kernel {
>>   		};
>>   	};
>>   
>> -	soc@0 {
>> +	soc: soc@0 {
>>   		#address-cells = <1>;
>>   		#size-cells = <1>;
>>   		ranges = <0 0 0 0xffffffff>;
>> diff --git a/arch/arm64/boot/dts/qcom/sdm636.dtsi b/arch/arm64/boot/dts/qcom/sdm636.dtsi
>> index ae15d81fa3f9..41e4e97f7747 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm636.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm636.dtsi
>> @@ -16,6 +16,20 @@
>>    * be addressed when the aforementioned
>>    * peripherals will be enabled upstream.
>>    */
>> +/delete-node/ &cdsp_pil;
>> +/delete-node/ &cdsp_smmu;
>> +/delete-node/ &cdsp_region;
>> +
>> +/ {
>> +	/delete-node/ smp2p-cdsp;
>> +
>> +	reserved-memory {
>> +		buffer_mem: tzbuffer@94a00000 {
>> +			reg = <0x00 0x94a00000 0x00 0x100000>;
>> +			no-map;
>> +		};
>> +	};
>> +};
> This probably means that we need to invert things and make SDM636
> inherit SDM630 and SDM660 inherit SDM636. Would you mind doing that as a
> part of this patchset?
I'd mind
>>   
>>   &adreno_gpu {
>>   	compatible = "qcom,adreno-509.0", "qcom,adreno";

-- 
Best regards,
Nickolay