devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Johan Hovold <johan+linaro@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/14] arm64: dts: qcom: sc8280xp: drop UFS PHY clock-cells
Date: Tue, 5 Jul 2022 16:06:19 +0300	[thread overview]
Message-ID: <f8e44194-4a9f-be6f-a170-e59757476837@linaro.org> (raw)
In-Reply-To: <20220705114032.22787-10-johan+linaro@kernel.org>

On 05/07/2022 14:40, Johan Hovold wrote:
> The QMP UFS PHY provides more than one symbol clock and would need an
> index to differentiate the clocks, but none of this is described by the
> binding currently.
> 
> Drop the incorrect '#clock-cells' property for now.

Could you please take a glance whether 
https://lore.kernel.org/linux-arm-msm/20220620153956.1723269-2-dmitry.baryshkov@linaro.org/ 
makes a sense to the sc8280xp platform?

> 
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>   arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 345a19a6e874..ce4df4e814fe 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -1447,7 +1447,6 @@ ufs_mem_phy_lanes: phy@1d87400 {
>   				      <0 0x01d87800 0 0x108>,
>   				      <0 0x01d87a00 0 0x1e0>;
>   				#phy-cells = <0>;
> -				#clock-cells = <0>;
>   			};
>   		};
>   
> @@ -1517,7 +1516,6 @@ ufs_card_phy_lanes: phy@1da7400 {
>   				      <0 0x01da7800 0 0x108>,
>   				      <0 0x01da7a00 0 0x1e0>;
>   				#phy-cells = <0>;
> -				#clock-cells = <0>;
>   			};
>   		};
>   


-- 
With best wishes
Dmitry

  reply	other threads:[~2022-07-05 13:44 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-05 11:40 [PATCH 00/14] arm64: dts: qcom: QMP PHY fixes Johan Hovold
2022-07-05 11:40 ` [PATCH 01/14] arm64: dts: qcom: sc7280: drop PCIe PHY clock index Johan Hovold
2022-07-05 11:57   ` Dmitry Baryshkov
2022-07-05 12:42   ` Dmitry Baryshkov
2022-07-05 12:51     ` Johan Hovold
2022-07-05 12:57       ` Dmitry Baryshkov
2022-07-05 11:40 ` [PATCH 02/14] arm64: dts: qcom: sm8250: add missing PCIe PHY clock-cells Johan Hovold
2022-07-05 11:58   ` Dmitry Baryshkov
2022-07-05 12:42   ` Dmitry Baryshkov
2022-07-05 11:40 ` [PATCH 03/14] arm64: dts: qcom: ipq6018: drop USB PHY clock index Johan Hovold
2022-07-05 11:58   ` Dmitry Baryshkov
2022-07-05 11:40 ` [PATCH 04/14] arm64: dts: qcom: ipq8074: " Johan Hovold
2022-07-05 11:58   ` Dmitry Baryshkov
2022-07-05 11:40 ` [PATCH 05/14] arm64: dts: qcom: msm8996: " Johan Hovold
2022-07-05 11:40 ` [PATCH 06/14] arm64: dts: qcom: msm8998: " Johan Hovold
2022-07-05 13:03   ` Dmitry Baryshkov
2022-07-05 13:09   ` Dmitry Baryshkov
2022-07-07  6:46     ` Johan Hovold
2022-07-05 11:40 ` [PATCH 07/14] arm64: dts: qcom: sm8350: " Johan Hovold
2022-07-05 13:04   ` Dmitry Baryshkov
2022-07-05 11:40 ` [PATCH 08/14] arm64: dts: qcom: sm8450: " Johan Hovold
2022-07-05 11:40 ` [PATCH 09/14] arm64: dts: qcom: sc8280xp: drop UFS PHY clock-cells Johan Hovold
2022-07-05 13:06   ` Dmitry Baryshkov [this message]
2022-07-05 11:40 ` [PATCH 10/14] arm64: dts: qcom: sm8250: " Johan Hovold
2022-07-05 11:40 ` [PATCH 11/14] arm64: dts: qcom: sm8450: " Johan Hovold
2022-07-05 11:40 ` [PATCH 12/14] arm64: dts: qcom: msm8996: add missing PCIe " Johan Hovold
2022-07-05 11:40 ` [PATCH 13/14] arm64: dts: qcom: msm8996: use non-empty ranges for PCIe PHYs Johan Hovold
2022-07-05 13:07   ` Dmitry Baryshkov
2022-07-05 11:40 ` [PATCH 14/14] arm64: dts: qcom: msm8996: clean up PCIe PHY node Johan Hovold
2022-07-07  2:46 ` [PATCH 00/14] arm64: dts: qcom: QMP PHY fixes Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8e44194-4a9f-be6f-a170-e59757476837@linaro.org \
    --to=dmitry.baryshkov@linaro.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johan+linaro@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).