devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Middelschulte, Leif" <Leif.Middelschulte@klsmartin.com>
To: "robh@kernel.org" <robh@kernel.org>
Cc: "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>
Subject: Re: [PATCH 03/10] dt-bindings: input: touchscreen: stmpe: add resolution support
Date: Wed, 19 Jun 2019 12:33:47 +0000	[thread overview]
Message-ID: <f90b0a81834f84ecf933ca79c3fd345cbbdf9361.camel@klsmartin.com> (raw)
In-Reply-To: <20190614195507.GA27083@bogus>

Am Freitag, den 14.06.2019, 13:55 -0600 schrieb Rob Herring:
> On Mon, May 27, 2019 at 06:07:29PM +0200, Leif Middelschulte wrote:
> > This documents the support for specifying the screen size in milimeter
> > and its impact on resolution calculation.
> > 
> > Signed-off-by: Leif Middelschulte <
> > leif.middelschulte@klsmartin.com
> > >
> > ---
> >  Documentation/devicetree/bindings/input/touchscreen/stmpe.txt | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/input/touchscreen/stmpe.txt b/Documentation/devicetree/bindings/input/touchscreen/stmpe.txt
> > index 04962e2e1ad0..d20dc5a7d8ad 100644
> > --- a/Documentation/devicetree/bindings/input/touchscreen/stmpe.txt
> > +++ b/Documentation/devicetree/bindings/input/touchscreen/stmpe.txt
> > @@ -39,6 +39,10 @@ Optional properties:
> >  				The given window also affects the value range (limits) set
> >  				within the input subsystem which, in turn, affects
> >  				the input resolution calculation on both axes.
> > +- touchscreen-x-mm	: horizontal length in mm of the touchscreen. It affects
> > +				the input resolution calculation on the horizontal axis.
> > +- touchscreen-y-mm	: vertical length in mm of the touchscreen. It affects
> > +				the input resolution calculation on the vertical axis.
> 
> No need to define this again. Just reference the common definition. If 
> you have any additional constraints, then add them.

I assumed it should not be redefined. I merely wanted to document the implication
this value has on the automatically configured resolution within `abs_info`.
Other drivers might not use it in that way, as the general documentation[0] does not
document such a behavior.

[0] https://www.kernel.org/doc/Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt

> Rob

  reply	other threads:[~2019-06-19 12:33 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-27 16:07 [PATCH 00/10] input: touchscreen: stmpe: ext. features Leif Middelschulte
2019-05-27 16:07 ` [PATCH 01/10] dt-bindings: input: touchscreen: stmpe: add touch window configuration Leif Middelschulte
2019-06-14 19:48   ` Rob Herring
2019-06-19 11:55     ` Middelschulte, Leif
2019-06-19 13:51       ` Rob Herring
2019-06-24 10:33         ` Middelschulte, Leif
2019-05-27 16:07 ` [PATCH 02/10] Input: stmpe-ts - implement touch window configuration support Leif Middelschulte
2019-05-27 16:07 ` [PATCH 03/10] dt-bindings: input: touchscreen: stmpe: add resolution support Leif Middelschulte
2019-06-14 19:55   ` Rob Herring
2019-06-19 12:33     ` Middelschulte, Leif [this message]
2019-05-27 16:07 ` [PATCH 04/10] Input: stmpe-ts - implement " Leif Middelschulte
2019-05-27 16:19 ` [PATCH 05/10] dt-bindings: input: touchscreen: stmpe: add XY mode Leif Middelschulte
2019-05-27 16:19   ` [PATCH 06/10] Input: stmpe-ts - implement XY acquisition mode Leif Middelschulte
2019-05-27 16:19   ` [PATCH 07/10] dt-bindings: input: touchscreen: stmpe: add axes inversion and swap Leif Middelschulte
2019-06-14 19:56     ` Rob Herring
2019-05-27 16:19   ` [PATCH 08/10] Input: stmpe-ts - axes inversion and swapping Leif Middelschulte
2019-05-27 16:19   ` [PATCH 09/10] dt-bindings: input: touchscreen: stmpe: add tracking index Leif Middelschulte
2019-06-14 19:58     ` Rob Herring
2019-06-19 12:47       ` Middelschulte, Leif
2019-06-19 13:46         ` Rob Herring
2019-06-24 11:44           ` Middelschulte, Leif
2019-06-14 19:55   ` [PATCH 05/10] dt-bindings: input: touchscreen: stmpe: add XY mode Rob Herring
2019-05-27 16:22 ` [PATCH 10/10] Input: stmpe-ts - implement tracking index Leif Middelschulte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f90b0a81834f84ecf933ca79c3fd345cbbdf9361.camel@klsmartin.com \
    --to=leif.middelschulte@klsmartin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).