From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 3/4] ARM: dts: add fimc support in exynos4412 TOPEET iTop Elite board Date: Tue, 30 Aug 2016 09:33:41 +0200 Message-ID: References: <1472383269-3126-1-git-send-email-ayaka@soulik.info> <1472383269-3126-4-git-send-email-ayaka@soulik.info> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <1472383269-3126-4-git-send-email-ayaka@soulik.info> Sender: linux-samsung-soc-owner@vger.kernel.org To: Randy Li , devicetree@vger.kernel.org Cc: mark.rutland@arm.com, linux@armlinux.org.uk, kgene@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, robh@kernel.org List-Id: devicetree@vger.kernel.org On 08/28/2016 01:21 PM, Randy Li wrote: > The is not used for camera, I enabled it just for a colorspace > convertor. > > Signed-off-by: Randy Li > --- > arch/arm/boot/dts/exynos4412-itop-elite.dts | 16 ++++++++++++++++ This should be squashed with patch #2. BTW, please add also vendor prefix (Documentation/devicetree/bindings/vendor-prefixes.txt). Best regards, Krzysztof > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts > index 5688589..2d11b9a 100644 > --- a/arch/arm/boot/dts/exynos4412-itop-elite.dts > +++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts > @@ -82,6 +82,14 @@ > pinctrl-0 = <&pwm0_out>; > pinctrl-names = "default"; > }; > + > + camera: camera { > + pinctrl-0 = <&cam_port_a_clk_active>; > + pinctrl-names = "default"; > + status = "okay"; > + assigned-clocks = <&clock CLK_MOUT_CAM0>; > + assigned-clock-parents = <&clock CLK_XUSBXTI>; > + }; > }; > > &pinctrl_1 { > @@ -146,3 +154,11 @@ > vdd-supply = <&ldo3_reg>; > status = "okay"; > }; > + > +&fimc_0 { > + status = "okay"; > + assigned-clocks = <&clock CLK_MOUT_FIMC0>, > + <&clock CLK_SCLK_FIMC0>; > + assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>; > + assigned-clock-rates = <0>, <176000000>; > +}; >