From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Yan Subject: Re: [PATCH v3 10/13] ARM: dts: rockchip: add saradc support for rv1108 Date: Mon, 14 Aug 2017 09:42:23 +0800 Message-ID: References: <1502422578-30611-1-git-send-email-andy.yan@rock-chips.com> <1502423211-31216-1-git-send-email-andy.yan@rock-chips.com> <2309743.33rDFhBfGp@phil> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <2309743.33rDFhBfGp@phil> Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Heiko Stuebner Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, David Wu List-Id: devicetree@vger.kernel.org Hi Heiko: On 2017年08月13日 20:13, Heiko Stuebner wrote: > Hi Andy, > > Am Freitag, 11. August 2017, 11:46:51 CEST schrieb Andy Yan: >> Add saradc device tree node for rv1108 soc >> >> Signed-off-by: Andy Yan >> >> + adc: adc@1038c000 { >> + compatible = "rockchip,rv1108-saradc", "rockchip,rk3399-saradc"; >> + reg = <0x1038c000 0x100>; >> + interrupts = ; >> + #io-channel-cells = <1>; >> + io-channel-ranges; > What do you need the io-channel-ranges for? > I.e. according to the documenation it is meant for when the adc is also > a "bus node" and has children that should inherit channels from it. > > In all saradc uses so far we only have separate nodes referencing the > adc controller (like adc-keys etc), so this does not look like it is needed? Sorry, I just copied it from the downstream dts. After checked with David, he suggested that we could remove it. > > > Heiko > > > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html