From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D998DEB8FB6 for ; Wed, 6 Sep 2023 12:07:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232358AbjIFMHT (ORCPT ); Wed, 6 Sep 2023 08:07:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240526AbjIFMHR (ORCPT ); Wed, 6 Sep 2023 08:07:17 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA1B0E7C for ; Wed, 6 Sep 2023 05:07:11 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-99c3c8adb27so540439566b.1 for ; Wed, 06 Sep 2023 05:07:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694002030; x=1694606830; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lN2c1KyWvKHcTm1k3i62r7qxVaKPijkE6ztFuzbNYrk=; b=JRG8VvryopGLw06kiDxMiIyedZVh9VHkBB6XA/lJC64o0WKxoOrQTzSaZVXmkQX/L0 MdJ/N7Cx/SFVHaLxdPafEsdrSygd7fZSvT7WQnAbAiyr0xINhAjiev3heUEjk92zSTA1 8e/ScUZqGAUflOb2PPYKChFHD3RDSb+dhILhoMOq1TKR2IN+sMQA45pgjbD5PZy1CJo+ qoLaBMPPLAnhtRW1uCDbeIYpyLCaTazjGBDKJZEZHxmxip932NIU4OlEUL38EQIVQvok 30XTBDeUaKsheZTkjCpkUubvDTwpeuHmmud+7TdIqXJsbwpwvWtd/2xd027tENzOey94 94JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694002030; x=1694606830; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lN2c1KyWvKHcTm1k3i62r7qxVaKPijkE6ztFuzbNYrk=; b=jkmi9JiknZFV9PyCCNfVD9HnEIs2rKNjHQm09HG6UnuqxGnvEpwP/roX5pbNXlSNqp ElN4Bl7XzaZJxzWkI2193NVLMTNa+vgNzD6aiALSt1o9j3F4oMsr2EIuXSf7kT6sv+st 2OffD3un4mR5CHJOjk67dI6H0wGOwiyyOPP21n+6TEYbhDJF0m+BP1tStHdknjdMqStK e7A8/kLvaL+cwALlVGskket6ElohvSvtW/HSSVAS4DIFPdfxZSZFfj6m8bZhbNhQdjgF ePUQNeZCadQg8LYKvRQGk1PNJgwOyeLzcOv4XMCizyqYbpBPfR6byPBSPy0CyLyY/hxw qD0w== X-Gm-Message-State: AOJu0Yw6O+VRd1izScl5AwnOSyO7nPDiWFuhei+3QHp1lshqXfDOYSKs 7a+9U3Sb1nnEd5oP/A8gzKve5A== X-Google-Smtp-Source: AGHT+IHJfbVrGJePtKRmWGH+Rf/URoeWAjUMKQEAGvIkJmBDE3Cz0c5mLQGy7wMe8VBLG5OKszsq9Q== X-Received: by 2002:a17:906:53cb:b0:9a1:e8c0:7e2e with SMTP id p11-20020a17090653cb00b009a1e8c07e2emr2252232ejo.14.1694002030288; Wed, 06 Sep 2023 05:07:10 -0700 (PDT) Received: from [192.168.37.154] (178235177204.dynamic-4-waw-k-1-1-0.vectranet.pl. [178.235.177.204]) by smtp.gmail.com with ESMTPSA id c11-20020a170906924b00b009929ab17be0sm8919427ejx.162.2023.09.06.05.07.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Sep 2023 05:07:09 -0700 (PDT) Message-ID: Date: Wed, 6 Sep 2023 14:07:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] arm64: dts: qcom: sm8550-mtp: use correct UFS supply Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230906104744.163479-1-krzysztof.kozlowski@linaro.org> <9c7fae56-85a2-4691-8192-24237761d25c@linaro.org> <91f74079-1be3-4c66-9942-cb02c96c8848@linaro.org> <8197d5c6-bd05-ff16-59d5-ba3eb06a5921@linaro.org> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <8197d5c6-bd05-ff16-59d5-ba3eb06a5921@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 6.09.2023 14:05, Krzysztof Kozlowski wrote: > On 06/09/2023 13:50, Konrad Dybcio wrote: >> On 6.09.2023 13:39, Krzysztof Kozlowski wrote: >>> On 06/09/2023 13:28, Konrad Dybcio wrote: >>>> On 6.09.2023 12:47, Krzysztof Kozlowski wrote: >>>>> According to schematics the VCCQ2 supply is not connected and the L3G >>>>> regulator instead powers up the controller pads (VDD_PX10). Use correct >>>>> supply vdd-hba and drop unsupported current limit for the vdd-hba. >>>> Why is it unsupported? >>> >>> Maybe I was here not precise. I move the regulator from vccq2 to >>> vdd-hba. vccq2 has control of current in UFS core driver. Bindings also >>> allow it. >> Looks like the bindings are out of sync with the driver. >> >> ufshcd_populate_vreg() which parses current is used for both vccq2 >> and vdd-hba. > > Just for convenience. The current is not used for vdd-hba. Also: > > https://lore.kernel.org/all/20230906113302.201888-1-krzysztof.kozlowski@linaro.org/ I see, you're right. Reviewed-by: Konrad Dybcio Konrad