From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4425C00144 for ; Fri, 29 Jul 2022 11:33:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235074AbiG2LdH (ORCPT ); Fri, 29 Jul 2022 07:33:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232959AbiG2LdH (ORCPT ); Fri, 29 Jul 2022 07:33:07 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BE032AE13 for ; Fri, 29 Jul 2022 04:33:05 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id w15so6864838lft.11 for ; Fri, 29 Jul 2022 04:33:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=T3lyyxd0KP2STslbGMoYEWzFv8XZ5XnehzpgSY0LnyI=; b=P+CKl8Vclb7nppRLsuEQ4KbidbQV2Ruu443ArQM94iKZAkxacw3raTwYOEI0bzdcEA A9f7HiLkW4aSpW9eFi/C7uIOFaP3VViEKS0EVnkM2vvgeZp3oODP1pEwCYpsZtoO06gd OAmTY482BkwlvshK8K9khx5/OkUSSWEMwENv5IBoPZgwN/Td/ceiM+FcTx9g8/yFR7DJ RNwaN9vhx3888pB6AJyE7avLmiQT5NeldP5auJRl0+YVjl1kDVn6esYy1D+pRAGY7+j+ 7W+M8RuHHhz6iL27tvQnY0+GWGNlzt1n5Ul7XmIz9/Gsa6vQGwBzp6L0362zrqBKm2Wi WRyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=T3lyyxd0KP2STslbGMoYEWzFv8XZ5XnehzpgSY0LnyI=; b=4axEChS674MMNOqZazkFCH2FJdihT42W3sWRVjO8wHNcLwIBBW772wHOQEwPV1CERT 4CMj5pNEq61NCRy8Pl68xjo8QJKGYyUybNP6Wl5cf0OBFHAm8VfVHkac6p0K8bIP79aE lsaqSEupBxZjQoHRzpspVxX96VWtdEg5nLsLEhjPGmtpBLVQTPKGsRb+YSKTqZxCjt3n u4mcxH2jw0Edank2/IJfZTkZItSgWFQ05Wtu3aMm1EzsHZ+oosFbMSMdyGedn7EwpewI jujgcKswvRpfieE3Uc6es1cyDjzcjNiyX8COCt6NfQn4F9E+Xxi77Y4HjPRUL51jESjN OIKg== X-Gm-Message-State: ACgBeo1P8dnvFN41BHCsVwVW2X5P9UxiNSpfuSc1BFCMrUiy+Ncqi2IY alyUOC00UNTvZGMH50YeC/QSZQ== X-Google-Smtp-Source: AA6agR6JOOke7r3XaAOM3ixhkIu9pO6CxBd+pt5kplHnHvvUAtmQNHvEfUPP/0ZIFYZt4+gi5HzCaA== X-Received: by 2002:a05:6512:3b3:b0:48a:e4d5:e77a with SMTP id v19-20020a05651203b300b0048ae4d5e77amr371426lfp.247.1659094383912; Fri, 29 Jul 2022 04:33:03 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id q19-20020a05651c055300b0025e15fe421bsm620540ljp.17.2022.07.29.04.33.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Jul 2022 04:33:03 -0700 (PDT) Message-ID: Date: Fri, 29 Jul 2022 14:33:02 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/3] ARM: dts: qcom: msm8960: add reference to sleep_clk Content-Language: en-GB To: Krzysztof Kozlowski , Shinjo Park Cc: David Heidelberg , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220728111603.30503-1-peremen@gmail.com> <66e15d42-96fd-5b02-b7c8-a284d3f8d21f@linaro.org> From: Dmitry Baryshkov In-Reply-To: <66e15d42-96fd-5b02-b7c8-a284d3f8d21f@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/07/2022 14:51, Krzysztof Kozlowski wrote: > On 28/07/2022 13:16, Shinjo Park wrote: >> Change the reference of sleep_clk to the same as qcom-apq8064.dtsi. > > You add label, not change something. > >> >> Signed-off-by: Shinjo Park >> Reviewed-by: David Heidelberg >> --- >> arch/arm/boot/dts/qcom-msm8960.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi >> index e8cd1c9c0..991eb1948 100644 >> --- a/arch/arm/boot/dts/qcom-msm8960.dtsi >> +++ b/arch/arm/boot/dts/qcom-msm8960.dtsi >> @@ -71,7 +71,7 @@ pxo_board: pxo_board { >> clock-output-names = "pxo_board"; >> }; >> >> - sleep_clk { >> + sleep_clk: sleep_clk { > > Since you touch the line, make the device node sleep-clk (device node > names should not have underscores) and mention this in commit msg. Then we are back to the compat issues, since the gcc expects the 'sleep_clk' clock. -- With best wishes Dmitry