From: Dinh Nguyen <dinguyen@kernel.org>
To: thor.thayer@linux.intel.com, bp@alien8.de, robh+dt@kernel.org,
mark.rutland@arm.com, mchehab@kernel.org
Cc: devicetree@vger.kernel.org, linux-edac@vger.kernel.org
Subject: Re: [PATCH 1/4] EDAC, altera: Fix S10 persistent register offset
Date: Thu, 17 Jan 2019 08:52:20 -0600 [thread overview]
Message-ID: <f9365fd8-284c-eab8-b22e-df803d4189a5@kernel.org> (raw)
In-Reply-To: <1547680314-31045-2-git-send-email-thor.thayer@linux.intel.com>
On 1/16/19 5:11 PM, thor.thayer@linux.intel.com wrote:
> From: Thor Thayer <thor.thayer@linux.intel.com>
>
> Correct the persistent register offset where address
> and status are stored.
>
> Fixes: 08f08bfb7b4c ("EDAC, altera: Merge Stratix10 into the Arria10 SDRAM
> probe routine")
The "Fixes" line should be all on one line. I recently got dinged for this.
>From Documentation/process/submitting-patches.rst"
"If your patch fixes a bug in a specific commit, e.g. you found an issue
using
``git bisect``, please use the 'Fixes:' tag with the first 12 characters of
the SHA-1 ID, and the one line summary. For example::
Fixes: e21d2170f366 ("video: remove unnecessary platform_set_drvdata()")"
Dinh
next prev parent reply other threads:[~2019-01-17 14:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 23:11 [PATCH 0/4] Stratix10 EDAC Improvements thor.thayer
2019-01-16 23:11 ` [PATCH 1/4] EDAC, altera: Fix S10 persistent register offset thor.thayer
2019-01-17 14:52 ` Dinh Nguyen [this message]
2019-01-17 15:36 ` Thor Thayer
2019-01-16 23:11 ` [PATCH 2/4] EDAC, altera: Less Intrusive Error Injection thor.thayer
2019-01-16 23:11 ` [PATCH 3/4] EDAC, altera: Add Stratix10 OCRAM ECC support thor.thayer
2019-01-16 23:11 ` [PATCH 4/4] arm64: dts: stratix10: Add OCRAM EDAC node thor.thayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9365fd8-284c-eab8-b22e-df803d4189a5@kernel.org \
--to=dinguyen@kernel.org \
--cc=bp@alien8.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=thor.thayer@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).