From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16347C4332F for ; Fri, 11 Nov 2022 08:07:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232988AbiKKIHI (ORCPT ); Fri, 11 Nov 2022 03:07:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233172AbiKKIHD (ORCPT ); Fri, 11 Nov 2022 03:07:03 -0500 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA4F87B20B for ; Fri, 11 Nov 2022 00:07:01 -0800 (PST) Received: by mail-lj1-x232.google.com with SMTP id k19so3693679lji.2 for ; Fri, 11 Nov 2022 00:07:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+mkzKjBuFZVxWFYVZhmqUgcCDnGk48wQCYb/s+p35qY=; b=Tz5FxPyQ0APcNSPQO8m2UshMmrkw8YyG6iSDyP5DPQ3fV+Cx0uSxjLzZXgRXi2C1BP uosjby10Q5I5irZ19ktKzGBjvdAvgSpPGBKpyRnIyAo2ZVJUUhMQ5zGJ0TTd0Oi2AM0c r8wt9R0OlCDPwkDKIkKDEvFrun+yAOKRpyJXfNPf7Znj5Qg3JcavNQs6cy4XtSMvQOYP nIel5cdzzounNakIs1TykzouFPCL66FgGamKu/oFdoaWOXBDoCmOLhSI/3aS7mM+eP9C vrEM7SpX3H5+QsIjNV13IPRbW2DzJHQ89pYqV0671FLmYZ34O2gAUKqIPZ/NFWOYI0Tn y8wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+mkzKjBuFZVxWFYVZhmqUgcCDnGk48wQCYb/s+p35qY=; b=lEouuGxMkNM/AtT9VTA+BXAm/Z8Mw1wJJFftSVnoBM2YgxGrnJDiD23LIFcilrPYLm roiJ1BEY9L7GzfMryybZLujxlOPOk0TInuIbYOkFnKzSPSYkk5xYTcYqu2asCEtzFIeR q9cRuG+pJf+n7S56ZX9A5FrIX4LSE8+r/8jiDKOL/nMZ97SBThF6IavHALj0c4VhI090 H232lHQHlePay4fgjn2tqdu0RHJYIoAF1oiFp0tq9CtlDHdwtr9pHERRPXNh29FpJdkG kvJWVn1+tY7rto9M8rpgQITbjIO6S+wFZMqo4FOX1jTAR8tX61FjZHwNCeRzBtRGpv8b idjg== X-Gm-Message-State: ANoB5pmkSXIUDE22EBbGper/PmTZQWNF+LhDA00lCP6AfYvYoJG5Lb3U uq+IdHJq488BzGW1cjXk1WDWHg== X-Google-Smtp-Source: AA0mqf63SqS7ZqAUKWocEvIHorXccj0gv44etPdKlJ5a+yrR9ajMorvmQBvpA5YbabRYlRqL9FeQXg== X-Received: by 2002:a2e:be23:0:b0:277:6fea:ac19 with SMTP id z35-20020a2ebe23000000b002776feaac19mr293000ljq.83.1668154019845; Fri, 11 Nov 2022 00:06:59 -0800 (PST) Received: from [192.168.0.20] (088156142199.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.199]) by smtp.gmail.com with ESMTPSA id b27-20020a19671b000000b004b40c1f1c70sm204666lfc.212.2022.11.11.00.06.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Nov 2022 00:06:59 -0800 (PST) Message-ID: Date: Fri, 11 Nov 2022 09:06:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [Patch v3 1/3] media: dt-bindings: s5p-mfc: Add new compatible string for Exynos3250 SoC. Content-Language: en-US To: Aakarsh Jain , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: m.szyprowski@samsung.com, andrzej.hajda@intel.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, ezequiel@vanguardiasur.com.ar, jernej.skrabec@gmail.com, benjamin.gaignard@collabora.com, krzysztof.kozlowski+dt@linaro.org, stanimir.varbanov@linaro.org, dillon.minfei@gmail.com, david.plowman@raspberrypi.com, mark.rutland@arm.com, robh+dt@kernel.org, krzk+dt@kernel.org, andi@etezian.org, alim.akhtar@samsung.com, aswani.reddy@samsung.com, pankaj.dubey@samsung.com, smitha.t@samsung.com References: <20221111032337.79219-1-aakarsh.jain@samsung.com> <20221111032337.79219-2-aakarsh.jain@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20221111032337.79219-2-aakarsh.jain@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/11/2022 04:23, Aakarsh Jain wrote: > Since,MFC v7 support was added for Exynos5420 and Exynos > 3250 SoC with same compatible string "samsung,mfc-v7".As > both SoCs having different hardware properties and having > same compatible string for both SoCs doesn't seems to be correct. > New compatible is added for Exynos3250 SOC which will > differentiate the node properties for both SoCs which > support MFC v7. Subject: Drop full stop from subject. Commit: This is not correct formatting, nor wrapping. In English after every comma or full stop there is a space. Please wrap commit message according to Linux coding style / submission process: https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 Not "is added" but just "Add new compatible" https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 But what is more important: > > Reviewed-by: Tommaso Merciai > Suggested-by: Alim Akhtar > Signed-off-by: Aakarsh Jain > --- > Documentation/devicetree/bindings/media/s5p-mfc.txt | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > We are already in process of converting this txt file to yaml. > https://patchwork.kernel.org/project/linux-media/patch/20221011122516.32135-2-aakarsh.jain@samsung.com/ > Modifying this txt binding for completeness. > > diff --git a/Documentation/devicetree/bindings/media/s5p-mfc.txt b/Documentation/devicetree/bindings/media/s5p-mfc.txt > index aa54c8159d9f..cb166654fa81 100644 > --- a/Documentation/devicetree/bindings/media/s5p-mfc.txt > +++ b/Documentation/devicetree/bindings/media/s5p-mfc.txt > @@ -10,10 +10,11 @@ Required properties: > - compatible : value should be either one among the following > (a) "samsung,mfc-v5" for MFC v5 present in Exynos4 SoCs > (b) "samsung,mfc-v6" for MFC v6 present in Exynos5 SoCs > - (c) "samsung,mfc-v7" for MFC v7 present in Exynos5420 SoC > - (d) "samsung,mfc-v8" for MFC v8 present in Exynos5800 SoC > - (e) "samsung,exynos5433-mfc" for MFC v8 present in Exynos5433 SoC > - (f) "samsung,mfc-v10" for MFC v10 present in Exynos7880 SoC > + (c) "samsung,exynos3250-mfc" for MFC v7 present in Exynos3250 SoC > + (d) "samsung,mfc-v7" for MFC v7 present in Exynos5420 SoC > + (e) "samsung,mfc-v8" for MFC v8 present in Exynos5800 SoC > + (f) "samsung,exynos5433-mfc" for MFC v8 present in Exynos5433 SoC > + (g) "samsung,mfc-v10" for MFC v10 present in Exynos7880 SoC I don't see here any improvements about which I commented since v1. Best regards, Krzysztof