From: Sameer Pujar <spujar@nvidia.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
thierry.reding@gmail.com, jonathanh@nvidia.com,
oder_chiou@realtek.com, broonie@kernel.org
Cc: perex@perex.cz, tiwai@suse.com, lgirdwood@gmail.com,
kuninori.morimoto.gx@renesas.com, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/2] arm64: tegra: Audio codec support on Jetson AGX Orin
Date: Fri, 10 Feb 2023 14:32:07 +0530 [thread overview]
Message-ID: <f967b1b3-25c7-9c81-192e-82ff9f25113e@nvidia.com> (raw)
In-Reply-To: <9570b0fb-1fe2-00fe-e224-229752f26a9a@linaro.org>
On 10-02-2023 14:15, Krzysztof Kozlowski wrote:
> On 09/02/2023 15:36, Sameer Pujar wrote:
>> Jetson AGX Orin has onboard RT5640 audio codec. This patch adds the
>> codec device node and the bindings to I2S1 interface.
>>
>> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
>> ---
>> .../dts/nvidia/tegra234-p3737-0000+p3701-0000.dts | 47 +++++++++++++++++++++-
>> 1 file changed, 46 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
>> index 8a97478..5881fbf 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
>> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
>> @@ -3,6 +3,7 @@
>>
>> #include <dt-bindings/input/linux-event-codes.h>
>> #include <dt-bindings/input/gpio-keys.h>
>> +#include <dt-bindings/sound/rt5640.h>
>>
>> #include "tegra234-p3701-0000.dtsi"
>> #include "tegra234-p3737-0000.dtsi"
>> @@ -49,7 +50,7 @@
>>
>> i2s1_dap: endpoint {
>> dai-format = "i2s";
>> - /* placeholder for external codec */
>> + remote-endpoint = <&rt5640_ep>;
>> };
>> };
>> };
>> @@ -2017,6 +2018,32 @@
>> status = "okay";
>> };
>>
>> + i2c@31e0000 {
>> + status = "okay";
>> +
>> + audio-codec@1c {
>> + status = "okay";
> Are you sure you need this?
I can drop this in v2 as it would be the default state and it is not
disabled anywhere else. Thanks.
next prev parent reply other threads:[~2023-02-10 9:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 14:36 [PATCH 0/2] Codec support on Jetson AGX Orin Sameer Pujar
2023-02-09 14:36 ` [PATCH 1/2] ASoC: rt5640: Update MCLK rate in set_sysclk() Sameer Pujar
2023-02-09 23:42 ` Kuninori Morimoto
2023-02-10 8:30 ` Sameer Pujar
2023-02-12 23:56 ` Kuninori Morimoto
2023-02-09 14:36 ` [PATCH 2/2] arm64: tegra: Audio codec support on Jetson AGX Orin Sameer Pujar
2023-02-10 8:45 ` Krzysztof Kozlowski
2023-02-10 9:02 ` Sameer Pujar [this message]
2023-02-09 18:36 ` (subset) [PATCH 0/2] Codec " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f967b1b3-25c7-9c81-192e-82ff9f25113e@nvidia.com \
--to=spujar@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).