From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Sebastian Reichel <sre@kernel.org>
Cc: Tony Lindgren <tony@atomide.com>,
devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/7] dt-bindings: hsi: hsi-client: convert to YAML
Date: Thu, 28 Mar 2024 10:27:28 +0100 [thread overview]
Message-ID: <f96e14dd-a570-47e9-ad92-b71cfc2c494e@linaro.org> (raw)
In-Reply-To: <20240327-hsi-dt-binding-v2-1-110fab4c32ae@collabora.com>
On 27/03/2024 20:11, Sebastian Reichel wrote:
> Convert the legacy txt binding to modern YAML and rename from
> client-devices to hsi-client. Also the example got dropped,
> since this is a shared schema. No semantic change in the binding
> itself.
>
...
> +allOf:
> + - if:
> + required:
> + - hsi-mode
> + then:
> + properties:
> + hsi-rx-mode: false
> + hsi-tx-mode: false
> + - if:
> + required:
> + - hsi-rx-mode
> + then:
> + properties:
> + hsi-mode: false
Why do you still have this allOf? The point I was trying to make last
time, was that all your efforts to mutually exclude these properties can
be achieved with that one simple oneOf. That's why I linked you other
schemas as an example how to achieve this.
Could be that I miss here something, so why do you exactly need this allOf?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-28 9:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 19:11 [PATCH v2 0/7] Convert MIPI HSI DT bindings to YAML Sebastian Reichel
2024-03-27 19:11 ` [PATCH v2 1/7] dt-bindings: hsi: hsi-client: convert " Sebastian Reichel
2024-03-28 9:27 ` Krzysztof Kozlowski [this message]
2024-03-27 19:11 ` [PATCH v2 2/7] dt-bindings: hsi: nokia-modem: " Sebastian Reichel
2024-03-28 9:28 ` Krzysztof Kozlowski
2024-03-27 19:11 ` [PATCH v2 3/7] dt-bindings: hsi: omap-ssi: " Sebastian Reichel
2024-03-28 9:30 ` Krzysztof Kozlowski
2024-03-27 19:11 ` [PATCH v2 4/7] ARM: dts: omap4: fix hsi-port node name Sebastian Reichel
2024-03-28 9:30 ` Krzysztof Kozlowski
2024-03-27 19:11 ` [PATCH v2 5/7] ARM: dts: omap3: fix ssi-port " Sebastian Reichel
2024-03-28 9:30 ` Krzysztof Kozlowski
2024-03-27 19:11 ` [PATCH v2 6/7] ARM: dts: omap3: fix ti,ssi-cawake-gpio property name Sebastian Reichel
2024-03-28 9:30 ` Krzysztof Kozlowski
2024-03-27 19:11 ` [PATCH v2 7/7] ARM: dts: omap3: use generic node name for hsi clients Sebastian Reichel
2024-03-28 9:31 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f96e14dd-a570-47e9-ad92-b71cfc2c494e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox