From: Steen Hegelund <steen.hegelund@microchip.com>
To: Herve Codina <herve.codina@bootlin.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
"Simon Horman" <horms@kernel.org>, Lee Jones <lee@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Derek Kiernan <derek.kiernan@amd.com>,
Dragan Cvetic <dragan.cvetic@amd.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Lars Povlsen <lars.povlsen@microchip.com>,
Daniel Machon <daniel.machon@microchip.com>,
<UNGLinuxDriver@microchip.com>, Rob Herring <robh@kernel.org>,
Saravana Kannan <saravanak@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Horatiu Vultur" <horatiu.vultur@microchip.com>,
"Andrew Lunn" <andrew@lunn.ch>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org,
"Allan Nielsen" <allan.nielsen@microchip.com>,
"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Clément Léger" <clement.leger@bootlin.com>
Subject: Re: [PATCH v4 8/8] reset: mchp: sparx5: set the dev member of the reset controller
Date: Thu, 8 Aug 2024 10:22:23 +0200 [thread overview]
Message-ID: <f97296c967211a6a8f6f40996e3ed74b76bad935.camel@microchip.com> (raw)
In-Reply-To: <20240805101725.93947-9-herve.codina@bootlin.com>
Hi Herve,
On Mon, 2024-08-05 at 12:17 +0200, Herve Codina wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
>
> From: Clément Léger <clement.leger@bootlin.com>
>
> In order to guarantee the device will not be deleted by the reset
> controller consumer, set the dev member of the reset controller.
>
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> ---
> drivers/reset/reset-microchip-sparx5.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/reset/reset-microchip-sparx5.c
> b/drivers/reset/reset-microchip-sparx5.c
> index c4fe65291a43..1ef2aa1602e3 100644
> --- a/drivers/reset/reset-microchip-sparx5.c
> +++ b/drivers/reset/reset-microchip-sparx5.c
> @@ -117,6 +117,7 @@ static int mchp_sparx5_reset_probe(struct
> platform_device *pdev)
> return err;
>
> ctx->rcdev.owner = THIS_MODULE;
> + ctx->rcdev.dev = &pdev->dev;
> ctx->rcdev.nr_resets = 1;
> ctx->rcdev.ops = &sparx5_reset_ops;
> ctx->rcdev.of_node = dn;
> --
> 2.45.0
>
Looks good to me.
Reviewed-by: Steen Hegelund <Steen.Hegelund@microchip.com>
BR
Steen
prev parent reply other threads:[~2024-08-08 8:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 10:17 [PATCH v4 0/8] Add support for the LAN966x PCI device using a DT overlay Herve Codina
2024-08-05 10:17 ` [PATCH v4 1/8] misc: Add support for LAN966x PCI device Herve Codina
2024-08-05 20:13 ` Andy Shevchenko
2024-08-07 10:09 ` Herve Codina
2024-08-08 12:32 ` Andy Shevchenko
2024-08-08 14:07 ` Herve Codina
2024-08-05 10:17 ` [PATCH v4 2/8] MAINTAINERS: Add the Microchip LAN966x PCI driver entry Herve Codina
2024-08-05 10:17 ` [PATCH v4 3/8] mfd: syscon: Add reference counting and device managed support Herve Codina
2024-08-05 20:20 ` Andy Shevchenko
2024-08-07 13:29 ` Herve Codina
2024-08-05 10:17 ` [PATCH v4 4/8] reset: mchp: sparx5: Add MCHP_LAN966X_PCI dependency Herve Codina
2024-08-07 7:57 ` Steen Hegelund
2024-08-05 10:17 ` [PATCH v4 5/8] reset: mchp: sparx5: Allow building as a module Herve Codina
2024-08-07 9:14 ` Steen Hegelund
2024-08-05 10:17 ` [PATCH v4 6/8] reset: mchp: sparx5: Release syscon when not use anymore Herve Codina
2024-08-07 9:48 ` Steen Hegelund
2024-08-05 10:17 ` [PATCH v4 7/8] reset: core: add get_device()/put_device on rcdev Herve Codina
2024-08-05 10:17 ` [PATCH v4 8/8] reset: mchp: sparx5: set the dev member of the reset controller Herve Codina
2024-08-08 8:22 ` Steen Hegelund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f97296c967211a6a8f6f40996e3ed74b76bad935.camel@microchip.com \
--to=steen.hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=allan.nielsen@microchip.com \
--cc=andrew@lunn.ch \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=clement.leger@bootlin.com \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=derek.kiernan@amd.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@amd.com \
--cc=edumazet@google.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=herve.codina@bootlin.com \
--cc=horatiu.vultur@microchip.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).