[PATCH v3 1/2] hwmon: Add driver for MPS MPQ8785 Synchronous Step-Down Converter

[PATCH v3 1/2] hwmon: Add driver for MPS MPQ8785 Synchronous Step-Down Converter

[Charles Hsu]

Add support for mpq8785 device from Monolithic Power Systems, Inc.
(MPS) vendor. This is synchronous step-down controller.

Signed-off-by: Charles Hsu <ythsu0511@gmail.com>

---
Change in v1:
    Initial patchset.
Change in v2:
    1.Add pmbus support status registers.
    2.Add mpq8785 in trivial-devices.yaml.
    3.Remove format[PSC_VOLTAGE_OUT].
    4.Fix MODULE_DESCRIPTION.
Change in v3:
    1.Identify vout_mode.
    2.Separate dt-binding.
---
 Documentation/hwmon/index.rst   |  1 +
 Documentation/hwmon/mpq8785.rst | 94 +++++++++++++++++++++++++++++++++
 drivers/hwmon/pmbus/Kconfig     |  9 ++++
 drivers/hwmon/pmbus/Makefile    |  1 +
 drivers/hwmon/pmbus/mpq8785.c   | 91 +++++++++++++++++++++++++++++++
 5 files changed, 196 insertions(+)
 create mode 100644 Documentation/hwmon/mpq8785.rst
 create mode 100644 drivers/hwmon/pmbus/mpq8785.c

diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst
index c7ed1f73ac06..085ad6ca9b05 100644
--- a/Documentation/hwmon/index.rst
+++ b/Documentation/hwmon/index.rst
@@ -163,6 +163,7 @@ Hardware Monitoring Kernel Drivers
    mp2975
    mp5023
    mp5990
+   mpq8785
    nct6683
    nct6775
    nct7802
diff --git a/Documentation/hwmon/mpq8785.rst b/Documentation/hwmon/mpq8785.rst
new file mode 100644
index 000000000000..bf8176b87086
--- /dev/null
+++ b/Documentation/hwmon/mpq8785.rst
@@ -0,0 +1,94 @@
+.. SPDX-License-Identifier: GPL-2.0-only
+
+Kernel driver mpq8785
+=======================
+
+Supported chips:
+
+  * MPS MPQ8785
+
+    Prefix: 'mpq8785'
+
+Author: Charles Hsu <ythsu0511@gmail.com>
+
+Description
+-----------
+
+The MPQ8785 is a fully integrated, PMBus-compatible, high-frequency, synchronous
+buck converter. The MPQ8785 offers a very compact solution that achieves up to
+40A output current per phase, with excellent load and line regulation over a
+wide input supply range. The MPQ8785 operates at high efficiency over a wide
+output current load range.
+
+The PMBus interface provides converter configurations and key parameters
+monitoring.
+
+The MPQ8785 adopts MPS's proprietary multi-phase digital constant-on-time (MCOT)
+control, which provides fast transient response and eases loop stabilization.
+The MCOT scheme also allows multiple MPQ8785 devices to be connected in parallel
+with excellent current sharing and phase interleaving for high-current
+applications.
+
+Fully integrated protection features include over-current protection (OCP),
+over-voltage protection (OVP), under-voltage protection (UVP), and
+over-temperature protection (OTP).
+
+The MPQ8785 requires a minimal number of readily available, standard external
+components, and is available in a TLGA (5mmx6mm) package.
+
+Device compliant with:
+
+- PMBus rev 1.3 interface.
+
+The driver exports the following attributes via the 'sysfs' files
+for input voltage:
+
+**in1_input**
+
+**in1_label**
+
+**in1_max**
+
+**in1_max_alarm**
+
+**in1_min**
+
+**in1_min_alarm**
+
+**in1_crit**
+
+**in1_crit_alarm**
+
+The driver provides the following attributes for output voltage:
+
+**in2_input**
+
+**in2_label**
+
+**in2_alarm**
+
+The driver provides the following attributes for output current:
+
+**curr1_input**
+
+**curr1_label**
+
+**curr1_max**
+
+**curr1_max_alarm**
+
+**curr1_crit**
+
+**curr1_crit_alarm**
+
+The driver provides the following attributes for temperature:
+
+**temp1_input**
+
+**temp1_max**
+
+**temp1_max_alarm**
+
+**temp1_crit**
+
+**temp1_crit_alarm**
diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
index 294808f5240a..557ae0c414b0 100644
--- a/drivers/hwmon/pmbus/Kconfig
+++ b/drivers/hwmon/pmbus/Kconfig
@@ -377,6 +377,15 @@ config SENSORS_MPQ7932
 	  This driver can also be built as a module. If so, the module will
 	  be called mpq7932.
 
+config SENSORS_MPQ8785
+	tristate "MPS MPQ8785"
+	help
+	  If you say yes here you get hardware monitoring functionality support
+	  for power management IC MPS MPQ8785.
+
+	  This driver can also be built as a module. If so, the module will
+	  be called mpq8785.
+
 config SENSORS_PIM4328
 	tristate "Flex PIM4328 and compatibles"
 	help
diff --git a/drivers/hwmon/pmbus/Makefile b/drivers/hwmon/pmbus/Makefile
index cf8a76744545..f14ecf03ad77 100644
--- a/drivers/hwmon/pmbus/Makefile
+++ b/drivers/hwmon/pmbus/Makefile
@@ -39,6 +39,7 @@ obj-$(CONFIG_SENSORS_MP2975)	+= mp2975.o
 obj-$(CONFIG_SENSORS_MP5023)	+= mp5023.o
 obj-$(CONFIG_SENSORS_MP5990)	+= mp5990.o
 obj-$(CONFIG_SENSORS_MPQ7932)	+= mpq7932.o
+obj-$(CONFIG_SENSORS_MPQ8785)	+= mpq8785.o
 obj-$(CONFIG_SENSORS_PLI1209BC)	+= pli1209bc.o
 obj-$(CONFIG_SENSORS_PM6764TR)	+= pm6764tr.o
 obj-$(CONFIG_SENSORS_PXE1610)	+= pxe1610.o
diff --git a/drivers/hwmon/pmbus/mpq8785.c b/drivers/hwmon/pmbus/mpq8785.c
new file mode 100644
index 000000000000..b5bfc5d8a96b
--- /dev/null
+++ b/drivers/hwmon/pmbus/mpq8785.c
@@ -0,0 +1,91 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Driver for MPS MPQ8785 Step-Down Converter
+ */
+
+#include <linux/i2c.h>
+#include <linux/module.h>
+#include <linux/of_device.h>
+#include "pmbus.h"
+
+static int mpq8785_identify(struct i2c_client *client,
+			    struct pmbus_driver_info *info)
+{
+	int vout_mode;
+
+	vout_mode = pmbus_read_byte_data(client, 0, PMBUS_VOUT_MODE);
+	if (vout_mode >= 0 && vout_mode != 0xff) {
+		switch (vout_mode >> 5) {
+		case 0:
+			info->format[PSC_VOLTAGE_OUT] = linear;
+			break;
+		case 1:
+		case 2:
+			/* Direct mode or VID mode: Vout_Actual = READ_VOUT*LSB,
+			   LSB = 1.5625 mV/LSB */
+			info->format[PSC_VOLTAGE_OUT] = direct,
+			info->m[PSC_VOLTAGE_OUT] = 64;
+			info->b[PSC_VOLTAGE_OUT] = 0;
+			info->R[PSC_VOLTAGE_OUT] = 1;
+			break;
+		default:
+			return -ENODEV;
+		}
+	}
+
+	return 0;
+};
+
+static struct pmbus_driver_info mpq8785_info = {
+	.pages = 1,
+	.format[PSC_VOLTAGE_IN] = direct,
+	.format[PSC_CURRENT_OUT] = direct,
+	.format[PSC_TEMPERATURE] = direct,
+	.m[PSC_VOLTAGE_IN] = 4,
+	.b[PSC_VOLTAGE_IN] = 0,
+	.R[PSC_VOLTAGE_IN] = 1,
+	.m[PSC_CURRENT_OUT] = 16,
+	.b[PSC_CURRENT_OUT] = 0,
+	.R[PSC_CURRENT_OUT] = 0,
+	.m[PSC_TEMPERATURE] = 1,
+	.b[PSC_TEMPERATURE] = 0,
+	.R[PSC_TEMPERATURE] = 0,
+	.func[0] =
+		PMBUS_HAVE_VIN | PMBUS_HAVE_STATUS_INPUT |
+		PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT |
+		PMBUS_HAVE_IOUT | PMBUS_HAVE_STATUS_IOUT |
+		PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP,
+	.identify = mpq8785_identify,
+};
+
+static int mpq8785_probe(struct i2c_client *client)
+{
+	return pmbus_do_probe(client, &mpq8785_info);
+};
+
+static const struct i2c_device_id mpq8785_id[] = {
+	{ "mpq8785", 0 },
+	{ },
+};
+MODULE_DEVICE_TABLE(i2c, mpq8785_id);
+
+static const struct of_device_id __maybe_unused mpq8785_of_match[] = {
+	{ .compatible = "mps,mpq8785" },
+	{}
+};
+MODULE_DEVICE_TABLE(of, mpq8785_of_match);
+
+static struct i2c_driver mpq8785_driver = {
+	.driver = {
+		   .name = "mpq8785",
+		   .of_match_table = of_match_ptr(mpq8785_of_match),
+	},
+	.probe_new = mpq8785_probe,
+	.id_table = mpq8785_id,
+};
+
+module_i2c_driver(mpq8785_driver);
+
+MODULE_AUTHOR("Charles Hsu <ythsu0511@gmail.com>");
+MODULE_DESCRIPTION("PMBus driver for MPS MPQ8785");
+MODULE_LICENSE("GPL");
-- 
2.34.1

[PATCH v3 2/2] dt-bindings: Add MPQ8785 voltage regulator device

[Charles Hsu]

Monolithic Power Systems, Inc. (MPS) synchronous step-down converter.

Signed-off-by: Charles Hsu <ythsu0511@gmail.com>
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 79dcd92c4a43..088b23ed2ae6 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -129,6 +129,8 @@ properties:
           - mps,mp2975
             # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990
           - mps,mp5990
+            # Monolithic Power Systems Inc. synchronous step-down converter mpq8785
+          - mps,mpq8785
             # Honeywell Humidicon HIH-6130 humidity/temperature sensor
           - honeywell,hi6130
             # IBM Common Form Factor Power Supply Versions (all versions)
-- 
2.34.1

Re: [PATCH v3 1/2] hwmon: Add driver for MPS MPQ8785 Synchronous Step-Down Converter

[Guenter Roeck]

On 1/30/24 21:55, Charles Hsu wrote:
> Add support for mpq8785 device from Monolithic Power Systems, Inc.
> (MPS) vendor. This is synchronous step-down controller.
> 
> Signed-off-by: Charles Hsu <ythsu0511@gmail.com>
> 
> ---
> Change in v1:
>      Initial patchset.
> Change in v2:
>      1.Add pmbus support status registers.
>      2.Add mpq8785 in trivial-devices.yaml.
>      3.Remove format[PSC_VOLTAGE_OUT].
>      4.Fix MODULE_DESCRIPTION.
> Change in v3:
>      1.Identify vout_mode.
>      2.Separate dt-binding.
> ---
>   Documentation/hwmon/index.rst   |  1 +
>   Documentation/hwmon/mpq8785.rst | 94 +++++++++++++++++++++++++++++++++
>   drivers/hwmon/pmbus/Kconfig     |  9 ++++
>   drivers/hwmon/pmbus/Makefile    |  1 +
>   drivers/hwmon/pmbus/mpq8785.c   | 91 +++++++++++++++++++++++++++++++
>   5 files changed, 196 insertions(+)
>   create mode 100644 Documentation/hwmon/mpq8785.rst
>   create mode 100644 drivers/hwmon/pmbus/mpq8785.c
> 
> diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst
> index c7ed1f73ac06..085ad6ca9b05 100644
> --- a/Documentation/hwmon/index.rst
> +++ b/Documentation/hwmon/index.rst
> @@ -163,6 +163,7 @@ Hardware Monitoring Kernel Drivers
>      mp2975
>      mp5023
>      mp5990
> +   mpq8785
>      nct6683
>      nct6775
>      nct7802
> diff --git a/Documentation/hwmon/mpq8785.rst b/Documentation/hwmon/mpq8785.rst
> new file mode 100644
> index 000000000000..bf8176b87086
> --- /dev/null
> +++ b/Documentation/hwmon/mpq8785.rst
> @@ -0,0 +1,94 @@
> +.. SPDX-License-Identifier: GPL-2.0-only
> +
> +Kernel driver mpq8785
> +=======================
> +
> +Supported chips:
> +
> +  * MPS MPQ8785
> +
> +    Prefix: 'mpq8785'
> +
> +Author: Charles Hsu <ythsu0511@gmail.com>
> +
> +Description
> +-----------
> +
> +The MPQ8785 is a fully integrated, PMBus-compatible, high-frequency, synchronous
> +buck converter. The MPQ8785 offers a very compact solution that achieves up to
> +40A output current per phase, with excellent load and line regulation over a
> +wide input supply range. The MPQ8785 operates at high efficiency over a wide
> +output current load range.
> +
> +The PMBus interface provides converter configurations and key parameters
> +monitoring.
> +
> +The MPQ8785 adopts MPS's proprietary multi-phase digital constant-on-time (MCOT)
> +control, which provides fast transient response and eases loop stabilization.
> +The MCOT scheme also allows multiple MPQ8785 devices to be connected in parallel
> +with excellent current sharing and phase interleaving for high-current
> +applications.
> +
> +Fully integrated protection features include over-current protection (OCP),
> +over-voltage protection (OVP), under-voltage protection (UVP), and
> +over-temperature protection (OTP).
> +
> +The MPQ8785 requires a minimal number of readily available, standard external
> +components, and is available in a TLGA (5mmx6mm) package.
> +
> +Device compliant with:
> +
> +- PMBus rev 1.3 interface.
> +
> +The driver exports the following attributes via the 'sysfs' files
> +for input voltage:
> +
> +**in1_input**
> +
> +**in1_label**
> +
> +**in1_max**
> +
> +**in1_max_alarm**
> +
> +**in1_min**
> +
> +**in1_min_alarm**
> +
> +**in1_crit**
> +
> +**in1_crit_alarm**
> +
> +The driver provides the following attributes for output voltage:
> +
> +**in2_input**
> +
> +**in2_label**
> +
> +**in2_alarm**
> +
> +The driver provides the following attributes for output current:
> +
> +**curr1_input**
> +
> +**curr1_label**
> +
> +**curr1_max**
> +
> +**curr1_max_alarm**
> +
> +**curr1_crit**
> +
> +**curr1_crit_alarm**
> +
> +The driver provides the following attributes for temperature:
> +
> +**temp1_input**
> +
> +**temp1_max**
> +
> +**temp1_max_alarm**
> +
> +**temp1_crit**
> +
> +**temp1_crit_alarm**
> diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
> index 294808f5240a..557ae0c414b0 100644
> --- a/drivers/hwmon/pmbus/Kconfig
> +++ b/drivers/hwmon/pmbus/Kconfig
> @@ -377,6 +377,15 @@ config SENSORS_MPQ7932
>   	  This driver can also be built as a module. If so, the module will
>   	  be called mpq7932.
>   
> +config SENSORS_MPQ8785
> +	tristate "MPS MPQ8785"
> +	help
> +	  If you say yes here you get hardware monitoring functionality support
> +	  for power management IC MPS MPQ8785.
> +
> +	  This driver can also be built as a module. If so, the module will
> +	  be called mpq8785.
> +
>   config SENSORS_PIM4328
>   	tristate "Flex PIM4328 and compatibles"
>   	help
> diff --git a/drivers/hwmon/pmbus/Makefile b/drivers/hwmon/pmbus/Makefile
> index cf8a76744545..f14ecf03ad77 100644
> --- a/drivers/hwmon/pmbus/Makefile
> +++ b/drivers/hwmon/pmbus/Makefile
> @@ -39,6 +39,7 @@ obj-$(CONFIG_SENSORS_MP2975)	+= mp2975.o
>   obj-$(CONFIG_SENSORS_MP5023)	+= mp5023.o
>   obj-$(CONFIG_SENSORS_MP5990)	+= mp5990.o
>   obj-$(CONFIG_SENSORS_MPQ7932)	+= mpq7932.o
> +obj-$(CONFIG_SENSORS_MPQ8785)	+= mpq8785.o
>   obj-$(CONFIG_SENSORS_PLI1209BC)	+= pli1209bc.o
>   obj-$(CONFIG_SENSORS_PM6764TR)	+= pm6764tr.o
>   obj-$(CONFIG_SENSORS_PXE1610)	+= pxe1610.o
> diff --git a/drivers/hwmon/pmbus/mpq8785.c b/drivers/hwmon/pmbus/mpq8785.c
> new file mode 100644
> index 000000000000..b5bfc5d8a96b
> --- /dev/null
> +++ b/drivers/hwmon/pmbus/mpq8785.c
> @@ -0,0 +1,91 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Driver for MPS MPQ8785 Step-Down Converter
> + */
> +
> +#include <linux/i2c.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include "pmbus.h"
> +
> +static int mpq8785_identify(struct i2c_client *client,
> +			    struct pmbus_driver_info *info)
> +{
> +	int vout_mode;
> +
> +	vout_mode = pmbus_read_byte_data(client, 0, PMBUS_VOUT_MODE);

Excellent solution, but it will have to return an error if reading
VOUT_MODE fails. Something like:

	vout_mode = ...;
	if (vout_mode < 0 || vout_mode == 0xff)
		return vout_mode < 0 ? vout_mode : -ENODEV;

	switch (vout_mode >> 5) {
	...

The output mode _has_ to be valid.

Thanks,
Guenter

Re: [PATCH v3 2/2] dt-bindings: Add MPQ8785 voltage regulator device

[Guenter Roeck]

On 1/30/24 21:55, Charles Hsu wrote:
> Monolithic Power Systems, Inc. (MPS) synchronous step-down converter.
> 
> Signed-off-by: Charles Hsu <ythsu0511@gmail.com>

This should be the first patch of the series.

Thanks,
Guenter

Re: [PATCH v3 2/2] dt-bindings: Add MPQ8785 voltage regulator device

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1207 bytes --]

On Wed, Jan 31, 2024 at 01:55:26PM +0800, Charles Hsu wrote:
> Monolithic Power Systems, Inc. (MPS) synchronous step-down converter.
> 
> Signed-off-by: Charles Hsu <ythsu0511@gmail.com>
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 79dcd92c4a43..088b23ed2ae6 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -129,6 +129,8 @@ properties:
>            - mps,mp2975
>              # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990
>            - mps,mp5990
> +            # Monolithic Power Systems Inc. synchronous step-down converter mpq8785
> +          - mps,mpq8785

q sorts before 2, otherwise
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

>              # Honeywell Humidicon HIH-6130 humidity/temperature sensor
>            - honeywell,hi6130
>              # IBM Common Form Factor Power Supply Versions (all versions)
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v3 2/2] dt-bindings: Add MPQ8785 voltage regulator device

[徐永謄]

On Wed, Jan 31, 2024 at 11:41 PM Conor Dooley <conor@kernel.org> wrote:
>
> On Wed, Jan 31, 2024 at 01:55:26PM +0800, Charles Hsu wrote:
> > Monolithic Power Systems, Inc. (MPS) synchronous step-down converter.
> >
> > Signed-off-by: Charles Hsu <ythsu0511@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> > index 79dcd92c4a43..088b23ed2ae6 100644
> > --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> > @@ -129,6 +129,8 @@ properties:
> >            - mps,mp2975
> >              # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990
> >            - mps,mp5990
> > +            # Monolithic Power Systems Inc. synchronous step-down converter mpq8785
> > +          - mps,mpq8785
>
> q sorts before 2, otherwise
Okay, I got it.
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
> Cheers,
> Conor.
>
> >              # Honeywell Humidicon HIH-6130 humidity/temperature sensor
> >            - honeywell,hi6130
> >              # IBM Common Form Factor Power Supply Versions (all versions)
> > --
> > 2.34.1
> >

Re: [PATCH v3 2/2] dt-bindings: Add MPQ8785 voltage regulator device

[Guenter Roeck]

On 1/31/24 07:41, Conor Dooley wrote:
> On Wed, Jan 31, 2024 at 01:55:26PM +0800, Charles Hsu wrote:
>> Monolithic Power Systems, Inc. (MPS) synchronous step-down converter.
>>
>> Signed-off-by: Charles Hsu <ythsu0511@gmail.com>
>> ---
>>   Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
>> index 79dcd92c4a43..088b23ed2ae6 100644
>> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
>> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
>> @@ -129,6 +129,8 @@ properties:
>>             - mps,mp2975
>>               # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990
>>             - mps,mp5990
>> +            # Monolithic Power Systems Inc. synchronous step-down converter mpq8785
>> +          - mps,mpq8785
> 
> q sorts before 2, otherwise

It does ? Not in ASCII. Am I missing something ?

Thanks,
Guenter

Re: [PATCH v3 2/2] dt-bindings: Add MPQ8785 voltage regulator device

[Krzysztof Kozlowski]

On 01/02/2024 01:41, Guenter Roeck wrote:
> On 1/31/24 07:41, Conor Dooley wrote:
>> On Wed, Jan 31, 2024 at 01:55:26PM +0800, Charles Hsu wrote:
>>> Monolithic Power Systems, Inc. (MPS) synchronous step-down converter.
>>>
>>> Signed-off-by: Charles Hsu <ythsu0511@gmail.com>
>>> ---
>>>   Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
>>> index 79dcd92c4a43..088b23ed2ae6 100644
>>> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
>>> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
>>> @@ -129,6 +129,8 @@ properties:
>>>             - mps,mp2975
>>>               # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990
>>>             - mps,mp5990
>>> +            # Monolithic Power Systems Inc. synchronous step-down converter mpq8785
>>> +          - mps,mpq8785
>>
>> q sorts before 2, otherwise
> 
> It does ? Not in ASCII. Am I missing something ?

Also `sort` agrees with q being after numbers.

Best regards,
Krzysztof

Re: [PATCH v3 2/2] dt-bindings: Add MPQ8785 voltage regulator device

[Krzysztof Kozlowski]

On 31/01/2024 16:41, Conor Dooley wrote:
> On Wed, Jan 31, 2024 at 01:55:26PM +0800, Charles Hsu wrote:
>> Monolithic Power Systems, Inc. (MPS) synchronous step-down converter.
>>
>> Signed-off-by: Charles Hsu <ythsu0511@gmail.com>
>> ---
>>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
>> index 79dcd92c4a43..088b23ed2ae6 100644
>> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
>> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
>> @@ -129,6 +129,8 @@ properties:
>>            - mps,mp2975
>>              # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990
>>            - mps,mp5990
>> +            # Monolithic Power Systems Inc. synchronous step-down converter mpq8785
>> +          - mps,mpq8785
> 
> q sorts before 2, otherwise
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

I will sort the file and my patch should go via Rob's tree, I guess, so
maybe this one could go as well?

Best regards,
Krzysztof

Re: [PATCH v3 2/2] dt-bindings: Add MPQ8785 voltage regulator device

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]

On Thu, Feb 01, 2024 at 08:47:07AM +0100, Krzysztof Kozlowski wrote:
> On 01/02/2024 01:41, Guenter Roeck wrote:
> > On 1/31/24 07:41, Conor Dooley wrote:
> >> On Wed, Jan 31, 2024 at 01:55:26PM +0800, Charles Hsu wrote:
> >>> Monolithic Power Systems, Inc. (MPS) synchronous step-down converter.
> >>>
> >>> Signed-off-by: Charles Hsu <ythsu0511@gmail.com>
> >>> ---
> >>>   Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> >>>   1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> >>> index 79dcd92c4a43..088b23ed2ae6 100644
> >>> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> >>> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> >>> @@ -129,6 +129,8 @@ properties:
> >>>             - mps,mp2975
> >>>               # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990
> >>>             - mps,mp5990
> >>> +            # Monolithic Power Systems Inc. synchronous step-down converter mpq8785
> >>> +          - mps,mpq8785
> >>
> >> q sorts before 2, otherwise
> > 
> > It does ? Not in ASCII. Am I missing something ?
> 
> Also `sort` agrees with q being after numbers.

Disregard that comment so.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v3 2/2] dt-bindings: Add MPQ8785 voltage regulator device

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1255 bytes --]

On Thu, Feb 01, 2024 at 08:34:32AM +0800, 徐永謄 wrote:
> On Wed, Jan 31, 2024 at 11:41 PM Conor Dooley <conor@kernel.org> wrote:
> >
> > On Wed, Jan 31, 2024 at 01:55:26PM +0800, Charles Hsu wrote:
> > > Monolithic Power Systems, Inc. (MPS) synchronous step-down converter.
> > >
> > > Signed-off-by: Charles Hsu <ythsu0511@gmail.com>
> > > ---
> > >  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> > > index 79dcd92c4a43..088b23ed2ae6 100644
> > > --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> > > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> > > @@ -129,6 +129,8 @@ properties:
> > >            - mps,mp2975
> > >              # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990
> > >            - mps,mp5990
> > > +            # Monolithic Power Systems Inc. synchronous step-down converter mpq8785
> > > +          - mps,mpq8785
> >
> > q sorts before 2, otherwise
> Okay, I got it.

Apparently I am wrong, sorry about that! Please ignore this comment.

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v3 2/2] dt-bindings: Add MPQ8785 voltage regulator device

[Guenter Roeck]

On 1/31/24 23:52, Krzysztof Kozlowski wrote:
> On 31/01/2024 16:41, Conor Dooley wrote:
>> On Wed, Jan 31, 2024 at 01:55:26PM +0800, Charles Hsu wrote:
>>> Monolithic Power Systems, Inc. (MPS) synchronous step-down converter.
>>>
>>> Signed-off-by: Charles Hsu <ythsu0511@gmail.com>
>>> ---
>>>   Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
>>> index 79dcd92c4a43..088b23ed2ae6 100644
>>> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
>>> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
>>> @@ -129,6 +129,8 @@ properties:
>>>             - mps,mp2975
>>>               # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990
>>>             - mps,mp5990
>>> +            # Monolithic Power Systems Inc. synchronous step-down converter mpq8785
>>> +          - mps,mpq8785
>>
>> q sorts before 2, otherwise
>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> I will sort the file and my patch should go via Rob's tree, I guess, so
> maybe this one could go as well?
> 

Sure, fine with me. I applied the patch to the hwmon tree, but I have no problems
dropping it from there. Sorry, I never know if I should take .yaml patches or not.

Guenter