From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH] of_mdio: use of_property_read_u32_array() Date: Mon, 7 Aug 2017 11:01:01 -0700 Message-ID: References: <20170804214354.351406407@cogentembedded.com> <080ebcb6-b5aa-63db-176b-83477c2540e5@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <080ebcb6-b5aa-63db-176b-83477c2540e5@cogentembedded.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org To: Sergei Shtylyov , Rob Herring Cc: Andrew Lunn , Frank Rowand , netdev , "devicetree@vger.kernel.org" List-Id: devicetree@vger.kernel.org On 08/07/2017 09:18 AM, Sergei Shtylyov wrote: > Hello! > > On 08/07/2017 05:18 PM, Rob Herring wrote: > >>> The "fixed-link" prop support predated of_property_read_u32_array(), so >>> basically had to open-code it. Using the modern API saves 24 bytes of >>> the >>> object code (ARM gcc 4.8.5); the only behavior change would be that the >>> prop length check is now less strict (however the strict pre-check done >>> in of_phy_is_fixed_link() is left intact anyway)... >>> >>> Signed-off-by: Sergei Shtylyov >>> >>> --- >>> The patch is against the 'dt/next' branch of Rob Herring's >>> 'linux-git' repo >>> plus the previously posted patch killing the useless local variable in >>> of_phy_register_fixed_link(). >> >> It shouldn't depend on anything in my tree and David normally takes >> of_mdio.c changes. > > MAINTAINERS still only point at the DT repo, perhaps it should be > updated? More or less done with this (minus the repo part): http://patchwork.ozlabs.org/patch/795887/ -- Florian