devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Biju Das <biju.das.jz@bp.renesas.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Biju Das <biju.das@bp.renesas.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH 1/2] arm64: dts: renesas: r9a07g044: Fix external clk node names
Date: Sat, 23 Apr 2022 21:34:06 +0200	[thread overview]
Message-ID: <f9c6e5e2-c819-d309-0c11-b87deb772858@linaro.org> (raw)
In-Reply-To: <20220423140658.145000-1-biju.das.jz@bp.renesas.com>

On 23/04/2022 16:06, Biju Das wrote:
> Fix audio clk node names with "_" -> "-" and add suffix '-clk' for can and
> extal clks.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
>  arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> index 19287cccb1f0..4f9a84d7af08 100644
> --- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> @@ -13,14 +13,14 @@ / {
>  	#address-cells = <2>;
>  	#size-cells = <2>;
>  
> -	audio_clk1: audio_clk1 {
> +	audio_clk1: audio-clk1 {

How about in such case keeping suffix "clk" everywhere and moving the
index (1/2) to the first part? This way one day maybe schema will match
the clocks.

Best regards,
Krzysztof

  parent reply	other threads:[~2022-04-23 19:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-23 14:06 [PATCH 1/2] arm64: dts: renesas: r9a07g044: Fix external clk node names Biju Das
2022-04-23 14:06 ` [PATCH 2/2] arm64: dts: renesas: r9a07g054: " Biju Das
2022-04-23 19:34 ` Krzysztof Kozlowski [this message]
2022-04-24  6:45   ` [PATCH 1/2] arm64: dts: renesas: r9a07g044: " Biju Das
2022-04-24  7:50     ` Biju Das
2022-04-24 10:04       ` Krzysztof Kozlowski
2022-04-24 10:22         ` Biju Das
2022-04-24 14:39           ` Krzysztof Kozlowski
2022-04-25 15:28             ` Biju Das
2022-04-25 15:50               ` Krzysztof Kozlowski
2022-04-25 16:26                 ` Biju Das
2022-04-25 16:30                   ` Krzysztof Kozlowski
2022-04-25 16:52                     ` Biju Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9c6e5e2-c819-d309-0c11-b87deb772858@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=Chris.Paterson2@renesas.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=biju.das@bp.renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).