devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: mt8195: change watchdog reset boot flow
@ 2023-08-07  8:58 Hsin-Te Yuan
  2023-08-07 11:05 ` Eugen Hristev
  0 siblings, 1 reply; 2+ messages in thread
From: Hsin-Te Yuan @ 2023-08-07  8:58 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	AngeloGioacchino Del Regno
  Cc: linux-mediatek, linux-arm-kernel, linux-kernel, devicetree,
	Hsin-Te Yuan

The external output reset signal was originally disabled and sent from
firmware. However, an unfixed bug in the firmware prevents the signal
from being sent, causing the device to fail to boot. To fix this, enable
external output reset signal to allow the device to reboot normally.

Signed-off-by: Hsin-Te Yuan <yuanhsinte@google.com>
---

 arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
index 37a3e9de90ff7..5dc4214e1840b 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
@@ -1147,6 +1147,10 @@ &uart0 {
 	status = "okay";
 };
 
+&watchdog {
+	/delete-property/ mediatek,disable-extrst;
+};
+
 &xhci0 {
 	status = "okay";
 
-- 
2.41.0.585.gd2178a4bd4-goog


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: mt8195: change watchdog reset boot flow
  2023-08-07  8:58 [PATCH] arm64: dts: mt8195: change watchdog reset boot flow Hsin-Te Yuan
@ 2023-08-07 11:05 ` Eugen Hristev
  0 siblings, 0 replies; 2+ messages in thread
From: Eugen Hristev @ 2023-08-07 11:05 UTC (permalink / raw)
  To: Hsin-Te Yuan, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Matthias Brugger, AngeloGioacchino Del Regno
  Cc: linux-mediatek, linux-arm-kernel, linux-kernel, devicetree,
	Hsin-Te Yuan

Hello Hsin-Te,

On 8/7/23 11:58, Hsin-Te Yuan wrote:
> The external output reset signal was originally disabled and sent from
> firmware. However, an unfixed bug in the firmware prevents the signal
> from being sent, causing the device to fail to boot. To fix this, enable
> external output reset signal to allow the device to reboot normally.
> 
> Signed-off-by: Hsin-Te Yuan <yuanhsinte@google.com>
> ---
> 
>   arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> index 37a3e9de90ff7..5dc4214e1840b 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> @@ -1147,6 +1147,10 @@ &uart0 {
>   	status = "okay";
>   };
>   
> +&watchdog {
> +	/delete-property/ mediatek,disable-extrst;
> +};
> +

Does this affect only the mt8195-cherry or all mt8195 boards ?

Judging by this commit , I think only mt8195-cherry, but your commit 
message somehow suggests otherwise.

Eugen

>   &xhci0 {
>   	status = "okay";
>   


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-08-07 11:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-07  8:58 [PATCH] arm64: dts: mt8195: change watchdog reset boot flow Hsin-Te Yuan
2023-08-07 11:05 ` Eugen Hristev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).