public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Josua Mayer <josua@solid-run.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
	Vladimir Oltean <olteanv@gmail.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
	Vincent Mailhol <mailhol@kernel.org>,
	Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Peter Rosin <peda@axentia.se>,
	Aaro Koskinen <aaro.koskinen@iki.fi>,
	Andreas Kemnade <andreas@kemnade.info>,
	Kevin Hilman <khilman@baylibre.com>,
	Roger Quadros <rogerq@kernel.org>,
	Tony Lindgren <tony@atomide.com>,
	Janusz Krzysztofik <jmkrzyszt@gmail.com>,
	Vignesh R <vigneshr@ti.com>, Andi Shyti <andi.shyti@kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Yazan Shhady <yazan.shhady@solid-run.com>,
	Jon Nettleton <jon@solid-run.com>,
	Mikhail Anikin <mikhail.anikin@solid-run.com>,
	"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
	"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v9 1/7] phy: can-transceiver: rename temporary helper function to avoid conflict
Date: Mon, 16 Feb 2026 08:19:27 +0000	[thread overview]
Message-ID: <f9ede0d3-6a37-449c-b62b-a5c761ece097@solid-run.com> (raw)
In-Reply-To: <CAMuHMdVOqovkugmCnR4FOfk8VkQyN_dmyKFzbsOSN0mPKQedeQ@mail.gmail.com>

Hi,

On 12/02/2026 18:53, Geert Uytterhoeven wrote:
> Hi Vladimir,
>
> On Thu, 12 Feb 2026 at 17:48, Vladimir Oltean <olteanv@gmail.com> wrote:
>> On Sun, Feb 08, 2026 at 05:38:56PM +0200, Josua Mayer wrote:
>>> Rename the temporary devm_mux_state_get_optional function to avoid
>>> conflict with upcoming implementation in multiplexer subsystem.
>>>
>>> Acked-by: Vinod Koul <vkoul@kernel.org>
>>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>>> Signed-off-by: Josua Mayer <josua@solid-run.com>
>> In the future, when you have a series with cross-tree dependencies,
>> please try to think of it as individual mini-series for each tree's
>> 'next' branch, and specify clearly that you need stable tags (to be
>> pulled into other trees).

I don't really understand how I could split my series up to avoid this 
issue.

Due to the fact that one (and now two) drivers implemented local
mux helpers, to undo that an atomic change must be made tree-wide.

Meanwhile it must be avoided that while the mux core helpers are being
tested / reviewed, that any tree adds another driver-local mux helper
like appears to have happened here.

Note that my patch-set did go to linux-phy@lists.infradead.org list, too.

The second challenge for this series was that mux framework is being
enabled only by drivers Kconfig "select" - and not possible by menuconfig.
This is e.g. responsible for being unable to test =m build with arm64
defconfig - and lead to it only being detected through kernel robot
x86_64 allmodconfig.

>> Telling maintainers what is your expected
>> merge strategy helps avoid making mistakes.
>>
>> For example, if you did that in this set, you wouldn't have missed the
>> fact that in linux-phy/next, phy-can-transceiver is _not_ the only
>> occurrence of devm_mux_state_get_optional(). There's another one in
>> drivers/phy/renesas/phy-rcar-gen3-usb2.c, and that should be also
>> handled in order for trees to not enter inconsistent states.
> To his defense, the one in drivers/phy/renesas/phy-rcar-gen3-usb2.c
> is a recent addition.
>
> So this is yet another case of "convert all current users" (i.e. those
> present in the typical subsystem base, typically *-rc1), with new
> users popping up in -next in parallel, which happens all the time...
>
> Gr{oetje,eeting}s,
>
>                          Geert
>


  reply	other threads:[~2026-02-16  8:19 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-08 15:38 [PATCH v9 0/7] mmc: host: renesas_sdhi_core: support configuring an optional sdio mux Josua Mayer
2026-02-08 15:38 ` [PATCH v9 1/7] phy: can-transceiver: rename temporary helper function to avoid conflict Josua Mayer
2026-02-12 16:48   ` Vladimir Oltean
2026-02-12 16:53     ` Geert Uytterhoeven
2026-02-16  8:19       ` Josua Mayer [this message]
2026-02-16  9:29         ` Vladimir Oltean
2026-02-16 10:01           ` Geert Uytterhoeven
2026-02-16 15:24           ` Andreas Kemnade
2026-02-23 12:43             ` Josua Mayer
2026-02-23 13:12               ` Vladimir Oltean
2026-02-23 13:44               ` Ulf Hansson
2026-02-08 15:38 ` [PATCH v9 2/7] mux: Add helper functions for getting optional and selected mux-state Josua Mayer
2026-02-08 15:38 ` [PATCH v9 3/7] mux: add help text for MULTIPLEXER config option Josua Mayer
2026-02-09  8:10   ` Geert Uytterhoeven
2026-02-09 11:10   ` Peter Rosin
2026-02-09 11:31     ` Josua Mayer
2026-02-09 11:43       ` Peter Rosin
2026-02-09 12:07         ` Josua Mayer
2026-02-09 13:08           ` Peter Rosin
2026-02-09 20:02             ` Josua Mayer
2026-02-10 14:42               ` Peter Rosin
2026-02-10  7:50             ` Geert Uytterhoeven
2026-02-10 14:45               ` Peter Rosin
2026-02-08 15:38 ` [PATCH v9 4/7] phy: can-transceiver: drop temporary helper getting optional mux-state Josua Mayer
2026-02-08 15:39 ` [PATCH v9 5/7] i2c: omap: switch to new generic helper for getting selected mux-state Josua Mayer
2026-02-08 15:39 ` [PATCH v9 6/7] dt-bindings: mmc: renesas,sdhi: Add mux-states property Josua Mayer
2026-02-08 15:39 ` [PATCH v9 7/7] mmc: host: renesas_sdhi_core: support selecting an optional mux Josua Mayer
2026-02-09  2:12   ` kernel test robot
2026-02-09  9:57 ` [PATCH v9 0/7] mmc: host: renesas_sdhi_core: support configuring an optional sdio mux Ulf Hansson
2026-02-09 10:21   ` Josua Mayer
2026-02-09 13:16   ` Peter Rosin
2026-02-09 13:39     ` Ulf Hansson
2026-02-09 13:50       ` Peter Rosin
2026-02-09 16:48         ` Ulf Hansson
2026-02-09 16:49           ` Ulf Hansson
2026-02-09 18:42             ` Josua Mayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9ede0d3-6a37-449c-b62b-a5c761ece097@solid-run.com \
    --to=josua@solid-run.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=andi.shyti@kernel.org \
    --cc=andreas@kemnade.info \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=geert@linux-m68k.org \
    --cc=jmkrzyszt@gmail.com \
    --cc=jon@solid-run.com \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mailhol@kernel.org \
    --cc=mikhail.anikin@solid-run.com \
    --cc=mkl@pengutronix.de \
    --cc=neil.armstrong@linaro.org \
    --cc=olteanv@gmail.com \
    --cc=peda@axentia.se \
    --cc=robh@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=tony@atomide.com \
    --cc=ulf.hansson@linaro.org \
    --cc=vigneshr@ti.com \
    --cc=vkoul@kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=yazan.shhady@solid-run.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox