From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6825C433FE for ; Wed, 25 May 2022 07:31:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244337AbiEYHbz (ORCPT ); Wed, 25 May 2022 03:31:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240504AbiEYHbx (ORCPT ); Wed, 25 May 2022 03:31:53 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A25F737A0B for ; Wed, 25 May 2022 00:31:51 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id a23so23484094ljd.9 for ; Wed, 25 May 2022 00:31:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Y2nHQ+fi4PGROpze+YJ+ImCGYvCKI2QwS/EoNpD0efc=; b=B9dafGTNVBB/1eV32dXVQsnHURWF3hUL06iNP1fB1zCZEWsTCbLpG/8mJEHqRkfs4r Lt8sNIDarBegusJ18/s31F9whgx4x/h9HDNpXSprMCLsbgUAN5OodhYBzhvfkV7loxSg xIZkq1UX1iZKPFylqHUN8xSoIUW2MmdoXjUTqHU5Q8KmBXHnxoQqm6HCeYVNealc+mmq wMDFWIfnIoKh7Z6oWVjkCW8ssIj11kUKAIlCPbdiGLuOzdWIk7+ponVziiu9qA3GOmrf 4koWT2pia/pkqL4jiro6l7tYfCQgn0KCJ8XT+hZ2O4BDL/5mkdEIVB07XkAq7X/ite2C hkfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Y2nHQ+fi4PGROpze+YJ+ImCGYvCKI2QwS/EoNpD0efc=; b=PkhdOw0L5I1gejhY1Tszk7EhYCycvVBJEE7rZRozcmbGGxrB/UMCvy3vYnpbl6eTU2 7y3KIP4hiGwt1Siq4GpiC5RCzEXqn/xHC/6RzCN8SUrTg6216Wx1aMVN5N+OGgQ03CFu C9jhUukBMAnZKRapdTZb/Oor/S+2+9VPaLqmTWjBszj4t+s0/cDYntl71UJ9R2/mbAwW HecWLaF+kKoIaTFjlCYXW7pZ6yDJSxHwOl0jXx9P6eopQ7GsDpP+HCJ8G9MBO5fW6r8Q Tzq0gu46nUVx8MVZNN8WDdv6V3y3FBbW8uywdrgg04kOQ7PbUjQ0+c7ggIaotVlDi2OX WgmA== X-Gm-Message-State: AOAM531M6qLySALqkGv993Wt7O9qs1BPTfgM56bwWc8xNWw8q5VGyryB GpCncQ+Q496npTNCO0N07UtRyw== X-Google-Smtp-Source: ABdhPJzSlmyfAw7HAwZP5W2LdSaycFjVclSpcQt0PsWn+G5cbfCbAF7eea3gifwt7BF+3BruQcwZUw== X-Received: by 2002:a05:651c:1306:b0:253:e957:c715 with SMTP id u6-20020a05651c130600b00253e957c715mr9322358lja.169.1653463909886; Wed, 25 May 2022 00:31:49 -0700 (PDT) Received: from [192.168.1.102] (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id n10-20020a2e86ca000000b00253dffc82b5sm2763010ljj.71.2022.05.25.00.31.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 May 2022 00:31:49 -0700 (PDT) Message-ID: Date: Wed, 25 May 2022 10:31:48 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 3/4] arm64: dts: qcom: sm8250: camss: Define ports address/size cells Content-Language: en-US To: Bryan O'Donoghue , robert.foss@linaro.org, todor.too@gmail.com, agross@kernel.org, bjorn.andersson@linaro.org Cc: mchehab@kernel.org, robh+dt@kernel.org, krzk+dt@kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, mmitkov@quicinc.com, jgrahsl@snap.com, hfink@snap.com, Konrad Dybcio References: <20220524140207.2758605-1-bryan.odonoghue@linaro.org> <20220524140207.2758605-4-bryan.odonoghue@linaro.org> From: Vladimir Zapolskiy In-Reply-To: <20220524140207.2758605-4-bryan.odonoghue@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 5/24/22 17:02, Bryan O'Donoghue wrote: > The ports {} address and size cells definition is the same for every > derived 8250 board so, we should define it in the core sm8250.dtsi. > > Suggested-by: Konrad Dybcio > Signed-off-by: Bryan O'Donoghue > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index 2bc11cad3a44..aa9a13364865 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -3395,6 +3395,11 @@ camss: camss@ac6a000 { > "cam_hf_0_mnoc", > "cam_sf_0_mnoc", > "cam_sf_icp_mnoc"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + }; > }; > > camcc: clock-controller@ad00000 { Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir