From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/1] ASoC: dt-bindings: Mark old binding qcom,cpu-lpass-apq8016 as deprecated
Date: Sat, 10 Sep 2022 12:10:33 +0100 [thread overview]
Message-ID: <fa0bd321-cf92-98e9-bf5c-9969cfba9b06@linaro.org> (raw)
In-Reply-To: <d47aa92f-d8fa-24fd-653b-aa01c3f7c040@linaro.org>
On 10/09/2022 08:55, Krzysztof Kozlowski wrote:
> On 10/09/2022 03:42, Bryan O'Donoghue wrote:
>> We've had some discongruity in the compatible string of the lpass for 8916
>> for a while.
>>
>> Mark the old compat as deprecated. New SoC additions such as msm8936 and
>> msm8939 should use the compat string "qcom,apq8016-lpass-cpu".
>>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> ---
>> .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 13 ++++++++-----
>> 1 file changed, 8 insertions(+), 5 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
>> index ef18a572a1ff3..e2c0f573a3084 100644
>> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
>> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
>> @@ -18,11 +18,14 @@ description: |
>>
>> properties:
>> compatible:
>> - enum:
>> - - qcom,lpass-cpu
>> - - qcom,apq8016-lpass-cpu
>> - - qcom,sc7180-lpass-cpu
>> - - qcom,sc7280-lpass-cpu
>> + oneOf:
>> + - enum:
>> + - qcom,lpass-cpu
>> + - qcom,apq8016-lpass-cpu
>
> The indentation looks odd here. Are you sure it passes the `make
> dt_binding_check`?
It does yeah
---
bod
next prev parent reply other threads:[~2022-09-10 11:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-10 1:42 [PATCH v2 0/1] Update apq8016 lpass-cpu compat string Bryan O'Donoghue
2022-09-10 1:42 ` [PATCH v2 1/1] ASoC: dt-bindings: Mark old binding qcom,cpu-lpass-apq8016 as deprecated Bryan O'Donoghue
2022-09-10 7:55 ` Krzysztof Kozlowski
2022-09-10 11:10 ` Bryan O'Donoghue [this message]
2022-09-10 14:53 ` Rob Herring
2022-09-10 17:22 ` Bryan O'Donoghue
2022-09-11 13:34 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa0bd321-cf92-98e9-bf5c-9969cfba9b06@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).