From: Xianwei Zhao <xianwei.zhao@amlogic.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>
Subject: Re: [PATCH 4/6] dt-bindings: power: add Amlogic T7 power domains
Date: Mon, 21 Aug 2023 17:40:22 +0800 [thread overview]
Message-ID: <fa2aa42d-9701-6d09-1a0c-9e7d18f83b5c@amlogic.com> (raw)
In-Reply-To: <a2e18e03-a50e-897a-b599-f3b6bfa6af88@linaro.org>
Hi Krzystof,
Thanks for your review.
On 2023/8/19 22:20, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On 17/08/2023 09:11, Xianwei Zhao wrote:
>> From: "xianwei.zhao" <xianwei.zhao@amlogic.com>
>
>> @@ -21,6 +21,7 @@ properties:
>> - amlogic,meson-a1-pwrc
>> - amlogic,meson-s4-pwrc
>> - amlogic,c3-pwrc
>> + - amlogic,t7-pwrc
>>
>> "#power-domain-cells":
>> const: 1
>> diff --git a/include/dt-bindings/power/amlogic,t7-pwrc.h b/include/dt-bindings/power/amlogic,t7-pwrc.h
>> new file mode 100644
>> index 000000000000..b7a13eda563c
>> --- /dev/null
>> +++ b/include/dt-bindings/power/amlogic,t7-pwrc.h
>> @@ -0,0 +1,63 @@
>> +/* SPDX-License-Identifier: (GPL-2.0-only OR .*) */
>
> This does not look correct license. Use one recommended by checkpatch.
>
Will fix it in next version.
>
>
> Best regards,
> Krzysztof
>
prev parent reply other threads:[~2023-08-21 9:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 7:11 [PATCH 0/6] Power: T7: add power domain driver Xianwei Zhao
[not found] ` <20230817071148.510575-5-xianwei.zhao@amlogic.com>
2023-08-19 14:20 ` [PATCH 4/6] dt-bindings: power: add Amlogic T7 power domains Krzysztof Kozlowski
2023-08-21 9:40 ` Xianwei Zhao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa2aa42d-9701-6d09-1a0c-9e7d18f83b5c@amlogic.com \
--to=xianwei.zhao@amlogic.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).