[PATCH 0/6] Power: T7: add power domain driver

[PATCH 0/6] Power: T7: add power domain driver

[Xianwei Zhao]

First patch is that remove C3 some power domain ALWAYS_ON property.
Second patch is that add driver to support power parent node. 
Third patch is that turn on power if initial power domain with
"AWAY_ON" property state is off.

Other patchs adds power controller driver support for Amlogic T7 SoC.

xianwei.zhao (6):
  soc: amlogic: modify some power domains property
  soc: amlogic: add driver to support power parent node
  soc: amlogic: init power domain state
  dt-bindings: power: add Amlogic T7 power domains
  soc: amlogic: Add support for T7 power domains controller
  arm64: dts: add support for T7 power domain controller

 .../power/amlogic,meson-sec-pwrc.yaml         |   3 +-
 arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi   |   6 +
 drivers/genpd/amlogic/meson-secure-pwrc.c     | 128 ++++++++++++++++--
 include/dt-bindings/power/amlogic,t7-pwrc.h   |  63 +++++++++
 4 files changed, 185 insertions(+), 15 deletions(-)
 create mode 100644 include/dt-bindings/power/amlogic,t7-pwrc.h


base-commit: 413f5c02929bb33042bbc4ee233166550a5fca70
-- 
2.37.1

Re: [PATCH 4/6] dt-bindings: power: add Amlogic T7 power domains

[Krzysztof Kozlowski]

On 17/08/2023 09:11, Xianwei Zhao wrote:
> From: "xianwei.zhao" <xianwei.zhao@amlogic.com>

> @@ -21,6 +21,7 @@ properties:
>        - amlogic,meson-a1-pwrc
>        - amlogic,meson-s4-pwrc
>        - amlogic,c3-pwrc
> +      - amlogic,t7-pwrc
>  
>    "#power-domain-cells":
>      const: 1
> diff --git a/include/dt-bindings/power/amlogic,t7-pwrc.h b/include/dt-bindings/power/amlogic,t7-pwrc.h
> new file mode 100644
> index 000000000000..b7a13eda563c
> --- /dev/null
> +++ b/include/dt-bindings/power/amlogic,t7-pwrc.h
> @@ -0,0 +1,63 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR .*) */

This does not look correct license. Use one recommended by checkpatch.



Best regards,
Krzysztof

Re: [PATCH 4/6] dt-bindings: power: add Amlogic T7 power domains

[Xianwei Zhao]

Hi Krzystof,
      Thanks for your review.

On 2023/8/19 22:20, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
> 
> On 17/08/2023 09:11, Xianwei Zhao wrote:
>> From: "xianwei.zhao" <xianwei.zhao@amlogic.com>
> 
>> @@ -21,6 +21,7 @@ properties:
>>         - amlogic,meson-a1-pwrc
>>         - amlogic,meson-s4-pwrc
>>         - amlogic,c3-pwrc
>> +      - amlogic,t7-pwrc
>>
>>     "#power-domain-cells":
>>       const: 1
>> diff --git a/include/dt-bindings/power/amlogic,t7-pwrc.h b/include/dt-bindings/power/amlogic,t7-pwrc.h
>> new file mode 100644
>> index 000000000000..b7a13eda563c
>> --- /dev/null
>> +++ b/include/dt-bindings/power/amlogic,t7-pwrc.h
>> @@ -0,0 +1,63 @@
>> +/* SPDX-License-Identifier: (GPL-2.0-only OR .*) */
> 
> This does not look correct license. Use one recommended by checkpatch.
> 
Will fix it in next version.
> 
> 
> Best regards,
> Krzysztof
>