devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: like@awinic.com, lgirdwood@gmail.com, broonie@kernel.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	liweilei@awinic.com, liangdong@awinic.com,
	wangweidong.a@awinic.com
Subject: Re: [PATCH v2 2/2] regulator: dt-bindings: Correct yamllint warnings/errors
Date: Sat, 5 Aug 2023 22:00:04 +0200	[thread overview]
Message-ID: <fa32cc95-6b9d-01e6-b65a-d41f3aeeae4f@linaro.org> (raw)
In-Reply-To: <20230804102703.931418-3-like@awinic.com>

On 04/08/2023 12:27, like@awinic.com wrote:
> From: Alec Li <like@awinic.com>
> 

...

Subject: no improvements

> +
> +properties:
> +  compatible:
> +    const: awinic,aw37503
> +
> +  reg:
> +    maxItems: 1
> +
> +patternProperties:
> +  "^out[pn]$":
> +    type: object
> +    $ref: regulator.yaml#

This does not make much sense. You had here unvaluatedProperties. Why
dropping it? I asked to drop additionalProperties. Open the email and
look where the comments are given. In which context.

> +
> +additionalProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - outp
> +  - outn
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        regulator@3e {
> +            compatible = "awinic,aw37503";
> +            reg = <0x3e>;
> +
> +            outp {
> +                regulator-name = "outp";
> +                regulator-boot-on;
> +                regulator-always-on;
> +                enable-gpios = <&gpio 17 0>;

Please use proper defines.... you included the header for this.

Best regards,
Krzysztof


      parent reply	other threads:[~2023-08-05 20:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-04 10:27 [PATCH v2 0/2] regulator: aw37503: add regulator driver for AWINIC AW37503 like
2023-08-04 10:27 ` [PATCH v2 1/2] regulator: aw37503: Remove unneeded fields and switch to using dev_err_probe() like
2023-08-04 12:25   ` Mark Brown
2023-08-04 10:27 ` [PATCH v2 2/2] regulator: dt-bindings: Correct yamllint warnings/errors like
2023-08-04 16:27   ` Conor Dooley
2023-08-05 20:00   ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa32cc95-6b9d-01e6-b65a-d41f3aeeae4f@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=liangdong@awinic.com \
    --cc=like@awinic.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liweilei@awinic.com \
    --cc=robh+dt@kernel.org \
    --cc=wangweidong.a@awinic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).