From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Grant Likely" Subject: Re: [RFC/PATCH 2/3] of: add of_lookup_stdout() utility function Date: Wed, 6 Aug 2008 07:31:55 -0600 Message-ID: References: <20080806055214.30717.86092.stgit@trillian.secretlab.ca> <20080806060239.30717.79273.stgit@trillian.secretlab.ca> <20080805.233205.201125898.davem@davemloft.net> <18585.31504.836857.829592@cargo.ozlabs.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <18585.31504.836857.829592@cargo.ozlabs.ibm.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org To: Paul Mackerras Cc: devicetree-discuss@ozlabs.org, miltonm@bga.com, linuxppc-dev@ozlabs.org, David Miller List-Id: devicetree@vger.kernel.org On Wed, Aug 6, 2008 at 4:21 AM, Paul Mackerras wrote: > David Miller writes: > >> On sparc platforms this is obtained differently. We obtain the 32-bit >> instance value of "/chosen/stdout" and convert that into a prom device >> node path using "instance-to-path". > > That's actually exactly what we do too, the linux,stdout-path property > is just a cache of the result of that process. The difference is that > we have to do it early on while we still have OF around, while you can > do it later. It's not what we do with flattened device trees blobs though. In the flattened tree we're not using a /chosen/stdout property, just the linux,stdout-path one. The question that remains is; should there be? Should the dt blobs use /chosen/stdout also? (I'm not familiar enough with real OF to know the answer. I'm assuming that an instance value is not the same as a phandle). g. > > Paul. > -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.